[GitHub] [james-project] chibenwa commented on a change in pull request #400: JAMES-3567 Distributed server should not depend on ActiveMQ

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #400:
URL: https://github.com/apache/james-project/pull/400#discussion_r618866456



##########
File path: server/container/guice/cassandra-rabbitmq-guice/pom.xml
##########
@@ -110,10 +115,6 @@
             <artifactId>event-sourcing-event-store-memory</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>${james.groupId}</groupId>

Review comment:
       Yes. A guice server bundling Cassandra, ES, ActiveMQ.
   
   We suffer from having no clearer separation between our guice modules and our apps.
   
   I would be in favor of something like this:
   
   ```
   server/apps/spring
   server/apps/memory
   server/apps/distributed
   server/apps/jpa
   server/apps/jpa-smtp
   server/apps/cassandra //-es-activemq
   server/containers/guice/... // all module definitions would go here
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org