You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/26 11:40:19 UTC

[GitHub] [iotdb] RYH61 opened a new pull request, #6781: [IOTDB-3865] Cluster tool show confignodes

RYH61 opened a new pull request, #6781:
URL: https://github.com/apache/iotdb/pull/6781

   add tool show confignodes :
   ![图片](https://user-images.githubusercontent.com/79885238/180997343-83c17d36-1aa5-4cb6-8451-95b129a85ed5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6781: [IOTDB-3865] Cluster tool show confignodes

Posted by GitBox <gi...@apache.org>.

CRZbulabula commented on code in PR #6781:
URL: https://github.com/apache/iotdb/pull/6781#discussion_r930641771


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/NodeManager.java:
##########
@@ -236,6 +238,27 @@ public List<TDataNodeInfo> getRegisteredDataNodeInfoList() {
     }
     return dataNodeInfoList;
   }
+
+  public List<TConfigNodeInfo> getRegisteredConfigNodeInfoList() {
+    List<TConfigNodeInfo> configNodeInfoList = new ArrayList<>();
+    List<TConfigNodeLocation> registeredConfigNodes = this.getRegisteredConfigNodes();
+    if (registeredConfigNodes != null) {
+      registeredConfigNodes.forEach(
+          (configNodeInfo) -> {

Review Comment:
   ```suggestion
             (configNodeLocation) -> {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] Beyyes merged pull request #6781: [IOTDB-3865] Cluster tool show confignodes

Posted by GitBox <gi...@apache.org>.

Beyyes merged PR #6781:
URL: https://github.com/apache/iotdb/pull/6781


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org