[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9506: [Feature](Nereids) Data structure of comparison predicate

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #9506:
URL: https://github.com/apache/incubator-doris/pull/9506#discussion_r870418536


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/NotEqualTo.java:
##########
@@ -0,0 +1,44 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions;
+
+import org.apache.doris.nereids.exceptions.UnboundException;
+import org.apache.doris.nereids.trees.NodeType;
+
+public class NotEqualTo<LEFT_CHILD_TYPE extends Expression, RIGHT_CHILD_TYPE extends Expression>

Review Comment:
   Changed



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/Patterns.java:
##########
@@ -329,33 +328,31 @@ default PatternDescriptor<SlotReference, Expression> slotReference() {
     }
 
     /**
-     * create a binaryPredicate pattern.
+     * TODO create a ComparisonPredicate pattern.
      */
-    default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate() {
-        return new PatternDescriptor<>(
-                new Pattern<>(NodeType.BINARY_PREDICATE),
-                defaultPromise()
-        );
-    }
 
     /**
-     * create a binaryPredicate pattern with operator type.
+     * TODO create a ComparisonPredicate pattern with children patterns.
      */
-    default PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression> binaryPredicate(Operator operator) {
-        return new PatternDescriptor<BinaryPredicate<Expression, Expression>, Expression>(
-                new Pattern<>(NodeType.BINARY_PREDICATE),
+
+    /**
+     * create a equal to predicate pattern.
+     */
+    default PatternDescriptor<EqualTo<Expression, Expression>, Expression> eqcomparisonPredicate() {
+        return new PatternDescriptor<>(
+                new Pattern<>(NodeType.EQ_COMPARISON_PREDICATE),
                 defaultPromise()
-        ).when(p -> p.getOperator() == operator);
+        );
     }
 
     /**
-     * create a binaryPredicate pattern with children patterns.
+     * create a equal to predicate pattern with children patterns.
      */
-    default <C1 extends Expression, C2 extends Expression> PatternDescriptor<BinaryPredicate<C1, C2>, Expression>
-            binaryPredicate(PatternDescriptor<C1, Expression> leftChildPattern,
+    default <C1 extends Expression, C2 extends Expression> PatternDescriptor<EqualTo<C1, C2>, Expression>
+    eqcomparisonPredicate(PatternDescriptor<C1, Expression> leftChildPattern,

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org