You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:06:04 UTC
[GitHub] [incubator-inlong] doleyzi opened a new pull request, #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
doleyzi opened a new pull request, #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522
### Prepare a Pull Request
*(Change the title refer to the following example)*
- [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/incubator-inlong/issues) number)*
- Fixes #4520
### Modifications
- add pulsar auth switch and token in inlong-audit application.properties
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889881739
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
Review Comment:
pulsarEnableTokenAuth = false
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
the default value change to an empty value.
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -77,6 +79,8 @@ agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
Review Comment:
ditto
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
+ public String pulsarAuthToken;
Review Comment:
pulsarTokenAuth
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -77,6 +79,8 @@ agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
ditto
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
Review Comment:
the default value change to false may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] doleyzi commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
doleyzi commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889890894
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
+ public String pulsarAuthToken;
Review Comment:
fix
##########
inlong-audit/audit-proxy/src/main/java/org/apache/inlong/audit/sink/pulsar/PulsarClientService.java:
##########
@@ -76,11 +82,14 @@ public class PulsarClientService {
public ConcurrentHashMap<String, Producer> producerInfoMap;
public PulsarClient pulsarClient;
public String pulsarServerUrl;
+ public boolean pulsarEnableAuth = true;
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] doleyzi commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
doleyzi commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889890705
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
fix
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] doleyzi commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
doleyzi commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889890542
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -77,6 +79,8 @@ agent1.sinks.pulsar-sink-msg2.channel = ch-msg2
agent1.sinks.pulsar-sink-msg2.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg2.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg2.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4522: [INLONG-4520][Audit] Audit-proxy supports Pulsar authenticate
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4522:
URL: https://github.com/apache/incubator-inlong/pull/4522#discussion_r889885518
##########
inlong-audit/conf/audit-proxy-pulsar.conf:
##########
@@ -61,6 +61,8 @@ agent1.sinks.pulsar-sink-msg1.channel = ch-msg1
agent1.sinks.pulsar-sink-msg1.type = org.apache.inlong.audit.sink.PulsarSink
agent1.sinks.pulsar-sink-msg1.pulsar_server_url = pulsar://localhost:6650
agent1.sinks.pulsar-sink-msg1.topic = persistent://public/default/inlong-audit
+agent1.sinks.pulsar-sink-msg1.enable_auth = true
+agent1.sinks.pulsar-sink-msg1.auth_token = token
Review Comment:
enable_auth
->
enable_token_auth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org