You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/18 13:03:23 UTC
[GitHub] [arrow-testing] jmgpeeters opened a new pull request #60: ARROW-11838: fix offset buffer in golden file.
jmgpeeters opened a new pull request #60:
URL: https://github.com/apache/arrow-testing/pull/60
Chasing the Java integration errors in https://github.com/apache/arrow/pull/9629 (although C++ passes), it appears I misunderstood the correct layout for the offset buffer (for ["foo", "bar", "baz"] needs to be [0, 3, 6, 9] and not [0, 3, 6]).
I have fixed this and verified locally that it works with both C++ and Java. Sorry about that.
@pitrou has context on this, so probably a good one to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-testing] pitrou commented on pull request #60: ARROW-11838: fix offset buffer in golden file.
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #60:
URL: https://github.com/apache/arrow-testing/pull/60#issuecomment-801922086
Hmm, C++ shouldn't have accepted the non-conformant buffer. Can you try to find where the missing checks need to be added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-testing] pitrou merged pull request #60: ARROW-11838: fix offset buffer in golden file.
Posted by GitBox <gi...@apache.org>.
pitrou merged pull request #60:
URL: https://github.com/apache/arrow-testing/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-testing] jmgpeeters commented on pull request #60: ARROW-11838: fix offset buffer in golden file.
Posted by GitBox <gi...@apache.org>.
jmgpeeters commented on pull request #60:
URL: https://github.com/apache/arrow-testing/pull/60#issuecomment-802687306
@pitrou I've implemented some additional checks in the Arrow sister PR. The C++ integration check (https://github.com/apache/arrow/pull/9629/checks?check_run_id=2142504660) now fails with:
````
RuntimeError: Command failed: /build/cpp/debug/arrow-json-integration-test --integration --arrow=/arrow/testing/data/arrow-ipc-stream/integration/4.0.0-shareddict/generated_shared_dict.arrow_file --json=/tmp/tmprjve0h7q/4.0.0-shareddict_shared_dict.gold.json --mode=VALIDATE
With output:
--------------
Error message: Invalid: JSON OFFSET array size differs from advertised array length + 1
````
(i.e. because [0, 3, 6] is one too short).
and it has similarly useful errors (verified locally) if
- OFFSETs is missing altogether
- one would do e.g. [0, 3, 6, 10] instead of the correct [0, 3, 6, 9]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-testing] jmgpeeters commented on pull request #60: ARROW-11838: fix offset buffer in golden file.
Posted by GitBox <gi...@apache.org>.
jmgpeeters commented on pull request #60:
URL: https://github.com/apache/arrow-testing/pull/60#issuecomment-801926268
Yep, will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org