You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pengxiang-hao (via GitHub)" <gi...@apache.org> on 2023/01/31 05:21:00 UTC
[GitHub] [nuttx-apps] pengxiang-hao opened a new pull request, #1517: netutils/cjson: fix unpackage error when local gerrit does not exist
pengxiang-hao opened a new pull request, #1517:
URL: https://github.com/apache/nuttx-apps/pull/1517
Signed-off-by: haopengxiang <ha...@xiaomi.com>
## Summary
if no cjson repo exist in local, download specific version cJSON and `tar` those into foler(cJSON), but not folder "v1.7.12.tar.gz"
## Impact
fix error https://github.com/apache/nuttx-apps/issues/1516 with downloaded has
## Testing
Local check without cJSON repo passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1517: netutils/cjson: fix unpackage error when local gerrit does not exist
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1517:
URL: https://github.com/apache/nuttx-apps/pull/1517#discussion_r1091510457
##########
netutils/cjson/Makefile:
##########
@@ -54,7 +54,7 @@ $(CJSON_TARBALL):
$(CJSON_UNPACKNAME): $(CJSON_TARBALL)
@echo "Unpacking: $(CJSON_TARBALL) -> $(CJSON_UNPACKNAME)"
- $(Q) $(UNPACK) $(CJSON_TARBALL)
+ $(Q) $(UNPACK) $(CJSON_TARBALL) --one-top-level=$(CJSON_UNPACKNAME) --strip-components=1
Review Comment:
let's change to mv? I am afraid that unzip on other OS mayn't support --one-top-level --strip-components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko merged pull request #1517: netutils/cjson: fix unpackage error when local gerrit does not exist
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #1517:
URL: https://github.com/apache/nuttx-apps/pull/1517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org