[GitHub] KevinYang21 commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop from scheduler loop

[GitBox <gi...@apache.org>]

KevinYang21 commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop from scheduler loop
URL: https://github.com/apache/incubator-airflow/pull/3873#discussion_r221396632
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -70,6 +70,7 @@ simple_log_format = %%(asctime)s %%(levelname)s - %%(message)s
 # we need to escape the curly braces by adding an additional curly brace
 log_filename_template = {{{{ ti.dag_id }}}}/{{{{ ti.task_id }}}}/{{{{ ts }}}}/{{{{ try_number }}}}.log
 log_processor_filename_template = {{{{ filename }}}}.log
+dag_processor_manager_log_location = {AIRFLOW_HOME}/logs/dag_processor_manager/dag_processor_manager.log
 
 Review comment:
   lol, I started with `log_dag_processor_manager_location` and then switched back because it reads bit weird to me... (`log_filename_template` reads good but `log_prodcessor_file_template` also reads weird to me, wondering if `log_prodcessor_file_template` was just named because the author saw the previous template config starts with log) I would actually even prefer to rename `log_processor_filename_template ` to make the names more intuitive to understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services