You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Luca Cavanna <ja...@apache.org> on 2024/10/05 17:36:30 UTC
[VOTE] Release Lucene 10.0.0 RC3
Please vote for release candidate 3 for Lucene 10.0.0
I published a draft of the release notes at
https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 .
Feedback is welcome. Feel free to edit directly.
The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
You can run the smoke tester directly with this command:
python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00 UTC.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Here is my +1
SUCCESS! [0:38:43.010208]
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Adrien Grand <jp...@gmail.com>.
+1 SUCCESS! [0:45:13.431457]
On Sun, Oct 6, 2024 at 12:23 PM Michael McCandless <
lucene@mikemccandless.com> wrote:
> +1
>
> SUCCESS! [0:22:54.616680]
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Sat, Oct 5, 2024 at 7:07 PM Nhat Nguyen <nh...@elastic.co.invalid>
> wrote:
>
>> SUCCESS! [1:30:00.371232]
>>
>> +1
>>
>> On Sat, Oct 5, 2024 at 1:30 PM Chris Hegarty
>> <ch...@elastic.co.invalid> wrote:
>>
>>>
>>> SUCCESS! [1:10:30.653744]
>>>
>>> +1
>>>
>>> -Chris.
>>>
>>>
>>> > On 5 Oct 2024, at 18:36, Luca Cavanna <ja...@apache.org> wrote:
>>> >
>>> > Please vote for release candidate 3 for Lucene 10.0.0
>>> >
>>> > I published a draft of the release notes at
>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>> . Feedback is welcome. Feel free to edit directly.
>>> >
>>> > The artifacts can be downloaded from:
>>> >
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>> >
>>> > You can run the smoke tester directly with this command:
>>> >
>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>>> >
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>> >
>>> > The vote will be open for at least 72 hours i.e. until 2024-10-09
>>> 17:00 UTC.
>>> >
>>> > [ ] +1 approve
>>> > [ ] +0 no opinion
>>> > [ ] -1 disapprove (and reason why)
>>> >
>>> > Here is my +1
>>> >
>>> > SUCCESS! [0:38:43.010208]
>>> >
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
--
Adrien
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Michael McCandless <lu...@mikemccandless.com>.
+1
SUCCESS! [0:22:54.616680]
Mike McCandless
http://blog.mikemccandless.com
On Sat, Oct 5, 2024 at 7:07 PM Nhat Nguyen <nh...@elastic.co.invalid>
wrote:
> SUCCESS! [1:30:00.371232]
>
> +1
>
> On Sat, Oct 5, 2024 at 1:30 PM Chris Hegarty
> <ch...@elastic.co.invalid> wrote:
>
>>
>> SUCCESS! [1:10:30.653744]
>>
>> +1
>>
>> -Chris.
>>
>>
>> > On 5 Oct 2024, at 18:36, Luca Cavanna <ja...@apache.org> wrote:
>> >
>> > Please vote for release candidate 3 for Lucene 10.0.0
>> >
>> > I published a draft of the release notes at
>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>> . Feedback is welcome. Feel free to edit directly.
>> >
>> > The artifacts can be downloaded from:
>> >
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>> >
>> > You can run the smoke tester directly with this command:
>> >
>> > python3 -u dev-tools/scripts/smokeTestRelease.py \
>> >
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>> >
>> > The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00
>> UTC.
>> >
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove (and reason why)
>> >
>> > Here is my +1
>> >
>> > SUCCESS! [0:38:43.010208]
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Nhat Nguyen <nh...@elastic.co.INVALID>.
SUCCESS! [1:30:00.371232]
+1
On Sat, Oct 5, 2024 at 1:30 PM Chris Hegarty
<ch...@elastic.co.invalid> wrote:
>
> SUCCESS! [1:10:30.653744]
>
> +1
>
> -Chris.
>
>
> > On 5 Oct 2024, at 18:36, Luca Cavanna <ja...@apache.org> wrote:
> >
> > Please vote for release candidate 3 for Lucene 10.0.0
> >
> > I published a draft of the release notes at
> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 .
> Feedback is welcome. Feel free to edit directly.
> >
> > The artifacts can be downloaded from:
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
> >
> > You can run the smoke tester directly with this command:
> >
> > python3 -u dev-tools/scripts/smokeTestRelease.py \
> >
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
> >
> > The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00
> UTC.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Here is my +1
> >
> > SUCCESS! [0:38:43.010208]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Chris Hegarty <ch...@elastic.co.INVALID>.
SUCCESS! [1:10:30.653744]
+1
-Chris.
> On 5 Oct 2024, at 18:36, Luca Cavanna <ja...@apache.org> wrote:
>
> Please vote for release candidate 3 for Lucene 10.0.0
>
> I published a draft of the release notes at https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 . Feedback is welcome. Feel free to edit directly.
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>
> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00 UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:38:43.010208]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Ignacio Vera <iv...@gmail.com>.
hi,
If we are going to respin I would like to consider this PR
https://github.com/apache/lucene/pull/13877 which is a forward port of
a change we did in 9.11.1 which has arised after we reverted
https://github.com/apache/lucene/pull/13857. The change is
straightforward so I don't think there is any risk here.
Thanks,
Ignacio
On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com> wrote:
>
>
> If we're respinning, can I also add this to the release branch?
>
> https://github.com/apache/lucene/pull/13825
>
> This change affects the API of DataInput, which is an important core interface, but it does have a strong rationale for people who use these classes directly in downstream libraries.
>
> I'll apply this change to branch_10x right now - without touching the release branch.
>
> Dawid
>
> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <lu...@mikemccandless.com> wrote:
>>
>> Hello,
>>
>> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
>>
>> https://github.com/apache/lucene/issues/13867
>>
>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written indices using HNSW scalar quantization at defaults. I have not tested but I strongly expect the current 10.0.0 RC to also have broken reading 9.11.x written indices (with HNSW scalar quantization) too. Thank you to Ionut Anghelcovici Lucene user for catching this and opening a well-written issue.
>>
>> I'm first (now) trying to understand why our BWC tests are not catching this...
>>
>> Separately, this at least (sigh) shows the benefits of releasing 9.last before 10.0! Sorry about all of this!!
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com> wrote:
>>>
>>> +1
>>> SUCCESS! [1:08:46.194765]
>>>
>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com> wrote:
>>>>
>>>> +1 SUCCESS! [0:48:25.853452]
>>>>
>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com> wrote:
>>>> >
>>>> > +1 SUCCESS! [0:40:01.995275]
>>>> >
>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
>>>> >>
>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>> >>
>>>> >> I published a draft of the release notes at https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 . Feedback is welcome. Feel free to edit directly.
>>>> >>
>>>> >> The artifacts can be downloaded from:
>>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>> >>
>>>> >> You can run the smoke tester directly with this command:
>>>> >>
>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>> >>
>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00 UTC.
>>>> >>
>>>> >> [ ] +1 approve
>>>> >> [ ] +0 no opinion
>>>> >> [ ] -1 disapprove (and reason why)
>>>> >>
>>>> >> Here is my +1
>>>> >>
>>>> >> SUCCESS! [0:38:43.010208]
>>>> >>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Luca Cavanna <ja...@apache.org>.
No worries at all Mike, thanks for the hard work everyone involved! I am
happy we fixed the issue and were able to backport a couple more fixes.
Cheers
Luca
On Thu, Oct 10, 2024 at 1:50 AM Michael McCandless <
lucene@mikemccandless.com> wrote:
> OK I cherry-pick'd to 10.0.x and 10.x ... I think release is unblocked
> again! Sorry about all of this ...
>
> I'll watch CI builds for any issues.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Wed, Oct 9, 2024 at 4:43 PM Michael McCandless <
> lucene@mikemccandless.com> wrote:
>
>> OK the 9.12.x PR is merged ... I'll next cherry-pick to 10.0.x and 10.x.
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Wed, Oct 9, 2024 at 12:36 PM Michael McCandless <
>> lucene@mikemccandless.com> wrote:
>>
>>> Thanks Luca, I'm still actively working on the back compat break /
>>> blocker. I'm hoping to finish the PR and merge it to 9.12.x later today,
>>> and then forward port to 10.0.x and 10.x.
>>>
>>> Mike McCandless
>>>
>>> http://blog.mikemccandless.com
>>>
>>>
>>> On Wed, Oct 9, 2024 at 12:19 PM Luca Cavanna <ja...@apache.org> wrote:
>>>
>>>> All of the backports that we wanted to get in have been cherry picked,
>>>> as far as I know.
>>>>
>>>> I've seen quite a bit of activity on different PRs around the release
>>>> blocker, I know there's a couple of in-flight PRs, please give me a shout
>>>> when we are ready to go and I'll respin.
>>>>
>>>> Thanks
>>>> Luca
>>>>
>>>> On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <ja...@apache.org>
>>>> wrote:
>>>>
>>>>> Thanks for raising this Mike, I am good with respinning.
>>>>>
>>>>> Chris is looking into the fix for the release blocker at
>>>>> https://github.com/apache/lucene/pull/13874 and forward porting it to
>>>>> branch_10_0.
>>>>>
>>>>> Dawid, I am also good with backporting your fix, I commented in the PR
>>>>> about adding a missing CHANGES entry. Does this also need to be mentioned
>>>>> in the migrate guide?
>>>>>
>>>>> Another change we would like to make in branch_10_0 is
>>>>> https://github.com/apache/lucene/pull/13877 . This was made only in
>>>>> 9x so far, and is needed in 10 as well now that
>>>>> https://github.com/apache/lucene/pull/13221 has been reverted.
>>>>>
>>>>> I will go ahead and merge https://github.com/apache/lucene/pull/13858
>>>>> as well.
>>>>>
>>>>>
>>>>> Cheers
>>>>> Luca
>>>>>
>>>>> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> If we're respinning, can I also add this to the release branch?
>>>>>>
>>>>>> https://github.com/apache/lucene/pull/13825
>>>>>>
>>>>>> This change affects the API of DataInput, which is an important core
>>>>>> interface, but it does have a strong rationale for people who use these
>>>>>> classes directly in downstream libraries.
>>>>>>
>>>>>> I'll apply this change to branch_10x right now - without touching the
>>>>>> release branch.
>>>>>>
>>>>>> Dawid
>>>>>>
>>>>>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
>>>>>> lucene@mikemccandless.com> wrote:
>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> Alas, I fear this issue is likely a (late breaking!) blocker for
>>>>>>> 10.0.0?
>>>>>>>
>>>>>>> https://github.com/apache/lucene/issues/13867
>>>>>>>
>>>>>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x
>>>>>>> written indices using HNSW scalar quantization at defaults. I have not
>>>>>>> tested but I strongly expect the current 10.0.0 RC to also have broken
>>>>>>> reading 9.11.x written indices (with HNSW scalar quantization) too. Thank
>>>>>>> you to Ionut Anghelcovici Lucene user for catching this and opening a
>>>>>>> well-written issue.
>>>>>>>
>>>>>>> I'm first (now) trying to understand why our BWC tests are not
>>>>>>> catching this...
>>>>>>>
>>>>>>> Separately, this at least (sigh) shows the benefits of
>>>>>>> releasing 9.last before 10.0! Sorry about all of this!!
>>>>>>>
>>>>>>> Mike McCandless
>>>>>>>
>>>>>>> http://blog.mikemccandless.com
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1
>>>>>>>> SUCCESS! [1:08:46.194765]
>>>>>>>>
>>>>>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <
>>>>>>>> ben.w.trent@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> +1 SUCCESS! [0:48:25.853452]
>>>>>>>>>
>>>>>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <
>>>>>>>>> stefan.vodita@gmail.com> wrote:
>>>>>>>>> >
>>>>>>>>> > +1 SUCCESS! [0:40:01.995275]
>>>>>>>>> >
>>>>>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org>
>>>>>>>>> wrote:
>>>>>>>>> >>
>>>>>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>>>>>>> >>
>>>>>>>>> >> I published a draft of the release notes at
>>>>>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>>>>>>> . Feedback is welcome. Feel free to edit directly.
>>>>>>>>> >>
>>>>>>>>> >> The artifacts can be downloaded from:
>>>>>>>>> >>
>>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>>>> >>
>>>>>>>>> >> You can run the smoke tester directly with this command:
>>>>>>>>> >>
>>>>>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>>>>> >>
>>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>>>> >>
>>>>>>>>> >> The vote will be open for at least 72 hours i.e. until
>>>>>>>>> 2024-10-09 17:00 UTC.
>>>>>>>>> >>
>>>>>>>>> >> [ ] +1 approve
>>>>>>>>> >> [ ] +0 no opinion
>>>>>>>>> >> [ ] -1 disapprove (and reason why)
>>>>>>>>> >>
>>>>>>>>> >> Here is my +1
>>>>>>>>> >>
>>>>>>>>> >> SUCCESS! [0:38:43.010208]
>>>>>>>>> >>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>>>>>
>>>>>>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I cherry-pick'd to 10.0.x and 10.x ... I think release is unblocked
again! Sorry about all of this ...
I'll watch CI builds for any issues.
Mike McCandless
http://blog.mikemccandless.com
On Wed, Oct 9, 2024 at 4:43 PM Michael McCandless <lu...@mikemccandless.com>
wrote:
> OK the 9.12.x PR is merged ... I'll next cherry-pick to 10.0.x and 10.x.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Wed, Oct 9, 2024 at 12:36 PM Michael McCandless <
> lucene@mikemccandless.com> wrote:
>
>> Thanks Luca, I'm still actively working on the back compat break /
>> blocker. I'm hoping to finish the PR and merge it to 9.12.x later today,
>> and then forward port to 10.0.x and 10.x.
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Wed, Oct 9, 2024 at 12:19 PM Luca Cavanna <ja...@apache.org> wrote:
>>
>>> All of the backports that we wanted to get in have been cherry picked,
>>> as far as I know.
>>>
>>> I've seen quite a bit of activity on different PRs around the release
>>> blocker, I know there's a couple of in-flight PRs, please give me a shout
>>> when we are ready to go and I'll respin.
>>>
>>> Thanks
>>> Luca
>>>
>>> On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <ja...@apache.org> wrote:
>>>
>>>> Thanks for raising this Mike, I am good with respinning.
>>>>
>>>> Chris is looking into the fix for the release blocker at
>>>> https://github.com/apache/lucene/pull/13874 and forward porting it to
>>>> branch_10_0.
>>>>
>>>> Dawid, I am also good with backporting your fix, I commented in the PR
>>>> about adding a missing CHANGES entry. Does this also need to be mentioned
>>>> in the migrate guide?
>>>>
>>>> Another change we would like to make in branch_10_0 is
>>>> https://github.com/apache/lucene/pull/13877 . This was made only in 9x
>>>> so far, and is needed in 10 as well now that
>>>> https://github.com/apache/lucene/pull/13221 has been reverted.
>>>>
>>>> I will go ahead and merge https://github.com/apache/lucene/pull/13858
>>>> as well.
>>>>
>>>>
>>>> Cheers
>>>> Luca
>>>>
>>>> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com>
>>>> wrote:
>>>>
>>>>>
>>>>> If we're respinning, can I also add this to the release branch?
>>>>>
>>>>> https://github.com/apache/lucene/pull/13825
>>>>>
>>>>> This change affects the API of DataInput, which is an important core
>>>>> interface, but it does have a strong rationale for people who use these
>>>>> classes directly in downstream libraries.
>>>>>
>>>>> I'll apply this change to branch_10x right now - without touching the
>>>>> release branch.
>>>>>
>>>>> Dawid
>>>>>
>>>>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
>>>>> lucene@mikemccandless.com> wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> Alas, I fear this issue is likely a (late breaking!) blocker for
>>>>>> 10.0.0?
>>>>>>
>>>>>> https://github.com/apache/lucene/issues/13867
>>>>>>
>>>>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x
>>>>>> written indices using HNSW scalar quantization at defaults. I have not
>>>>>> tested but I strongly expect the current 10.0.0 RC to also have broken
>>>>>> reading 9.11.x written indices (with HNSW scalar quantization) too. Thank
>>>>>> you to Ionut Anghelcovici Lucene user for catching this and opening a
>>>>>> well-written issue.
>>>>>>
>>>>>> I'm first (now) trying to understand why our BWC tests are not
>>>>>> catching this...
>>>>>>
>>>>>> Separately, this at least (sigh) shows the benefits of
>>>>>> releasing 9.last before 10.0! Sorry about all of this!!
>>>>>>
>>>>>> Mike McCandless
>>>>>>
>>>>>> http://blog.mikemccandless.com
>>>>>>
>>>>>>
>>>>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> +1
>>>>>>> SUCCESS! [1:08:46.194765]
>>>>>>>
>>>>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 SUCCESS! [0:48:25.853452]
>>>>>>>>
>>>>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <
>>>>>>>> stefan.vodita@gmail.com> wrote:
>>>>>>>> >
>>>>>>>> > +1 SUCCESS! [0:40:01.995275]
>>>>>>>> >
>>>>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org>
>>>>>>>> wrote:
>>>>>>>> >>
>>>>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>>>>>> >>
>>>>>>>> >> I published a draft of the release notes at
>>>>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>>>>>> . Feedback is welcome. Feel free to edit directly.
>>>>>>>> >>
>>>>>>>> >> The artifacts can be downloaded from:
>>>>>>>> >>
>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>>> >>
>>>>>>>> >> You can run the smoke tester directly with this command:
>>>>>>>> >>
>>>>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>>>> >>
>>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>>> >>
>>>>>>>> >> The vote will be open for at least 72 hours i.e. until
>>>>>>>> 2024-10-09 17:00 UTC.
>>>>>>>> >>
>>>>>>>> >> [ ] +1 approve
>>>>>>>> >> [ ] +0 no opinion
>>>>>>>> >> [ ] -1 disapprove (and reason why)
>>>>>>>> >>
>>>>>>>> >> Here is my +1
>>>>>>>> >>
>>>>>>>> >> SUCCESS! [0:38:43.010208]
>>>>>>>> >>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>>>>
>>>>>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Michael McCandless <lu...@mikemccandless.com>.
OK the 9.12.x PR is merged ... I'll next cherry-pick to 10.0.x and 10.x.
Mike McCandless
http://blog.mikemccandless.com
On Wed, Oct 9, 2024 at 12:36 PM Michael McCandless <
lucene@mikemccandless.com> wrote:
> Thanks Luca, I'm still actively working on the back compat break /
> blocker. I'm hoping to finish the PR and merge it to 9.12.x later today,
> and then forward port to 10.0.x and 10.x.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Wed, Oct 9, 2024 at 12:19 PM Luca Cavanna <ja...@apache.org> wrote:
>
>> All of the backports that we wanted to get in have been cherry picked, as
>> far as I know.
>>
>> I've seen quite a bit of activity on different PRs around the release
>> blocker, I know there's a couple of in-flight PRs, please give me a shout
>> when we are ready to go and I'll respin.
>>
>> Thanks
>> Luca
>>
>> On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <ja...@apache.org> wrote:
>>
>>> Thanks for raising this Mike, I am good with respinning.
>>>
>>> Chris is looking into the fix for the release blocker at
>>> https://github.com/apache/lucene/pull/13874 and forward porting it to
>>> branch_10_0.
>>>
>>> Dawid, I am also good with backporting your fix, I commented in the PR
>>> about adding a missing CHANGES entry. Does this also need to be mentioned
>>> in the migrate guide?
>>>
>>> Another change we would like to make in branch_10_0 is
>>> https://github.com/apache/lucene/pull/13877 . This was made only in 9x
>>> so far, and is needed in 10 as well now that
>>> https://github.com/apache/lucene/pull/13221 has been reverted.
>>>
>>> I will go ahead and merge https://github.com/apache/lucene/pull/13858
>>> as well.
>>>
>>>
>>> Cheers
>>> Luca
>>>
>>> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com>
>>> wrote:
>>>
>>>>
>>>> If we're respinning, can I also add this to the release branch?
>>>>
>>>> https://github.com/apache/lucene/pull/13825
>>>>
>>>> This change affects the API of DataInput, which is an important core
>>>> interface, but it does have a strong rationale for people who use these
>>>> classes directly in downstream libraries.
>>>>
>>>> I'll apply this change to branch_10x right now - without touching the
>>>> release branch.
>>>>
>>>> Dawid
>>>>
>>>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
>>>> lucene@mikemccandless.com> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> Alas, I fear this issue is likely a (late breaking!) blocker for
>>>>> 10.0.0?
>>>>>
>>>>> https://github.com/apache/lucene/issues/13867
>>>>>
>>>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x
>>>>> written indices using HNSW scalar quantization at defaults. I have not
>>>>> tested but I strongly expect the current 10.0.0 RC to also have broken
>>>>> reading 9.11.x written indices (with HNSW scalar quantization) too. Thank
>>>>> you to Ionut Anghelcovici Lucene user for catching this and opening a
>>>>> well-written issue.
>>>>>
>>>>> I'm first (now) trying to understand why our BWC tests are not
>>>>> catching this...
>>>>>
>>>>> Separately, this at least (sigh) shows the benefits of
>>>>> releasing 9.last before 10.0! Sorry about all of this!!
>>>>>
>>>>> Mike McCandless
>>>>>
>>>>> http://blog.mikemccandless.com
>>>>>
>>>>>
>>>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> +1
>>>>>> SUCCESS! [1:08:46.194765]
>>>>>>
>>>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> +1 SUCCESS! [0:48:25.853452]
>>>>>>>
>>>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <
>>>>>>> stefan.vodita@gmail.com> wrote:
>>>>>>> >
>>>>>>> > +1 SUCCESS! [0:40:01.995275]
>>>>>>> >
>>>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org>
>>>>>>> wrote:
>>>>>>> >>
>>>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>>>>> >>
>>>>>>> >> I published a draft of the release notes at
>>>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>>>>> . Feedback is welcome. Feel free to edit directly.
>>>>>>> >>
>>>>>>> >> The artifacts can be downloaded from:
>>>>>>> >>
>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>> >>
>>>>>>> >> You can run the smoke tester directly with this command:
>>>>>>> >>
>>>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>>> >>
>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>>> >>
>>>>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>>>>>>> 17:00 UTC.
>>>>>>> >>
>>>>>>> >> [ ] +1 approve
>>>>>>> >> [ ] +0 no opinion
>>>>>>> >> [ ] -1 disapprove (and reason why)
>>>>>>> >>
>>>>>>> >> Here is my +1
>>>>>>> >>
>>>>>>> >> SUCCESS! [0:38:43.010208]
>>>>>>> >>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>>>
>>>>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Michael McCandless <lu...@mikemccandless.com>.
Thanks Luca, I'm still actively working on the back compat break /
blocker. I'm hoping to finish the PR and merge it to 9.12.x later today,
and then forward port to 10.0.x and 10.x.
Mike McCandless
http://blog.mikemccandless.com
On Wed, Oct 9, 2024 at 12:19 PM Luca Cavanna <ja...@apache.org> wrote:
> All of the backports that we wanted to get in have been cherry picked, as
> far as I know.
>
> I've seen quite a bit of activity on different PRs around the release
> blocker, I know there's a couple of in-flight PRs, please give me a shout
> when we are ready to go and I'll respin.
>
> Thanks
> Luca
>
> On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <ja...@apache.org> wrote:
>
>> Thanks for raising this Mike, I am good with respinning.
>>
>> Chris is looking into the fix for the release blocker at
>> https://github.com/apache/lucene/pull/13874 and forward porting it to
>> branch_10_0.
>>
>> Dawid, I am also good with backporting your fix, I commented in the PR
>> about adding a missing CHANGES entry. Does this also need to be mentioned
>> in the migrate guide?
>>
>> Another change we would like to make in branch_10_0 is
>> https://github.com/apache/lucene/pull/13877 . This was made only in 9x
>> so far, and is needed in 10 as well now that
>> https://github.com/apache/lucene/pull/13221 has been reverted.
>>
>> I will go ahead and merge https://github.com/apache/lucene/pull/13858 as
>> well.
>>
>>
>> Cheers
>> Luca
>>
>> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com> wrote:
>>
>>>
>>> If we're respinning, can I also add this to the release branch?
>>>
>>> https://github.com/apache/lucene/pull/13825
>>>
>>> This change affects the API of DataInput, which is an important core
>>> interface, but it does have a strong rationale for people who use these
>>> classes directly in downstream libraries.
>>>
>>> I'll apply this change to branch_10x right now - without touching the
>>> release branch.
>>>
>>> Dawid
>>>
>>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
>>> lucene@mikemccandless.com> wrote:
>>>
>>>> Hello,
>>>>
>>>> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
>>>>
>>>> https://github.com/apache/lucene/issues/13867
>>>>
>>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x
>>>> written indices using HNSW scalar quantization at defaults. I have not
>>>> tested but I strongly expect the current 10.0.0 RC to also have broken
>>>> reading 9.11.x written indices (with HNSW scalar quantization) too. Thank
>>>> you to Ionut Anghelcovici Lucene user for catching this and opening a
>>>> well-written issue.
>>>>
>>>> I'm first (now) trying to understand why our BWC tests are not catching
>>>> this...
>>>>
>>>> Separately, this at least (sigh) shows the benefits of releasing 9.last
>>>> before 10.0! Sorry about all of this!!
>>>>
>>>> Mike McCandless
>>>>
>>>> http://blog.mikemccandless.com
>>>>
>>>>
>>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com>
>>>> wrote:
>>>>
>>>>> +1
>>>>> SUCCESS! [1:08:46.194765]
>>>>>
>>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> +1 SUCCESS! [0:48:25.853452]
>>>>>>
>>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
>>>>>> wrote:
>>>>>> >
>>>>>> > +1 SUCCESS! [0:40:01.995275]
>>>>>> >
>>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org>
>>>>>> wrote:
>>>>>> >>
>>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>>>> >>
>>>>>> >> I published a draft of the release notes at
>>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>>>> . Feedback is welcome. Feel free to edit directly.
>>>>>> >>
>>>>>> >> The artifacts can be downloaded from:
>>>>>> >>
>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>> >>
>>>>>> >> You can run the smoke tester directly with this command:
>>>>>> >>
>>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>>> >>
>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>>> >>
>>>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>>>>>> 17:00 UTC.
>>>>>> >>
>>>>>> >> [ ] +1 approve
>>>>>> >> [ ] +0 no opinion
>>>>>> >> [ ] -1 disapprove (and reason why)
>>>>>> >>
>>>>>> >> Here is my +1
>>>>>> >>
>>>>>> >> SUCCESS! [0:38:43.010208]
>>>>>> >>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>>
>>>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Luca Cavanna <ja...@apache.org>.
All of the backports that we wanted to get in have been cherry picked, as
far as I know.
I've seen quite a bit of activity on different PRs around the release
blocker, I know there's a couple of in-flight PRs, please give me a shout
when we are ready to go and I'll respin.
Thanks
Luca
On Wed, Oct 9, 2024 at 11:29 AM Luca Cavanna <ja...@apache.org> wrote:
> Thanks for raising this Mike, I am good with respinning.
>
> Chris is looking into the fix for the release blocker at
> https://github.com/apache/lucene/pull/13874 and forward porting it to
> branch_10_0.
>
> Dawid, I am also good with backporting your fix, I commented in the PR
> about adding a missing CHANGES entry. Does this also need to be mentioned
> in the migrate guide?
>
> Another change we would like to make in branch_10_0 is
> https://github.com/apache/lucene/pull/13877 . This was made only in 9x so
> far, and is needed in 10 as well now that
> https://github.com/apache/lucene/pull/13221 has been reverted.
>
> I will go ahead and merge https://github.com/apache/lucene/pull/13858 as
> well.
>
>
> Cheers
> Luca
>
> On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com> wrote:
>
>>
>> If we're respinning, can I also add this to the release branch?
>>
>> https://github.com/apache/lucene/pull/13825
>>
>> This change affects the API of DataInput, which is an important core
>> interface, but it does have a strong rationale for people who use these
>> classes directly in downstream libraries.
>>
>> I'll apply this change to branch_10x right now - without touching the
>> release branch.
>>
>> Dawid
>>
>> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
>> lucene@mikemccandless.com> wrote:
>>
>>> Hello,
>>>
>>> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
>>>
>>> https://github.com/apache/lucene/issues/13867
>>>
>>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written
>>> indices using HNSW scalar quantization at defaults. I have not tested but
>>> I strongly expect the current 10.0.0 RC to also have broken reading 9.11.x
>>> written indices (with HNSW scalar quantization) too. Thank you to Ionut
>>> Anghelcovici Lucene user for catching this and opening a well-written issue.
>>>
>>> I'm first (now) trying to understand why our BWC tests are not catching
>>> this...
>>>
>>> Separately, this at least (sigh) shows the benefits of releasing 9.last
>>> before 10.0! Sorry about all of this!!
>>>
>>> Mike McCandless
>>>
>>> http://blog.mikemccandless.com
>>>
>>>
>>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com> wrote:
>>>
>>>> +1
>>>> SUCCESS! [1:08:46.194765]
>>>>
>>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>>>> wrote:
>>>>
>>>>> +1 SUCCESS! [0:48:25.853452]
>>>>>
>>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> > +1 SUCCESS! [0:40:01.995275]
>>>>> >
>>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org>
>>>>> wrote:
>>>>> >>
>>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>>> >>
>>>>> >> I published a draft of the release notes at
>>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>>> . Feedback is welcome. Feel free to edit directly.
>>>>> >>
>>>>> >> The artifacts can be downloaded from:
>>>>> >>
>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>> >>
>>>>> >> You can run the smoke tester directly with this command:
>>>>> >>
>>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>>> >>
>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>>> >>
>>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>>>>> 17:00 UTC.
>>>>> >>
>>>>> >> [ ] +1 approve
>>>>> >> [ ] +0 no opinion
>>>>> >> [ ] -1 disapprove (and reason why)
>>>>> >>
>>>>> >> Here is my +1
>>>>> >>
>>>>> >> SUCCESS! [0:38:43.010208]
>>>>> >>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>
>>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Luca Cavanna <ja...@apache.org>.
Thanks for raising this Mike, I am good with respinning.
Chris is looking into the fix for the release blocker at
https://github.com/apache/lucene/pull/13874 and forward porting it to
branch_10_0.
Dawid, I am also good with backporting your fix, I commented in the PR
about adding a missing CHANGES entry. Does this also need to be mentioned
in the migrate guide?
Another change we would like to make in branch_10_0 is
https://github.com/apache/lucene/pull/13877 . This was made only in 9x so
far, and is needed in 10 as well now that
https://github.com/apache/lucene/pull/13221 has been reverted.
I will go ahead and merge https://github.com/apache/lucene/pull/13858 as
well.
Cheers
Luca
On Wed, Oct 9, 2024 at 9:37 AM Dawid Weiss <da...@gmail.com> wrote:
>
> If we're respinning, can I also add this to the release branch?
>
> https://github.com/apache/lucene/pull/13825
>
> This change affects the API of DataInput, which is an important core
> interface, but it does have a strong rationale for people who use these
> classes directly in downstream libraries.
>
> I'll apply this change to branch_10x right now - without touching the
> release branch.
>
> Dawid
>
> On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <
> lucene@mikemccandless.com> wrote:
>
>> Hello,
>>
>> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
>>
>> https://github.com/apache/lucene/issues/13867
>>
>> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written
>> indices using HNSW scalar quantization at defaults. I have not tested but
>> I strongly expect the current 10.0.0 RC to also have broken reading 9.11.x
>> written indices (with HNSW scalar quantization) too. Thank you to Ionut
>> Anghelcovici Lucene user for catching this and opening a well-written issue.
>>
>> I'm first (now) trying to understand why our BWC tests are not catching
>> this...
>>
>> Separately, this at least (sigh) shows the benefits of releasing 9.last
>> before 10.0! Sorry about all of this!!
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com> wrote:
>>
>>> +1
>>> SUCCESS! [1:08:46.194765]
>>>
>>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>>> wrote:
>>>
>>>> +1 SUCCESS! [0:48:25.853452]
>>>>
>>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
>>>> wrote:
>>>> >
>>>> > +1 SUCCESS! [0:40:01.995275]
>>>> >
>>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
>>>> >>
>>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>>> >>
>>>> >> I published a draft of the release notes at
>>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>>> . Feedback is welcome. Feel free to edit directly.
>>>> >>
>>>> >> The artifacts can be downloaded from:
>>>> >>
>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>> >>
>>>> >> You can run the smoke tester directly with this command:
>>>> >>
>>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>>> >>
>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>>> >>
>>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>>>> 17:00 UTC.
>>>> >>
>>>> >> [ ] +1 approve
>>>> >> [ ] +0 no opinion
>>>> >> [ ] -1 disapprove (and reason why)
>>>> >>
>>>> >> Here is my +1
>>>> >>
>>>> >> SUCCESS! [0:38:43.010208]
>>>> >>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Dawid Weiss <da...@gmail.com>.
If we're respinning, can I also add this to the release branch?
https://github.com/apache/lucene/pull/13825
This change affects the API of DataInput, which is an important core
interface, but it does have a strong rationale for people who use these
classes directly in downstream libraries.
I'll apply this change to branch_10x right now - without touching the
release branch.
Dawid
On Wed, Oct 9, 2024 at 3:47 AM Michael McCandless <lu...@mikemccandless.com>
wrote:
> Hello,
>
> Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
>
> https://github.com/apache/lucene/issues/13867
>
> I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written
> indices using HNSW scalar quantization at defaults. I have not tested but
> I strongly expect the current 10.0.0 RC to also have broken reading 9.11.x
> written indices (with HNSW scalar quantization) too. Thank you to Ionut
> Anghelcovici Lucene user for catching this and opening a well-written issue.
>
> I'm first (now) trying to understand why our BWC tests are not catching
> this...
>
> Separately, this at least (sigh) shows the benefits of releasing 9.last
> before 10.0! Sorry about all of this!!
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com> wrote:
>
>> +1
>> SUCCESS! [1:08:46.194765]
>>
>> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
>> wrote:
>>
>>> +1 SUCCESS! [0:48:25.853452]
>>>
>>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
>>> wrote:
>>> >
>>> > +1 SUCCESS! [0:40:01.995275]
>>> >
>>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
>>> >>
>>> >> Please vote for release candidate 3 for Lucene 10.0.0
>>> >>
>>> >> I published a draft of the release notes at
>>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>>> . Feedback is welcome. Feel free to edit directly.
>>> >>
>>> >> The artifacts can be downloaded from:
>>> >>
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>> >>
>>> >> You can run the smoke tester directly with this command:
>>> >>
>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>>> >>
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>> >>
>>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>>> 17:00 UTC.
>>> >>
>>> >> [ ] +1 approve
>>> >> [ ] +0 no opinion
>>> >> [ ] -1 disapprove (and reason why)
>>> >>
>>> >> Here is my +1
>>> >>
>>> >> SUCCESS! [0:38:43.010208]
>>> >>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Michael McCandless <lu...@mikemccandless.com>.
Hello,
Alas, I fear this issue is likely a (late breaking!) blocker for 10.0.0?
https://github.com/apache/lucene/issues/13867
I (sadly) broke back compat in 9.12.0 when trying to open 9.11.x written
indices using HNSW scalar quantization at defaults. I have not tested but
I strongly expect the current 10.0.0 RC to also have broken reading 9.11.x
written indices (with HNSW scalar quantization) too. Thank you to Ionut
Anghelcovici Lucene user for catching this and opening a well-written issue.
I'm first (now) trying to understand why our BWC tests are not catching
this...
Separately, this at least (sigh) shows the benefits of releasing 9.last
before 10.0! Sorry about all of this!!
Mike McCandless
http://blog.mikemccandless.com
On Tue, Oct 8, 2024 at 12:26 PM Patrick Zhai <zh...@gmail.com> wrote:
> +1
> SUCCESS! [1:08:46.194765]
>
> On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com>
> wrote:
>
>> +1 SUCCESS! [0:48:25.853452]
>>
>> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
>> wrote:
>> >
>> > +1 SUCCESS! [0:40:01.995275]
>> >
>> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
>> >>
>> >> Please vote for release candidate 3 for Lucene 10.0.0
>> >>
>> >> I published a draft of the release notes at
>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0
>> . Feedback is welcome. Feel free to edit directly.
>> >>
>> >> The artifacts can be downloaded from:
>> >>
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>> >>
>> >> You can run the smoke tester directly with this command:
>> >>
>> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>> >>
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>> >>
>> >> The vote will be open for at least 72 hours i.e. until 2024-10-09
>> 17:00 UTC.
>> >>
>> >> [ ] +1 approve
>> >> [ ] +0 no opinion
>> >> [ ] -1 disapprove (and reason why)
>> >>
>> >> Here is my +1
>> >>
>> >> SUCCESS! [0:38:43.010208]
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Patrick Zhai <zh...@gmail.com>.
+1
SUCCESS! [1:08:46.194765]
On Mon, Oct 7, 2024 at 7:31 AM Benjamin Trent <be...@gmail.com> wrote:
> +1 SUCCESS! [0:48:25.853452]
>
> On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com>
> wrote:
> >
> > +1 SUCCESS! [0:40:01.995275]
> >
> > On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
> >>
> >> Please vote for release candidate 3 for Lucene 10.0.0
> >>
> >> I published a draft of the release notes at
> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 .
> Feedback is welcome. Feel free to edit directly.
> >>
> >> The artifacts can be downloaded from:
> >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
> >>
> >> You can run the smoke tester directly with this command:
> >>
> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
> >>
> >> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00
> UTC.
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove (and reason why)
> >>
> >> Here is my +1
> >>
> >> SUCCESS! [0:38:43.010208]
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Benjamin Trent <be...@gmail.com>.
+1 SUCCESS! [0:48:25.853452]
On Mon, Oct 7, 2024 at 8:31 AM Stefan Vodita <st...@gmail.com> wrote:
>
> +1 SUCCESS! [0:40:01.995275]
>
> On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
>>
>> Please vote for release candidate 3 for Lucene 10.0.0
>>
>> I published a draft of the release notes at https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 . Feedback is welcome. Feel free to edit directly.
>>
>> The artifacts can be downloaded from:
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>
>> You can run the smoke tester directly with this command:
>>
>> python3 -u dev-tools/scripts/smokeTestRelease.py \
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>>
>> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00 UTC.
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Here is my +1
>>
>> SUCCESS! [0:38:43.010208]
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [VOTE] Release Lucene 10.0.0 RC3
Posted by Stefan Vodita <st...@gmail.com>.
+1 SUCCESS! [0:40:01.995275]
On Sat, 5 Oct 2024 at 11:36, Luca Cavanna <ja...@apache.org> wrote:
> Please vote for release candidate 3 for Lucene 10.0.0
>
> I published a draft of the release notes at
> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 .
> Feedback is welcome. Feel free to edit directly.
>
> The artifacts can be downloaded from:
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC3-rev-a4c0f741ccc5e5b86fc82fae150561c0b05a1dca
>
> The vote will be open for at least 72 hours i.e. until 2024-10-09 17:00
> UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1
>
> SUCCESS! [0:38:43.010208]
>
>