You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 21:00:17 UTC
[GitHub] [airflow] ashb opened a new pull request #13048: Fix error with S3 remote logs not being written
ashb opened a new pull request #13048:
URL: https://github.com/apache/airflow/pull/13048
The problem was we delayed the hook creation until s3_write as called, at which point the ORM has already been disconnected, meaning we can't get credential information.
This ensures that the connection is created and cached in set_context -- called when the logging is being "set up" for a task.
Closes #13046
@potiuk I haven't (yet) tested this change, but I think it might solve the issue, and thankfully is a change in the provider so doesn't need an apache-airflow 2.0.0rc3. If you are able to test this tonight great, otherwise I will do it first thing tomorrow morning.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #13048: Fix error with S3/GCS remote logs not being written
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #13048:
URL: https://github.com/apache/airflow/pull/13048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13048: Fix error with S3/GCS remote logs not being written
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13048:
URL: https://github.com/apache/airflow/pull/13048#issuecomment-744349046
Not really a fix -- closing for #13057 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org