[GitHub] [yunikorn-core] pbacsko commented on pull request #505: [YUNIKORN-1567] Do not attempt to schedule tasks if partition update is in progress

["pbacsko (via GitHub)" <gi...@apache.org>]

pbacsko commented on PR #505:
URL: https://github.com/apache/yunikorn-core/pull/505#issuecomment-1433196163

   > This looks overly complex. What is the problem with using a partition lock? At the very least, the lock should live in the partition itself and not in a separate map...
   
   Sorry, I forgot to answer this. Partition Lock is not hold, but there are various calls when it's hold then released for a change. I think scheduling it's designed to be "no-lock".
   
   This solution might also raise some eyebrows, but as I went through various codepaths, it looks safe as long as we maintain certain invariants.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org