You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/05/22 15:06:51 UTC
[GitHub] flink pull request #3962: [FLINK-6659] fix (some) unit tests leaving tempora...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3962
[FLINK-6659] fix (some) unit tests leaving temporary data behind
Both, `RocksDBMergeIteratorTest` as well as `SavepointITCase` were using `CommonTestUtils.createTempDirectory()` to create a temporary directory and never deleted it after the test finishes. This PR replaces this usage by a JUnit `@Rule` instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6659
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3962.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3962
----
commit 79cf9958a2325359c04fa2050264a8c1a3525d13
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-05-22T14:47:35Z
[FLINK-6659] fix RocksDBMergeIteratorTest leaving temporary data behind
-> use a JUnit '@Rule' that does the cleanup
commit 77fec6c6a8c771622c89590661bb005ffa3f5488
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-05-22T14:55:39Z
[FLINK-6659] fix SavepointITCase leaving temporary data behind
-> use a JUnit '@Rule' that does the cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3962: [FLINK-6659] fix (some) unit tests leaving temporary data...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3962
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3962: [FLINK-6659] fix (some) unit tests leaving temporary data...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3962
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3962: [FLINK-6659] fix (some) unit tests leaving tempora...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3962
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---