You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Quinn Leng <qu...@gmail.com> on 2017/08/10 21:09:41 UTC
Re: Review Request 61262: Added 'heartbeat' event for the operator
API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61262/#review182627
-----------------------------------------------------------
src/master/master.hpp
Lines 1826 (patched)
<https://reviews.apache.org/r/61262/#comment258602>
Move the templated Heartbeater before these usages in subscriber and framework.
src/master/master.hpp
Line 1830 (original), 1874 (patched)
<https://reviews.apache.org/r/61262/#comment258603>
don't have to pass in the uuid, also not necessary to keep it as a class memeber.
src/tests/api_tests.cpp
Lines 2189 (patched)
<https://reviews.apache.org/r/61262/#comment258604>
put int into the for bracket.
- Quinn Leng
On July 31, 2017, 5:30 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61262/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 5:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-7695
> https://issues.apache.org/jira/browse/MESOS-7695
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the 'HEARTBEAT' event for the operator API, modified other
> related test cases to accept heartbeats.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983
> include/mesos/v1/master/master.proto c04fd1602396a58086331f5fa56518c5dee9af89
> src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70
> src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043
> src/master/master.cpp 7bb3adf48431cd97b3c404b8a1eba4ac6a01efcc
> src/tests/api_tests.cpp 1d5b080c809248bdf4c76ddad382d714692c804b
>
>
> Diff: https://reviews.apache.org/r/61262/diff/3/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>