You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Igor Guzenko (JIRA)" <ji...@apache.org> on 2018/12/17 17:52:00 UTC

[jira] [Closed] (DRILL-6908) Hive Testing: Replace cumbersome assertions with TestBuilder.csvBaselineFile()

     [ https://issues.apache.org/jira/browse/DRILL-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Guzenko closed DRILL-6908.
-------------------------------
    Resolution: Won't Fix

 CSVTestBuilder is not suitable for tests with big variety of columns datatypes and it would be worthless to spend a lot of time for fixing the cast issues related to the test builder's validation query.

> Hive Testing: Replace cumbersome assertions with TestBuilder.csvBaselineFile()
> ------------------------------------------------------------------------------
>
>                 Key: DRILL-6908
>                 URL: https://issues.apache.org/jira/browse/DRILL-6908
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.16.0
>            Reporter: Igor Guzenko
>            Priority: Minor
>
> For improving Hive tests readability it would be nice to rewrite some cumbersome tests to use CSVTestBuilder for assertions. This issue was created because it requires a lot of changes for different Hive tests and also some additional time may be necessary to ensure that CSVTestBuilder can read all datatypes (dates with different formats, floating point numbers, big decimals etc.) into correct values for assertions. 
> Below is list of test methods to be rewritten: 
>  * TestHiveStorage.readAllSupportedHiveDataTypes()
>  * TestHiveStorage.orderByOnHiveTable()
>  * TestHiveStorage.readingFromSmallTableWithSkipHeaderAndFooter()
>  
>  * TestHiveViewsSupport.selectStarFromView()
>  * TestHiveViewsSupport.useHiveAndSelectStarFromView()
>  * TestHiveViewsSupport.viewWithAllSupportedDataTypes()
>  * TestHiveDrillNativeParquetReader.testReadAllSupportedHiveDataTypesNativeParquet()
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)