You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "cstruct (via GitHub)" <gi...@apache.org> on 2025/08/02 23:49:05 UTC

[PR] fix(python): add proper typings for async method args and return types [iggy]

cstruct opened a new pull request, #2071:
URL: https://github.com/apache/iggy/pull/2071

   This draft PR is in preparation for release `0.12.0` of [`pyo3-stub-gen`](https://github.com/Jij-Inc/pyo3-stub-gen) allowing us to override Python types in generated stub file. Once the new version is released on crates.io we can remove the `[patch.crates-io]` and this should be ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(python): add proper typings for async method args and return types [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on code in PR #2071:
URL: https://github.com/apache/iggy/pull/2071#discussion_r2249930152


##########
foreign/python/Cargo.toml:
##########
@@ -32,9 +32,12 @@ pyo3-async-runtimes = { version = "0.25.0", features = [
     "attributes",
     "tokio-runtime",
 ] }
-pyo3-stub-gen = "0.11.1"
+pyo3-stub-gen = "0.12.0"
 tokio = "1.40.0"
 
+[patch.crates-io]
+pyo3-stub-gen = { git = "https://github.com/Jij-Inc/pyo3-stub-gen.git" }

Review Comment:
   Yes, it should be a reproducible build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(python): add proper typings for async method args and return types [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #2071:
URL: https://github.com/apache/iggy/pull/2071


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(python): add proper typings for async method args and return types [iggy]

Posted by "cstruct (via GitHub)" <gi...@apache.org>.
cstruct commented on code in PR #2071:
URL: https://github.com/apache/iggy/pull/2071#discussion_r2249929385


##########
foreign/python/Cargo.toml:
##########
@@ -32,9 +32,12 @@ pyo3-async-runtimes = { version = "0.25.0", features = [
     "attributes",
     "tokio-runtime",
 ] }
-pyo3-stub-gen = "0.11.1"
+pyo3-stub-gen = "0.12.0"
 tokio = "1.40.0"
 
+[patch.crates-io]
+pyo3-stub-gen = { git = "https://github.com/Jij-Inc/pyo3-stub-gen.git" }

Review Comment:
   Hm, I should lock down the git ref to a specific commit, reproducible builds and all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org