You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/15 19:38:12 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10891: fix: superset alerting misc fixes [WIP]
codecov-commenter edited a comment on pull request #10891:
URL: https://github.com/apache/incubator-superset/pull/10891#issuecomment-692933993
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=h1) Report
> Merging [#10891](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c420d6efe6485fa90420c76b4a0a898215e9b54?el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10891 +/- ##
==========================================
+ Coverage 59.15% 59.32% +0.17%
==========================================
Files 778 778
Lines 37123 37103 -20
Branches 3310 3310
==========================================
+ Hits 21959 22013 +54
+ Misses 14973 14904 -69
+ Partials 191 186 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.34% <ø> (+0.44%)` | :arrow_up: |
| #python | `61.47% <100.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.84% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <100.00%> (-0.12%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.80% <100.00%> (-0.07%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `84.41% <100.00%> (+10.45%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.28% <0.00%> (+0.67%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `52.43% <0.00%> (+1.21%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `12.86% <0.00%> (+1.65%)` | :arrow_up: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `91.42% <0.00%> (+2.85%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `49.09% <0.00%> (+3.03%)` | :arrow_up: |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `52.94% <0.00%> (+3.26%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/10891/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=footer). Last update [9c420d6...8931466](https://codecov.io/gh/apache/incubator-superset/pull/10891?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org