[GitHub] [flink-kubernetes-operator] usamj commented on a diff in pull request #468: [FLINK-30287] Delete job manager deployment first when cleaning up standalone cluster

[GitBox <gi...@apache.org>]

usamj commented on code in PR #468:
URL: https://github.com/apache/flink-kubernetes-operator/pull/468#discussion_r1040209873


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -134,20 +134,20 @@ protected void deleteClusterInternal(ObjectMeta meta, boolean deleteHaConfigmaps
         final String clusterId = meta.getName();
         final String namespace = meta.getNamespace();
 
-        LOG.info("Deleting Flink Standalone cluster TM resources");
+        LOG.info("Deleting Flink Standalone cluster JM resources");
         kubernetesClient
                 .apps()
                 .deployments()
                 .inNamespace(namespace)
-                .withName(StandaloneKubernetesUtils.getTaskManagerDeploymentName(clusterId))
+                .withName(StandaloneKubernetesUtils.getJobManagerDeploymentName(clusterId))
                 .delete();
 
-        LOG.info("Deleting Flink Standalone cluster JM resources");
+        LOG.info("Deleting Flink Standalone cluster TM resources");

Review Comment:
   I don't think that is needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org