You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/03/30 15:44:00 UTC

[jira] [Commented] (GEODE-10151) Make geode-for-redis an optional dependency of a geode server

    [ https://issues.apache.org/jira/browse/GEODE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514778#comment-17514778 ] 

ASF subversion and git services commented on GEODE-10151:
---------------------------------------------------------

Commit 3fd631a22f1a7f319cb38f1039827e7cbdd6e528 in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3fd631a ]

GEODE-10151: Make geode-for-redis optional for a geode server

Removing the geode-for-redis project and it's dependencies from the default
classpath of a geode server. Before this change, geode-for-redis was installed
in the lib directory of the server along with it's dependencies, and it was not
easy to run without it.

Creating a distribution for geode-for-redis that can be added to the classpath
of a server if the user chooses. This distribution is currently being built
in the geode-for-redis/build/distributions directory, as well as placed
as a zip file in the tools/Modules/ directory of the overall geode
distribution. This distribution only contains dependencies that are not
already on the classpath of a geode server.

To generate the redis distribution run
./gradlew geode-for-redis:installDist

or for the whole geode distribution, including the redis zip file run
./gradlew geode-assembly:installDist

See the gradle documentation on the distribution plugin for more details.

The redis tests that previously required a GEODE_HOME to run now also require
a GEODE_FOR_REDIS_HOME directory that points into an installed distribution of
geode-for-redis. The tests add the geode-for-redis jars into the classpath using this
environment variable. When running tests through gradle we set the
GEODE_FOR_REDIS_HOME environment variable automatically.

> Make geode-for-redis an optional dependency of a geode server
> -------------------------------------------------------------
>
>                 Key: GEODE-10151
>                 URL: https://issues.apache.org/jira/browse/GEODE-10151
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> The geode-for-redis module and its related dependencies are on the classpath of the server by default when starting a server with gfsh start server or using the geode dependencies jar.
> We should make the module an optional dependencies, like some of our other extensions (for example, the tomcat http session modules). This would allow a user to choose if they want redis on the classpath or not.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)