You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 09:56:45 UTC

[GitHub] [flink] rkhachatryan commented on pull request #13709: [FLINK-19401][checkpointing] Download checkpoints only if needed

rkhachatryan commented on pull request #13709:
URL: https://github.com/apache/flink/pull/13709#issuecomment-713453964


   There was a failure of `ZooKeeperHighAvailabilityITCase` after my changes.
   If I understood correctly, it tests whether failure to retrieve a checkpoint fails recovery. This assumption doesn't hold now (if the checkpoints are already in memory in ids match ones in ZK). The test was added in FLINK-8487.
   
   I couldn't find a way to re-create ZKStore to force retrieval -> to raise error -> to pass the test.
   So I just replaced ITCase with a unit test to check whether failure of `handle.retrieve` causes failure of `ZKStore.recover()` .
   @aljoscha, can you take a look?
   
   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org