You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2024/02/21 20:12:25 UTC

Re: [PR] Bugfix to load dictionary onHeap when defined in fieldConfigList [pinot]

Jackie-Jiang commented on PR #12265:
URL: https://github.com/apache/pinot/pull/12265#issuecomment-1957824938

   With this change, we will always prioritize the config from field config over indexing config (not only apply to dictionary). I think this is the correct behavior because field config always gives finer control, but this is also behavior change. @vvivekiyer Can you please modify the PR title and description to include these info?
   @gortiz Do you think this is the desired behavior?
   
   Also, I don't see the CI running for this PR. Can you re-push the commit to trigger it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org