You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by vim-wj <gi...@git.apache.org> on 2017/10/20 17:29:22 UTC

[GitHub] flink pull request #4877: [Flink] About SourceFunction extends Serializable

GitHub user vim-wj opened a pull request:

    https://github.com/apache/flink/pull/4877

    [Flink] About SourceFunction extends Serializable

    SourceFunction extends Function and Serializable, but Function has been extends Serializable, so SourceFunction needn't extends Serializable again.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vim-wj/flink flink-sf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4877.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4877
    
----
commit 939eb45f2a27c154284896aab206d571ee2176cb
Author: vim-wj <38...@qq.com>
Date:   2017-10-20T15:08:18Z

    modify SourceFunction

----


---

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4877
  
    @vim-wj if you are okay with Stephan's suggestion could you close this pull request?
    
    Also, a small note: `FLINK-4877` references a [Jira ticket](https://issues.apache.org/jira/browse/FLINK-4877) rather than a pull request (use `[hotfix]` for simple issues not requiring a ticket).


---

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4877
  
    Thanks for opening this pull request.
    
    I think it is correct that `SourceFunction` is not required to implement `Serializable`. But I think it does not cause any problems, as far as I know, it has no implication at all on the runtime or behavior.
    
    It does serve as a "reminder" that sources need to be serializable, so it could actually be helpful to keep it.
    
    Given that it makes no difference, should we keep it?


---

[GitHub] flink pull request #4877: [FLINK-4877] About SourceFunction extends Serializ...

Posted by vim-wj <gi...@git.apache.org>.

Github user vim-wj closed the pull request at:

    https://github.com/apache/flink/pull/4877


---

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

Posted by vim-wj <gi...@git.apache.org>.

Github user vim-wj commented on the issue:

    https://github.com/apache/flink/pull/4877
  
    @greghogan , @StephanEwen ,sorry fo my late reply.I will close this pull request.


---