You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/11 08:06:11 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14236: PulsarStandaloneStarter's incorrect split metadataStoreUrl
gaozhangmin opened a new pull request #14236:
URL: https://github.com/apache/pulsar/pull/14236
### Motivation
In PulsarStandaloneStarter, it would split metadataStoreUrl to get ZK Port. But metadataStoreUrl is with zk prefix.
old split way would cause number format exception.
### Modifications
Make it compatible with multiple kinds of metadataStore url
### Verifying this change
Can be verify by `org.apache.pulsar.broker.service.StandaloneTest#testAdvertised`
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #14236: PulsarStandaloneStarter's incorrect split metadataStoreUrl
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #14236:
URL: https://github.com/apache/pulsar/pull/14236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14236: PulsarStandaloneStarter's incorrect split metadataStoreUrl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14236:
URL: https://github.com/apache/pulsar/pull/14236#issuecomment-1035976640
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14236: PulsarStandaloneStarter's incorrect split metadataStoreUrl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14236:
URL: https://github.com/apache/pulsar/pull/14236#issuecomment-1035970607
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org