[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3524: [ISSUE #3523] fix json serialization issue when using redis

["mxsm (via GitHub)" <gi...@apache.org>]

mxsm commented on code in PR #3524:
URL: https://github.com/apache/incubator-eventmesh/pull/3524#discussion_r1147101118


##########
eventmesh-protocol-plugin/eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/resolver/tcp/TcpMessageProtocolResolver.java:
##########
@@ -76,6 +76,7 @@ public static CloudEvent buildEvent(Header header, EventMeshMessage message) thr
             .withId(header.getSeq())
             .withSource(URI.create("/"))
             .withType("eventmeshmessage")
+            .withDataContentType("text/plain")
             .withSubject(topic)
             .withData(content.getBytes(StandardCharsets.UTF_8));

Review Comment:
   How about replace StandardCharsets.UTF_8 with Constants.DEFAULT_CHARSET, Consistent code style.
   .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org