You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 06:08:21 UTC
[GitHub] [airflow] potiuk opened a new pull request #7149: Add commit
message validation
potiuk opened a new pull request #7149: Add commit message validation
URL: https://github.com/apache/airflow/pull/7149
Adds validation of AIRFLOW* jira issue id to all commits.
Note that it requires https://github.com/kaxil/boring-cyborg/pull/2 to be merged in @kaxil 's boring-cyborg and it requires to grant new permissions to the boring-cyborg: `Commit status: read&write.`
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7149: [AIRFLOW-6545] Add commit message validation
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7149: [AIRFLOW-6545] Add commit message validation
URL: https://github.com/apache/airflow/pull/7149#discussion_r365747515
##########
File path: .github/boring-cyborg.yml
##########
@@ -182,3 +182,7 @@ insertIssueLinkInPrDescription:
docOnlyIssueMatch:
titleIssueIdRegexp: \[(AIRFLOW-X{4})\]
descriptionIssueLink: "`Document only change, no JIRA issue`"
+
+
+verifyCommitMessages:
+ commitMessageRegexp: ^.*\[AIRFLOW-[0-9]{4}\].*$|^.*\[AIRFLOW-[X]{4}\].*$
Review comment:
```suggestion
commitMessageRegexp: ^.*\[AIRFLOW-[0-9]{4}\].*$|^.*\[AIRFLOW-XXXX\].*$
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7149: [AIRFLOW-6545] Add commit
message validation
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7149: [AIRFLOW-6545] Add commit message validation
URL: https://github.com/apache/airflow/pull/7149#issuecomment-573664904
Awesome, @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7149: [AIRFLOW-6545] Add
commit message validation
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7149: [AIRFLOW-6545] Add commit message validation
URL: https://github.com/apache/airflow/pull/7149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7149: [AIRFLOW-6545] Add
commit message validation
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7149: [AIRFLOW-6545] Add commit message validation
URL: https://github.com/apache/airflow/pull/7149#issuecomment-573615680
Hey @kaxil - do not merge it yet as I want to make some small update after talking to @nuclearpinguin and @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7149: [AIRFLOW-6545] Add
commit message validation
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7149: [AIRFLOW-6545] Add commit message validation
URL: https://github.com/apache/airflow/pull/7149#issuecomment-573637728
OK. Ready to merge. I improved the https://github.com/kaxil/boring-cyborg/pull/2 to better handle multiple/single commit cases and updated regexps :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services