You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/09 02:43:55 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9699: MINOR: remove duplicate code from resetByDuration

chia7712 commented on a change in pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#discussion_r538962333



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -491,17 +491,8 @@ private void resetByDuration(final Consumer<byte[], byte[]> client,
                                  final Duration duration) {
         final Instant now = Instant.now();

Review comment:
       Could we remove those local variables? For example:
   ```java
   
           resetToDatetime(client, inputTopicPartitions, Instant.now().minus(duration).toEpochMilli());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org