You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/05/30 14:04:15 UTC

[GitHub] zhaijack commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config

zhaijack commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config
URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r191779938
 
 

 ##########
 File path: pulsar-client-cpp/lib/ClientImpl.cc
 ##########
 @@ -222,6 +222,12 @@ void ClientImpl::subscribeAsync(const std::string& topic, const std::string& con
             lock.unlock();
             callback(ResultInvalidTopicName, Consumer());
             return;
+        } else if (conf.isReadCompacted() && (topicName->getDomain().compare("persistent") != 0 ||
 
 Review comment:
   seems no.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services