You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 19:42:23 UTC
[GitHub] [arrow] rok opened a new pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
rok opened a new pull request #11889:
URL: https://github.com/apache/arrow/pull/11889
[ARROW-14708](https://issues.apache.org/jira/browse/ARROW-14708)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1030006354
Looking at CI, it seems the set of Abseil libraries we need might be different per-platform even.
Also, I get failures with the repro. The link command is missing the bundled dependencies, and the order of libraries still seems off. (Can't paste the log, it's too long.)
```
[1/1] Linking CXX executable arrow_example
FAILED: arrow_example
: && /usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a -pthread && :
```
Even if I change the order of linking and add the bundled dependencies, I still have gRPC symbols missing. And indeed, the dependencies archive seems to be missing gRPC.
```
CREATE /home/lidavidm/Code/upstream/rok-arrow-14708/build/debug/libarrow_bundled_dependencies.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/snappy_ep/src/snappy_ep-install/lib/libsnappy.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/glog_ep-prefix/src/glog_ep/lib/libglogd.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/gflags_ep-prefix/src/gflags_ep/lib/libgflags_debug.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/thrift_ep-install/lib/libthriftd.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/protobuf_ep-install/lib/libprotobuf.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/zlib_ep/src/zlib_ep-install/lib/libz.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/lz4_ep-prefix/src/lz4_ep/lib/liblz4.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/utf8proc_ep-install/lib/libutf8proc.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/cares_ep-install/lib/libcares.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_base.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_cord.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_synchronization.a
SAVE
END
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1023819898
Revision: 7f7ef5eb2e63f36633eec2157a4c917c353a0f2f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1510](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1510)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1510-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1510-github-example-cpp-minimal-build-static-system-dependency)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1023819677
@github-actions crossbow submit ubuntu-bionic-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r819044538
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,8 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+else()
Review comment:
`if (NOT ...)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r819068231
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,8 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+else()
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056219802
The CI seems unrelated. Do you mean `example-cpp-minimal-build-static-system-dependency`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1062382140
Benchmark runs are scheduled for baseline = 5772d658dced5cca7b95be5fc4266ce189917317 and contender = 2fea81850b7a081dd06ce0c9cc2d442169e6419f. 2fea81850b7a081dd06ce0c9cc2d442169e6419f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee84741f74b5452d8d85822589e6e8b2...6a51877597b24c988860ba22d881ff62/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b562f6676ca746798348f6db2a5c8595...708d80f842bd4d37b7a8c88395baafec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ecf7ca9a4094ae3b004f92fb8a36754...cc6a9858d10c4da58fdda45eacd63940/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6506b715a8a4e9080e4a951670428bf...94b5556a49ae4558bf5b7aa151e27590/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r765264031
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
set_target_properties(
arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
"${arrow_static_interface_link_libraries};arrow_bundled_dependencies")
+ # Propagate dependencies like OpenSSL
+ set_target_properties(
+ arrow_bundled_dependencies PROPERTIES INTERFACE_LINK_LIBRARIES
+ "${arrow_static_interface_link_libraries}")
Review comment:
I see. Then we should list OpenSSL in `INTERFACE_LINK_LIBRARIES` of `arrow_bundled_dependencies` not `arrow_static` and `INTERFACE_LINK_LIBRARIES` of `arrow_static` should list only `arrow_bundled_dependencies` something like this:
```diff
diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in
index 6209baeec..ac2b9a027 100644
--- a/cpp/src/arrow/ArrowConfig.cmake.in
+++ b/cpp/src/arrow/ArrowConfig.cmake.in
@@ -38,6 +38,7 @@ set(ARROW_LIBRARY_PATH_SUFFIXES "@ARROW_LIBRARY_PATH_SUFFIXES@")
set(ARROW_INCLUDE_PATH_SUFFIXES "@ARROW_INCLUDE_PATH_SUFFIXES@")
set(ARROW_SYSTEM_DEPENDENCIES "@ARROW_SYSTEM_DEPENDENCIES@")
set(ARROW_BUNDLED_STATIC_LIBS "@ARROW_BUNDLED_STATIC_LIBS@")
+set(ARROW_STATIC_INSTALL_INTERFACE_LIBS "@ARROW_STATIC_INSTALL_INTERFACE_LIBS@")
include("${CMAKE_CURRENT_LIST_DIR}/ArrowOptions.cmake")
@@ -79,14 +80,9 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
PROPERTIES
IMPORTED_LOCATION
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ INTERFACE_LINK_LIBRARIES
+ "${ARROW_STATIC_INSTALL_INTERFACE_LIBS}"
)
-
- get_property(arrow_static_interface_link_libraries
- TARGET arrow_static
- PROPERTY INTERFACE_LINK_LIBRARIES)
- set_target_properties(
- arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
- "${arrow_static_interface_link_libraries};arrow_bundled_dependencies")
endif()
endif()
endif()
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 5736c557b..66a24fbfc 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -526,6 +526,9 @@ endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+ set(ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL "arrow_bundled_dependencies")
+else()
+ set(ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
endif()
# Need -latomic on Raspbian.
# See also: https://issues.apache.org/jira/browse/ARROW-12860
@@ -557,7 +560,7 @@ add_arrow_lib(arrow
SHARED_INSTALL_INTERFACE_LIBS
${ARROW_SHARED_INSTALL_INTERFACE_LIBS}
STATIC_INSTALL_INTERFACE_LIBS
- ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL})
add_dependencies(arrow ${ARROW_LIBRARIES})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820701040
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,9 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL}
+ arrow_static)
Review comment:
Hmm, do we need to list arrow_static twice? And it seems odd that we have to re-list all the libraries here…why doesn't listing arrow_static as a dependency give us these dependencies transitively?
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -240,7 +240,9 @@ function(ADD_ARROW_LIB LIB_NAME)
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
+ OUTPUT_PATH
+ SHARED_INSTALL_EXTRA_TARGETS
+ STATIC_INSTALL_EXTRA_TARGETS)
Review comment:
Do we actually use any of the changes here anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058364441
@lidavidm this now runs for me on linux (conda env on ubuntu) if I replace `cpp/examples/minimal_build/example.cc` and `cpp/examples/minimal_build/CMakeLists.txt` with [repro code](https://issues.apache.org/jira/browse/ARROW-14708):
```
cmake .. \
-DCMAKE_BUILD_TYPE=Debug \
-GNinja \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
-DARROW_USE_GLOG=ON \
-DARROW_PARQUET=ON \
-DARROW_WITH_SNAPPY=ON \
-DARROW_DATASET=ON \
-DARROW_CSV=ON \
-DARROW_JSON=ON \
-DARROW_PYTHON=ON \
-DARROW_WITH_LZ4=ON \
-DARROW_FLIGHT=ON \
-DARROW_DEPENDENCY_SOURCE=BUNDLED
ninja -j8
```
I'll check on mac shortly but I suspect it won't work there. Could you please check what happens on your end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1059146186
Wait, what changes exactly are you making to the minimal build? (Can you give a diff?) The example there doesn't actually link to or use Flight by default, so it might not complain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820815077
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -240,7 +240,9 @@ function(ADD_ARROW_LIB LIB_NAME)
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
+ OUTPUT_PATH
+ SHARED_INSTALL_EXTRA_TARGETS
+ STATIC_INSTALL_EXTRA_TARGETS)
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060996353
@lidavidm Implemented your suggestions and added a workaround for the [abseil issue](https://github.com/abseil/abseil-cpp/issues/283) on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820995056
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
Sorry, that shouldn't be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821696331
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,7 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
Review comment:
Returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1062382140
Benchmark runs are scheduled for baseline = 5772d658dced5cca7b95be5fc4266ce189917317 and contender = 2fea81850b7a081dd06ce0c9cc2d442169e6419f. 2fea81850b7a081dd06ce0c9cc2d442169e6419f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee84741f74b5452d8d85822589e6e8b2...6a51877597b24c988860ba22d881ff62/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b562f6676ca746798348f6db2a5c8595...708d80f842bd4d37b7a8c88395baafec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ecf7ca9a4094ae3b004f92fb8a36754...cc6a9858d10c4da58fdda45eacd63940/)
[Finished :arrow_down:0.13% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6506b715a8a4e9080e4a951670428bf...94b5556a49ae4558bf5b7aa151e27590/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988815102
Revision: f3745060a1982f3ee46705bec28df3830312a8b9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1268](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1268)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-centos-7-amd64)|
|centos-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-centos-8-amd64)|
|centos-8-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-clean)|
|conda-linux-gcc-py36-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-linux-gcc-py36-cpu-r40)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-linux-gcc-py36-cuda)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-clang-py36-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-conda-win-vs2017-py36-r40)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.10)|
|test-conda-python-3.6|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-debian-11-go-1.15)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-auto|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-depsource-auto)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1268-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1268-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019605342
@rok could you please trigger more selective builds with this frequency and trigger the big nightly group once those builds are passing? Additionally I'm working on the release which requires more crossbow bandwidth but the queue is filled now for hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019998064
I checked the failing builds that did not fail in the nightly:
Seems unrelated:
* test-conda-python-3.9-spark-master
* test-ubuntu-20.04-cpp-thread-sanitizer
* ubuntu-hirsute-amd64
Seems flaky:
* debian-bookworm-arm64 - GitHub 502 on `archery crossbow`
* homebrew-r-autobrew - Minio issue with R
* python-sdist - GDB issue
* test-build-cpp-fuzz - GitHub permissions issue
* test-fedora-33-python-3 - dependency download issue
* test-r-rstudio-r-base-4.1-opensuse15 - dependency download issue
* wheel-manylinux2014-cp39-arm64 - dependency download issue
* wheel-manylinux2014-cp39-amd64 - vcpkg download issue
* wheel-manylinux2014-cp310-arm64 - vcpkg download issue
* wheel-manylinux2014-cp38-arm64 - vcpkg download issue
ZSTD (undefined reference to `ZSTD_<Something>}’ …):
* example-cpp-minimal-build-static
* example-cpp-minimal-build-static-system-dependency
Unclear:
* ubuntu-bionic-arm64 - errored and did not run
I'll check if ZSTD is related to the change and report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1029582807
@lidavidm using [your repro](https://issues.apache.org/jira/browse/ARROW-14708) this change now only complains of flight not having grpc symbols. Any idea how to approach this?
```
/Library/Developer/CommandLineTools/usr/bin/c++ -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example \
/Users/rok/builds/arrow-arm64/lib/libarrow.a \
/Users/rok/builds/arrow-arm64/lib/libarrow_flight.a \
/opt/homebrew/opt/openssl@3/lib/libssl.a \
/opt/homebrew/opt/openssl@3/lib/libcrypto.a \
/Users/rok/builds/arrow-arm64/lib/libarrow_bundled_dependencies.a
```
```
Undefined symbols for architecture arm64:
"grpc::ServerBuilder::BuildAndStart()", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerBuilder::RegisterService(grpc::Service*)", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerBuilder::AddListeningPort(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<grpc::ServerCredentials>, int*)", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerBuilder::SetOption(std::__1::unique_ptr<grpc::ServerBuilderOption, std::__1::default_delete<grpc::ServerBuilderOption> >)", referenced from:
grpc::ServerBuilder& grpc::ServerBuilder::AddChannelArgument<int>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerBuilder::ServerBuilder()", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerBuilder::~ServerBuilder()", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::CreateAuthContext(grpc_call*)", referenced from:
grpc::ServerContextBase::auth_context() const in libarrow_flight.a(server.cc.o)
"grpc::ServerContextBase::AddInitialMetadata(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
arrow::flight::(anonymous namespace)::GrpcAddCallHeaders::AddHeader(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in libarrow_flight.a(server.cc.o)
"grpc::ServerContextBase::AddTrailingMetadata(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
arrow::flight::internal::ToGrpcStatus(arrow::Status const&, grpc::ServerContext*) in libarrow_flight.a(internal.cc.o)
"grpc::SslServerCredentials(grpc::SslServerCredentialsOptions const&)", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::g_core_codegen_interface", referenced from:
grpc::ServerInterface::Shutdown() in libarrow_flight.a(server.cc.o)
grpc::CompletionQueue::Pluck(grpc::internal::CompletionQueueTag*) in libarrow_flight.a(server.cc.o)
grpc::internal::CallOpSet<grpc::internal::CallOpRecvMessage<arrow::flight::protocol::HandshakeRequest>, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::FinalizeResult(void**, bool*) in libarrow_flight.a(server.cc.o)
grpc::internal::CallOpSet<grpc::internal::CallOpRecvMessage<arrow::flight::protocol::HandshakeRequest>, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::FillOps(grpc::internal::Call*) in libarrow_flight.a(server.cc.o)
grpc::internal::CallOpSet<grpc::internal::CallOpRecvMessage<arrow::flight::protocol::HandshakeRequest>, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::ContinueFillOpsAfterInterception() in libarrow_flight.a(server.cc.o)
grpc::internal::CallOpSet<grpc::internal::CallOpRecvMessage<arrow::flight::protocol::HandshakeRequest>, grpc::internal::CallNoOp<2>, grpc::internal::CallNoOp<3>, grpc::internal::CallNoOp<4>, grpc::internal::CallNoOp<5>, grpc::internal::CallNoOp<6> >::ContinueFinalizeResultAfterInterception() in libarrow_flight.a(server.cc.o)
grpc::internal::InterceptorBatchMethodsImpl::Proceed() in libarrow_flight.a(server.cc.o)
...
"grpc::InsecureServerCredentials()", referenced from:
arrow::flight::FlightServerBase::Init(arrow::flight::FlightServerOptions const&) in libarrow_flight.a(server.cc.o)
"grpc::MakeChannelArgumentOption(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int)", referenced from:
grpc::ServerBuilder& grpc::ServerBuilder::AddChannelArgument<int>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int const&) in libarrow_flight.a(server.cc.o)
"grpc::Status::OK", referenced from:
arrow::flight::(anonymous namespace)::FlightServiceImpl::ListFlights(grpc::ServerContext*, arrow::flight::protocol::Criteria const*, grpc::ServerWriter<arrow::flight::protocol::FlightInfo>*) in libarrow_flight.a(server.cc.o)
arrow::flight::(anonymous namespace)::FlightServiceImpl::GetFlightInfo(grpc::ServerContext*, arrow::flight::protocol::FlightDescriptor const*, arrow::flight::protocol::FlightInfo*) in libarrow_flight.a(server.cc.o)
arrow::flight::(anonymous namespace)::FlightServiceImpl::GetSchema(grpc::ServerContext*, arrow::flight::protocol::FlightDescriptor const*, arrow::flight::protocol::SchemaResult*) in libarrow_flight.a(server.cc.o)
arrow::flight::(anonymous namespace)::FlightServiceImpl::DoGet(grpc::ServerContext*, arrow::flight::protocol::Ticket const*, grpc::ServerWriter<arrow::flight::protocol::FlightData>*) in libarrow_flight.a(server.cc.o)
arrow::flight::(anonymous namespace)::FlightServiceImpl::DoAction(grpc::ServerContext*, arrow::flight::protocol::Action const*, grpc::ServerWriter<arrow::flight::protocol::Result>*) in libarrow_flight.a(server.cc.o)
arrow::flight::(anonymous namespace)::FlightServiceImpl::MakeCallContext(arrow::flight::FlightMethod const&, grpc::ServerContext*, arrow::flight::(anonymous namespace)::GrpcServerCallContext&) in libarrow_flight.a(server.cc.o)
grpc::Status arrow::flight::(anonymous namespace)::FlightServiceImpl::WriteStream<arrow::flight::FlightInfo, arrow::flight::FlightListing, arrow::flight::protocol::FlightInfo>(arrow::flight::FlightListing*, grpc::ServerWriter<arrow::flight::protocol::FlightInfo>*) in libarrow_flight.a(server.cc.o)
...
"grpc::Status::CANCELLED", referenced from:
arrow::flight::(anonymous namespace)::FlightServiceImpl::DoAction(grpc::ServerContext*, arrow::flight::protocol::Action const*, grpc::ServerWriter<arrow::flight::protocol::Result>*) in libarrow_flight.a(server.cc.o)
"grpc::g_glip", referenced from:
grpc::GrpcLibraryCodegen::GrpcLibraryCodegen(bool) in libarrow_flight.a(protocol_internal.cc.o)
grpc::GrpcLibraryCodegen::~GrpcLibraryCodegen() in libarrow_flight.a(protocol_internal.cc.o)
"grpc::ServerContextBase::IsCancelled() const", referenced from:
arrow::flight::(anonymous namespace)::GrpcServerCallContext::is_cancelled() const in libarrow_flight.a(server.cc.o)
"grpc::ServerContextBase::peer() const", referenced from:
arrow::flight::(anonymous namespace)::GrpcServerCallContext::GrpcServerCallContext(grpc::ServerContext*) in libarrow_flight.a(server.cc.o)
"_grpc_byte_buffer_reader_destroy", referenced from:
arrow::flight::internal::GrpcBuffer::Wrap(grpc::ByteBuffer*, std::__1::shared_ptr<arrow::Buffer>*) in libarrow_flight.a(serialization_internal.cc.o)
"_grpc_byte_buffer_reader_init", referenced from:
arrow::flight::internal::GrpcBuffer::Wrap(grpc::ByteBuffer*, std::__1::shared_ptr<arrow::Buffer>*) in libarrow_flight.a(serialization_internal.cc.o)
"_grpc_byte_buffer_reader_readall", referenced from:
arrow::flight::internal::GrpcBuffer::Wrap(grpc::ByteBuffer*, std::__1::shared_ptr<arrow::Buffer>*) in libarrow_flight.a(serialization_internal.cc.o)
"_grpc_slice_ref", referenced from:
arrow::flight::internal::GrpcBuffer::GrpcBuffer(grpc_slice, bool) in libarrow_flight.a(serialization_internal.cc.o)
"_grpc_slice_unref", referenced from:
arrow::flight::internal::GrpcBuffer::~GrpcBuffer() in libarrow_flight.a(serialization_internal.cc.o)
ld: symbol(s) not found for architecture arm64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1024181485
@kou I'm still working on the missing symbols, please don't merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056233341
Oh sorry, I didn't see those. I thought it was a network issue. Let me take a look and get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057425101
So, I can manually fix that by copying libgrpc++.a to libgrpcpp.a, then running ar myself. So far, these changes have been made:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 84c27c254..220a5ded0 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -3647,6 +3647,8 @@ macro(build_grpc)
add_custom_target(grpc_copy_grpc++ ALL DEPENDS "${GRPC_STATIC_LIBRARY_GRPCPP_FOR_AR}")
add_dependencies(gRPC::grpcpp_for_bundling grpc_copy_grpc++)
+ list(APPEND ARROW_BUNDLED_STATIC_LIBS gRPC::upb gRPC::gpr gRPC::address_sorting
+ gRPC::grpc++ gRPC::grpc)
list(APPEND ARROW_BUNDLED_STATIC_LIBS ${GRPC_GPR_ABSL_LIBRARIES})
endmacro()
```
and I'm running
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a -pthread
```
That fails with more missing symbols. A lot look like OpenSSL, so that's another issue here: something isn't properly declaring the dependency on OpenSSL.
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a -lssl -lcrypto -pthread
```
This still fails, now we're missing more abseil symbols:
```
/home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a(completion_queue.cc.o): In function `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > absl::lts_20210324::StrFormat<void*>(absl::lts_20210324::str_format_internal::FormatSpecTemplate<(ArgumentToConv<void*>)()> const&, void* const&)':
/home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/include/absl/strings/str_format.h:342: undefined reference to `absl::lts_20210324::str_format_internal::FormatPack[abi:cxx11](absl::lts_20210324::str_format_internal::UntypedFormatSpecImpl, absl::lts_20210324::Span<absl::lts_20210324::str_format_internal::FormatArgImpl const>)'
/home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a(completion_queue.cc.o): In function `void absl::lts_20210324::str_format_internal::FormatArgImpl::Init<absl::lts_20210324::str_format_internal::VoidPtr>(absl::lts_20210324::str_format_internal::VoidPtr const&)':
...
```
@rok does the repro work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057411707
This still gives me a lot of errors with the repro:
```
> ninja (base)
[1/1] Linking CXX executable arrow_example
FAILED: arrow_example
: && /usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a -pthread && :
/home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a(server.cc.o): In function `arrow::flight::(anonymous namespace)::DoExchangeMessageWriter::DoExchangeMessageWriter(grpc::ServerReaderWriter<arrow::flight::protocol::FlightData, arrow::flight::protocol::FlightData>*)':
/home/lidavidm/Code/upstream/rok-arrow-14708/cpp/src/arrow/flight/server.cc:301: undefined reference to `arrow::ipc::IpcWriteOptions::Defaults()'
/home/lidavidm/Code/upstream/rok-arrow-14708/cpp/src/arrow/flight/server.cc:301: undefined reference to `arrow::ipc::DictionaryFieldMapper::DictionaryFieldMapper()'
/home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a(server.cc.o): In function `arrow::flight::(anonymous namespace)::DoExchangeMessageWriter::Begin(std::shared_ptr<arrow::Schema> const&, arrow::ipc::IpcWriteOptions const&)':
...
```
The link order is still wrong - libarrow_flight.a needs to come before libarrow.a. After that, it seems gRPC isn't getting bundled. Indeed, the .ar file is missing gRPC:
```
CREATE /home/lidavidm/Code/upstream/rok-arrow-14708/build/debug/libarrow_bundled_dependencies.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/snappy_ep/src/snappy_ep-install/lib/libsnappy.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/glog_ep-prefix/src/glog_ep/lib/libglogd.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/gflags_ep-prefix/src/gflags_ep/lib/libgflags_debug.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/thrift_ep-install/lib/libthriftd.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/protobuf_ep-install/lib/libprotobuf.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/zlib_ep/src/zlib_ep-install/lib/libz.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/lz4_ep-prefix/src/lz4_ep/lib/liblz4.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/re2_ep-install/lib/libre2.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/utf8proc_ep-install/lib/libutf8proc.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/cares_ep-install/lib/libcares.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_base.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_cord.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_status.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_statusor.a
ADDLIB /home/lidavidm/Code/upstream/rok-arrow-14708/build/absl_ep-install/lib/libabsl_synchronization.a
SAVE
END
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821165352
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -79,11 +80,12 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
PROPERTIES
IMPORTED_LOCATION
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
-
+ INTERFACE_LINK_LIBRARIES
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS}
Review comment:
This needs to be quoted.
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -239,8 +239,7 @@ function(ADD_ARROW_LIB LIB_NAME)
PRIVATE_INCLUDES
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
- STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
Review comment:
Hmm, did you mean to remove this parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060684323
This fixes it:
```diff
diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in
index e8d79c089..1f4ae96b1 100644
--- a/cpp/src/arrow/ArrowConfig.cmake.in
+++ b/cpp/src/arrow/ArrowConfig.cmake.in
@@ -80,7 +80,7 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
IMPORTED_LOCATION
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
INTERFACE_LINK_LIBRARIES
- ${ARROW_STATIC_INSTALL_INTERFACE_LIBS}
+ "${ARROW_STATIC_INSTALL_INTERFACE_LIBS}"
)
get_property(arrow_static_interface_link_libraries
TARGET arrow_static
```
Also if we change this, we don't need to list ssl, crypto, etc. in the downstream package:
```diff
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 403a4e39a..b206ba894 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -533,7 +533,7 @@ else()
set(ARROW_BUILD_BUNDLED_DEPENDENCIES FALSE)
endif()
-if(NOT ARROW_BUILD_BUNDLED_DEPENDENCIES)
+if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
set(ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
endif()
# Need -latomic on Raspbian.
```
But it finally works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060695472
@lidavidm that's great! Thanks for the review I'll address the comments and get back.
Question: should we add a test for the static build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019934244
@kszucs apologies for taking the resources! I accidentally triggered on the wrong commit and reran quickly on the right one. I'll be more selective in the future. Thanks for the feedback :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r790269489
##########
File path: cpp/cmake_modules/gRPCVariables.cmake
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Did you generate this file by `list-absl-libraries.sh`?
Could you add a warning comment to this file something like "DO NOT EDIT THIS FILE MANUALLY. YOU SHOULD UPDATE THIS FILE BY list-absl-libraries.sh ..."? (The warning comment should be generated by `list-absl-libraries.sh` automatically.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018577499
Revision: aed4157ff68fcde5f16a472cd689640dc624f588
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1422](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1422)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-centos-7-amd64)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-clean)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-conda-win-vs2017-py37-r40)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.10)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.16|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-debian-11-go-1.16)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-ubuntu-20.04-python-3)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1422-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1422-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820837421
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -406,7 +406,8 @@ function(ADD_ARROW_LIB LIB_NAME)
"${_lib_install_name}")
endif()
- install(TARGETS ${LIB_NAME}_shared ${INSTALL_IS_OPTIONAL}
+ install(TARGETS ${LIB_NAME}_shared ${ARG_SHARED_INSTALL_EXTRA_TARGETS}
+ ${INSTALL_IS_OPTIONAL}
Review comment:
This change and the one below are also unnecessary right?
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,8 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL})
Review comment:
FWIW, I tried just now and this addition here isn't necessary anymore - it gets picked up transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821034031
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -533,8 +533,8 @@ else()
set(ARROW_BUILD_BUNDLED_DEPENDENCIES FALSE)
endif()
-if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+if(NOT ARROW_BUILD_BUNDLED_DEPENDENCIES)
Review comment:
Ugh, sorry. I was switching back and forth between linux and mac to fix the mac issue and probably caused this. I'll squash later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1062382140
Benchmark runs are scheduled for baseline = 5772d658dced5cca7b95be5fc4266ce189917317 and contender = 2fea81850b7a081dd06ce0c9cc2d442169e6419f. 2fea81850b7a081dd06ce0c9cc2d442169e6419f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee84741f74b5452d8d85822589e6e8b2...6a51877597b24c988860ba22d881ff62/)
[Finished :arrow_down:0.38% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b562f6676ca746798348f6db2a5c8595...708d80f842bd4d37b7a8c88395baafec/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ecf7ca9a4094ae3b004f92fb8a36754...cc6a9858d10c4da58fdda45eacd63940/)
[Finished :arrow_down:0.13% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6506b715a8a4e9080e4a951670428bf...94b5556a49ae4558bf5b7aa151e27590/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019594805
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019602415
Revision: 684284104f7dd7ed9d125dc9d425216839bd4de4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1460](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1460)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-centos-7-amd64)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-clean)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-conda-win-vs2017-py37-r40)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.10)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.16|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-debian-11-go-1.16)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-ubuntu-20.04-python-3)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1460-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1460-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018532256
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1023819402
@github-actions crossbow submit example-cpp-minimal-build-static*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988716978
@lidavidm I'm able to compile this locally now. I've also reduced the abseil dependencies (I think to a minimum).
Do we want further review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821174234
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -239,8 +239,7 @@ function(ADD_ARROW_LIB LIB_NAME)
PRIVATE_INCLUDES
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
- STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
Review comment:
Restored.
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -79,11 +80,12 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
PROPERTIES
IMPORTED_LOCATION
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
- )
-
+ INTERFACE_LINK_LIBRARIES
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS}
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1061228960
Sorry for the rebasing mess @lidavidm ! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821026178
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
I'm not sure about absl::time's deps on non-Apple so leaving that branch as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821026178
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
I'm not sure about absl::time's deps on non-Apple so leaving this as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058514005
@lidavidm I've reintroduced all abseils that were there before and hopefully changed the order of imports. Could you please check again? Strangely this keeps on building for me here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820984115
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -406,7 +406,8 @@ function(ADD_ARROW_LIB LIB_NAME)
"${_lib_install_name}")
endif()
- install(TARGETS ${LIB_NAME}_shared ${INSTALL_IS_OPTIONAL}
+ install(TARGETS ${LIB_NAME}_shared ${ARG_SHARED_INSTALL_EXTRA_TARGETS}
+ ${INSTALL_IS_OPTIONAL}
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058479114
The link order is still wrong:
```
: && /usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a -pthread && :
```
and we're still missing gRPC in the bundled dependencies and OpenSSL in the dependency list. (Though, maybe that last one is the application's responsibility? Not sure if CMake is supposed to pick that up automatically.)
When I try to fix it manually:
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/rok-arrow-14708/build/grpc_ep-install/lib/libgrpc*.a /home/lidavidm/Code/upstream/rok-arrow-14708/build/grpc_ep-install/lib/libgpr.a /home/lidavidm/Code/upstream/rok-arrow-14708/build/grpc_ep-install/lib/libupb.a /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/libarrow_bundled_dependencies.a -lssl -lcrypto -pthread
```
there's still a lot of missing Abseil symbols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988214632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988814142
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-990286963
Just a thought, maybe the `create_merged_static_lib` call needs to be moved before `add_arrow_lib` so that it exists before we use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018990305
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018990610
Revision: 85c920845fa4d1a599510cba72e1273b949da07e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1426](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1426)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-centos-7-amd64)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-clean)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-conda-win-vs2017-py37-r40)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.10)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.16|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-debian-11-go-1.16)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-ubuntu-20.04-python-3)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1426-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1426-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1029845937
I've noticed that with the original set of abseil dependencies we were probably getting namespace collisions. That caused some symbols to not be available. Example error message when doing a static build:
```
cmake \
-GNinja \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
-DARROW_EXTRA_ERROR_CONTEXT=ON \
-DARROW_GRPC_USE_SHARED=ON \
-DARROW_USE_GLOG=ON \
-DARROW_PARQUET=ON \
-DARROW_WITH_SNAPPY=ON \
-DARROW_DATASET=ON \
-DARROW_CSV=ON \
-DARROW_JSON=ON \
-DARROW_PYTHON=ON \
-DARROW_WITH_LZ4=ON \
-DARROW_FLIGHT=ON \
-DARROW_VERBOSE_THIRDPARTY_BUILD=OFF \
-DCMAKE_BUILD_TYPE="Debug" \
-DARROW_DEPENDENCY_SOURCE=BUNDLED \
..
ninja -j8
```
```
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (any.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(any.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(any.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (any.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(any.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(any.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (arena.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(arena.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgpr.a(arena.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (descriptor.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(descriptor.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(descriptor.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (duration.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(duration.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(duration.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (duration.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(duration.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(duration.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (empty.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(empty.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(empty.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (empty.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(empty.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(empty.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (http.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(http.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(http.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (http.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(http.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(http.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (insecure_credentials.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(insecure_credentials.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/libgrpcpp.a(insecure_credentials.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (json_util.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(json_util.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(json_util.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (json_util.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(json_util.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(json_util.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (metadata.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(metadata.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(metadata.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (metadata.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(metadata.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(metadata.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (parser.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(parser.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(parser.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (resource.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(resource.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(resource.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (resource.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(resource.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(resource.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (status.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/libgrpcpp.a(status.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(status.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (status.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(status.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(status.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (status.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(status.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(status.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (struct.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(struct.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(struct.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (struct.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(struct.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(struct.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (time.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgpr.a(time.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/protobuf_ep-install/lib/libprotobuf.a(time.cc.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (timestamp.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(timestamp.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(timestamp.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (timestamp.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(timestamp.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(timestamp.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (wrappers.upb.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(wrappers.upb.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(wrappers.upb.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (wrappers.upbdefs.c.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libupb.a(wrappers.upbdefs.c.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(wrappers.upbdefs.c.o) due to use of basename, truncation and blank padding
/Library/Developer/CommandLineTools/usr/bin/libtool: warning same member name (xds_credentials.cc.o) in output file used for input files: /Users/rok/Documents/repos/ARROW-14708/cpp/build/libgrpcpp.a(xds_credentials.cc.o) and: /Users/rok/Documents/repos/ARROW-14708/cpp/build/grpc_ep-install/lib/libgrpc.a(xds_credentials.cc.o) due to use of basename, truncation and blank padding
```
This lead me to removing some abseil packages from flight, but I can't solve the missing gRPC probably because it's bundled differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057427627
I started working on this on mac and was getting namespace collision and therefore removed some abseils. I was also [hitting this](https://github.com/abseil/abseil-cpp/issues/283) and couldn't get around it so I decided to focus on linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057428175
@lidavidm Thanks for the suggestions, let me try them together with reintroducing those abseils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820987257
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
This won't work on non-Apple platforms will it?
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
Review comment:
Can we append to the property instead of having to list out all the dependencies?
##########
File path: cpp/examples/arrow/CMakeLists.txt
##########
@@ -42,8 +42,12 @@ if(ARROW_FLIGHT)
message(FATAL_ERROR "Statically built gRPC requires ARROW_BUILD_STATIC=ON")
else()
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_static)
- set(GRPC_REFLECTION_LINK_LIBS -Wl,--whole-archive gRPC::grpc++_reflection
- -Wl,--no-whole-archive)
+ if(APPLE)
+ set(GRPC_REFLECTION_LINK_LIBS -Wl,-force_load gRPC::grpc++_reflection -Wl)
Review comment:
Shouldn't this end with `-Wl,--no-force-load` or something?
Related, does it take `-force-load` or `--force-load`?
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -240,7 +240,9 @@ function(ADD_ARROW_LIB LIB_NAME)
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
+ OUTPUT_PATH
+ SHARED_INSTALL_EXTRA_TARGETS
+ STATIC_INSTALL_EXTRA_TARGETS)
Review comment:
I'm still confused here, now the arguments were added back but we don't use them?
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::base
+ absl::civil_time
+ absl::core_headers
+ absl::int128
+ absl::raw_logging_internal
+ absl::strings
+ absl::time_zone
+ ${CoreFoundation})
+ else()
+ find_library(CoreFoundation CoreFoundation)
Review comment:
Do we need this branch at all? Presumably absl::time's deps are correct on non-Apple platforms and we don't need to overwrite them?
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -533,8 +533,8 @@ else()
set(ARROW_BUILD_BUNDLED_DEPENDENCIES FALSE)
endif()
-if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+if(NOT ARROW_BUILD_BUNDLED_DEPENDENCIES)
Review comment:
Is this back to `NOT`? I feel like it flip-flops on every commit…was there a rebase error or something? It might be easier to squash current commits if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1061073847
@lidavidm thanks for your patience. I've pushed another change with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821697130
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,7 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+ set(ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
Review comment:
Removing `_REAL`. It works for me locally, waiting or tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1062382140
Benchmark runs are scheduled for baseline = 5772d658dced5cca7b95be5fc4266ce189917317 and contender = 2fea81850b7a081dd06ce0c9cc2d442169e6419f. 2fea81850b7a081dd06ce0c9cc2d442169e6419f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee84741f74b5452d8d85822589e6e8b2...6a51877597b24c988860ba22d881ff62/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b562f6676ca746798348f6db2a5c8595...708d80f842bd4d37b7a8c88395baafec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ecf7ca9a4094ae3b004f92fb8a36754...cc6a9858d10c4da58fdda45eacd63940/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6506b715a8a4e9080e4a951670428bf...94b5556a49ae4558bf5b7aa151e27590/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058364441
@lidavidm this now runs for me on linux (conda env on ubuntu) if I replace `cpp/examples/minimal_build/example.cc` and `cpp/examples/minimal_build/CMakeLists.txt` with [repro code](https://issues.apache.org/jira/browse/ARROW-14708):
```
cmake .. \
-DCMAKE_BUILD_TYPE=Debug \
-GNinja \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
-DARROW_USE_GLOG=ON \
-DARROW_PARQUET=ON \
-DARROW_WITH_SNAPPY=ON \
-DARROW_DATASET=ON \
-DARROW_CSV=ON \
-DARROW_JSON=ON \
-DARROW_PYTHON=ON \
-DARROW_WITH_LZ4=ON \
-DARROW_FLIGHT=ON \
-DARROW_DEPENDENCY_SOURCE=BUNDLED
ninja -j8
```
I'll check on mac shortly but I suspect it won't work there/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058368530
Seems like there's an unrelated issue with [AWSSDKConfig.cmake](https://github.com/apache/arrow/runs/5411952297?check_suite_focus=true#step:6:1674).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058468242
It's still failing for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057432533
Ah, ok, understood. Hmm, we should probably see about setting this case up in Crossbow once we get it fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821696606
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -563,10 +563,10 @@ add_arrow_lib(arrow
${ARROW_SHARED_PRIVATE_LINK_LIBS}
STATIC_LINK_LIBS
${ARROW_STATIC_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL}
SHARED_INSTALL_INTERFACE_LIBS
${ARROW_SHARED_INSTALL_INTERFACE_LIBS}
- STATIC_INSTALL_INTERFACE_LIBS
- ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
+ STATIC_INSTALL_INTERFACE_LIBS)
Review comment:
It seems so. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1062382140
Benchmark runs are scheduled for baseline = 5772d658dced5cca7b95be5fc4266ce189917317 and contender = 2fea81850b7a081dd06ce0c9cc2d442169e6419f. 2fea81850b7a081dd06ce0c9cc2d442169e6419f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee84741f74b5452d8d85822589e6e8b2...6a51877597b24c988860ba22d881ff62/)
[Finished :arrow_down:0.38% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b562f6676ca746798348f6db2a5c8595...708d80f842bd4d37b7a8c88395baafec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ecf7ca9a4094ae3b004f92fb8a36754...cc6a9858d10c4da58fdda45eacd63940/)
[Finished :arrow_down:0.13% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6506b715a8a4e9080e4a951670428bf...94b5556a49ae4558bf5b7aa151e27590/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-990166782
I'm getting:
```
CMake Error: install(EXPORT "arrow_targets" ...) includes target "arrow_static" which requires target "arrow_bundled_dependencies" that is not in any export set.
```
When running:
```
cmake -DARROW_DEPENDENCY_SOURCE=BUNDLED ..
```
I'll continue tomorrow but would appreciate pointers :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-990390693
@kou thanks for the pointers!
I've pushed the change you proposed and hit another error (below). If you can spare time on this I'd be thankful but it's also a nice learning opportunity for me in case you're busy :).
```bash
-Wall -fno-semantic-interposition -msse4.2
CMake Error at cmake_modules/BuildUtils.cmake:469 (install):
install EXPORT given unknown argument "ArrowTargets.cmake".
Call Stack (most recent call first):
src/arrow/CMakeLists.txt:539 (add_arrow_lib)
-- Creating bundled static library target arrow_bundled_dependencies at /home/rok/Documents/repos/arrow/cpp/build/release/libarrow_bundled_dependencies.a
CMake Error at cmake_modules/BuildUtils.cmake:469 (install):
install EXPORT given unknown argument "ArrowTestingTargets.cmake".
Call Stack (most recent call first):
src/arrow/CMakeLists.txt:601 (add_arrow_lib)
CMake Error at cmake_modules/BuildUtils.cmake:469 (install):
install EXPORT given unknown argument "ArrowDatasetTargets.cmake".
Call Stack (most recent call first):
src/arrow/dataset/CMakeLists.txt:51 (add_arrow_lib)
-- Found Python3: /home/rok/miniconda3/envs/pyarrow-dev/bin/python3.7 (found version "3.7.12") found components: Interpreter Development NumPy Development.Module Development.Embed
CMake Error at cmake_modules/BuildUtils.cmake:469 (install):
install EXPORT given unknown argument "ArrowPythonTargets.cmake".
Call Stack (most recent call first):
src/arrow/python/CMakeLists.txt:70 (add_arrow_lib)
CMake Error at cmake_modules/BuildUtils.cmake:469 (install):
install EXPORT given unknown argument "ParquetTargets.cmake".
Call Stack (most recent call first):
src/parquet/CMakeLists.txt:240 (add_arrow_lib)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r765229149
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
set_target_properties(
arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
"${arrow_static_interface_link_libraries};arrow_bundled_dependencies")
+ # Propagate dependencies like OpenSSL
+ set_target_properties(
+ arrow_bundled_dependencies PROPERTIES INTERFACE_LINK_LIBRARIES
+ "${arrow_static_interface_link_libraries}")
Review comment:
I don't know why this is needed.
Is there a use-case that uses `arrow_bundled_dependencies` without `arrow_static`?
BTW, indent for this code is broken.
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3476,13 +3476,28 @@ macro(build_grpc)
INTERFACE_INCLUDE_DIRECTORIES "${GRPC_INCLUDE_DIR}")
set(GRPC_GPR_ABSL_LIBRARIES
+ absl::bad_optional_access
absl::base
- absl::statusor
- absl::status
absl::cord
+ absl::debugging_internal
+ absl::demangle_internal
+ absl::graphcycles_internal
+ absl::int128
+ absl::log_severity
+ absl::malloc_internal
+ absl::raw_logging_internal
+ absl::spinlock_wait
+ absl::status
+ absl::statusor
+ absl::stacktrace
absl::strings
+ absl::strings_internal
+ absl::str_format_internal
+ absl::symbolize
absl::synchronization
- absl::time)
+ absl::throw_delegate
+ absl::time
+ absl::time_zone)
Review comment:
Can we create a one-linear(?) to collect this list like https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2659-L2667 ?
It may be better that we have a shell script that generates the list and include it from this file:
```bash
# cpp/build-support/list-grpc-absl-libraries.sh
...
echo "set(GRPC_GPR_ABSL_LIBRARIES absl::...)"
```
```console
$ cpp/build-support/list-grpc-absl-libraries.sh > cpp/cmake_modules/gRPCVariables.cmake
```
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 66d04acae..36565fdbf 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -3475,14 +3475,7 @@ macro(build_grpc)
PROPERTIES IMPORTED_LOCATION "${GRPC_STATIC_LIBRARY_UPB}"
INTERFACE_INCLUDE_DIRECTORIES "${GRPC_INCLUDE_DIR}")
- set(GRPC_GPR_ABSL_LIBRARIES
- absl::base
- absl::statusor
- absl::status
- absl::cord
- absl::strings
- absl::synchronization
- absl::time)
+ include(gRPCVariables)
add_library(gRPC::gpr STATIC IMPORTED)
set_target_properties(gRPC::gpr
PROPERTIES IMPORTED_LOCATION "${GRPC_STATIC_LIBRARY_GPR}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988271237
Thanks! Unfortunately I still get a lot of linker errors using the repro from JIRA, but at least the Abseil issues are eliminated. I think the remaining issues are just because of the order of libraries.
This is what CMake generates, which fails with linker errors:
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_flight.a -pthread /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so -lrt /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_bundled_dependencies.a
```
The errors indicate `libarrow_flight.a` is missing symbols from `libarrow.a` and the bundled gRPC is missing symbols from OpenSSL.
This works:
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow.a -pthread /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_bundled_dependencies.a /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so -lrt
```
i.e. link libarrow_flight, then libarrow, then libarrow_bundled_dependencies, then OpenSSL.
Flipping the order of libraries in the CMakeLists.txt fixes the first issue, so I suppose this is user error, or we're missing some dependency expressed in CMake(?).
The installed ArrowFlightTargets.cmake does *not* declare arrow_static in INTERFACE_LINK_LIBRARIES - my CMake understanding is poor but perhaps we need to do so? (It is odd because arrow_static is in the STATIC_LINK_LIBS in flight/CMakeLists.txt.) Also, ArrowTargets.cmake declares OpenSSL as part of arrow_static's INTERFACE_LINK_LIBRARIES, but ArrowConfig.cmake does not do the same for arrow_bundled_dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988275175
This diff gets CMake to repeat `libarrow.a` after `libarrow_flight.a`, so we don't have to order the Arrow libraries ourselves in our "consumer" CMakeLists.txt:
```diff
diff --git a/cpp/src/arrow/flight/CMakeLists.txt b/cpp/src/arrow/flight/CMakeLists.txt
index 8a3228e50..846a420f9 100644
--- a/cpp/src/arrow/flight/CMakeLists.txt
+++ b/cpp/src/arrow/flight/CMakeLists.txt
@@ -170,7 +170,9 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ STATIC_INSTALL_INTERFACE_LIBS
+ arrow_static)
foreach(LIB_TARGET ${ARROW_FLIGHT_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_EXPORTING)
```
And this additional diff, while questionable, fixes the rest of the link errors:
```diff
diff --git a/cpp/src/arrow/ArrowConfig.cmake.in b/cpp/src/arrow/ArrowConfig.cmake.in
index 6209baeec..750d3aba6 100644
--- a/cpp/src/arrow/ArrowConfig.cmake.in
+++ b/cpp/src/arrow/ArrowConfig.cmake.in
@@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
set_target_properties(
arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
"${arrow_static_interface_link_libraries};arrow_bundled_dependencies")
+ # Propagate dependencies like OpenSSL
+ set_target_properties(
+ arrow_bundled_dependencies PROPERTIES INTERFACE_LINK_LIBRARIES
+ "${arrow_static_interface_link_libraries}")
endif()
endif()
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056182806
@github-actions crossbow submit example-cpp-minimal-build-static*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056231233
It seems that they are related because they are failed by link error:
https://github.com/apache/arrow/runs/5386081478?check_suite_focus=true
```text
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so':
/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so: undefined symbol: _ZN3re23RE2D1Ev
```
https://github.com/apache/arrow/runs/5386081500?check_suite_focus=true
```text
Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
unable to load shared object '/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so':
/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so: undefined symbol: _ZN3re23RE2D1Ev
```
https://github.com/ursacomputing/crossbow/runs/5386355726?check_suite_focus=true
```text
[100%] Linking CXX executable arrow_example
/usr/bin/ld: /usr/local/lib/libarrow.a(compression_brotli.cc.o): in function `arrow::util::internal::(anonymous namespace)::BrotliDecompressor::~BrotliDecompressor()':
compression_brotli.cc:(.text+0x13c): undefined reference to `BrotliDecoderDestroyInstance'
/usr/bin/ld: /usr/local/lib/libarrow.a(compression_brotli.cc.o): in function `std::_Sp_counted_ptr_inplace<arrow::util::internal::(anonymous namespace)::BrotliDecompressor, std::allocator<arrow::util::internal::(anonymous namespace)::BrotliDecompressor>, (__gnu_cxx::_Lock_policy)2>::_M_dispose()':
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056208849
@kou I think this is ready for review could you please take a look?
Please note cpp/build-support/list-absl-libraries.sh seems a bit unnecessary now. We should probably remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056217071
Could you confirm test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057430806
> @rok does the repro work for you?
No, static examples do not build yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019595045
Revision: 85c920845fa4d1a599510cba72e1273b949da07e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1457](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1457)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-centos-7-amd64)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-clean)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-conda-win-vs2017-py37-r40)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.10)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.16|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-debian-11-go-1.16)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-depsource-system)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rstudio-r-base-4.1-centos8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-ubuntu-20.04-python-3)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1457-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1457-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019334362
@kou could you please review if this change makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060678522
For some reason it now refuses to link:
```
> cmake ../ -GNinja -DCMAKE_PREFIX_PATH=../install/lib/cmake/arrow
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.1.1")
CMake Error at /home/lidavidm/Code/upstream/rok-arrow-14708/install/lib/cmake/arrow/ArrowConfig.cmake:101 (set_target_properties):
set_target_properties called with incorrect number of arguments.
Call Stack (most recent call first):
CMakeLists.txt:5 (find_package)
-- Arrow version: 8.0.0-SNAPSHOT
-- Arrow SO version: 800.0.0
-- Configuring incomplete, errors occurred!
See also "/home/lidavidm/Code/upstream/rok-arrow-14708/repro/build/CMakeFiles/CMakeOutput.log".
See also "/home/lidavidm/Code/upstream/rok-arrow-14708/repro/build/CMakeFiles/CMakeError.log".
```
The problem is here:
```
101 set_target_properties(
102 arrow_bundled_dependencies
103 PROPERTIES
104 IMPORTED_LOCATION
105 "${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
106 INTERFACE_LINK_LIBRARIES
107 ${ARROW_STATIC_INSTALL_INTERFACE_LIBS}
108 )
```
`ARROW_STATIC_INSTALL_INTERFACE_LIBS` is blank:
```
65 set(ARROW_STATIC_INSTALL_INTERFACE_LIBS "")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060719224
IMO, yes, we can perhaps have a nightly build? We can do that in a separate Jira since we'll need an example that actually links to/uses all these different features (so the linker doesn't just prune them out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1060828751
@lidavidm I've included your suggestions and created a [jira for the nightly test](https://issues.apache.org/jira/browse/ARROW-15859).
@kou Could you please review these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1061817358
@kou thank you for the review! I've pushed suggested changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1059145445
I'll try with the docker container now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820984252
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,8 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL})
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821666992
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,7 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
Review comment:
Why is this removed?
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -534,7 +534,7 @@ else()
endif()
if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+ set(ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
Review comment:
Why do we need `_REAL` alias?
Is there any problem if we use `ARROW_STATIC_INSTALL_INTERFACE_LIBS` directly?
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -563,10 +563,10 @@ add_arrow_lib(arrow
${ARROW_SHARED_PRIVATE_LINK_LIBS}
STATIC_LINK_LIBS
${ARROW_STATIC_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL}
SHARED_INSTALL_INTERFACE_LIBS
${ARROW_SHARED_INSTALL_INTERFACE_LIBS}
- STATIC_INSTALL_INTERFACE_LIBS
- ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
+ STATIC_INSTALL_INTERFACE_LIBS)
Review comment:
Can we remove `STATIC_INSTALL_INTERFACE_LIBS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988271237
Thanks! Unfortunately I still get a lot of linker errors using the repro from JIRA, but at least the Abseil issues are eliminated. I think the remaining issues are just because of the order of libraries/needing to repeat libraries.
This is what CMake generates, which fails with linker errors:
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow.a /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_flight.a -pthread /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so -lrt /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_bundled_dependencies.a
```
The errors indicate `libarrow_flight.a` is missing symbols from `libarrow.a` and the bundled gRPC is missing symbols from OpenSSL.
This works:
```
/usr/bin/c++ -O3 -DNDEBUG CMakeFiles/arrow_example.dir/example.cc.o -o arrow_example /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_flight.a /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow.a -pthread /home/lidavidm/Code/upstream/arrow-14708/install/lib/libarrow_bundled_dependencies.a /usr/lib/x86_64-linux-gnu/libssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so -lrt
```
i.e. link libarrow_flight, then libarrow, then libarrow_bundled_dependencies, then OpenSSL.
Flipping the order of libraries in the CMakeLists.txt fixes the first issue, so I suppose this is user error, or we're missing some dependency expressed in CMake(?).
The installed ArrowFlightTargets.cmake does *not* declare arrow_static in INTERFACE_LINK_LIBRARIES - my CMake understanding is poor but perhaps we need to do so? (It is odd because arrow_static is in the STATIC_LINK_LIBS in flight/CMakeLists.txt.) Also, ArrowTargets.cmake declares OpenSSL as part of arrow_static's INTERFACE_LINK_LIBRARIES, but ArrowConfig.cmake does not do the same for arrow_bundled_dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-990304721
Ah, it seems that we also need to specify `arrow_bundled_dependencies` to `install(TARGETS arrow_static)` something like the following:
```diff
diff --git a/cpp/cmake_modules/BuildUtils.cmake b/cpp/cmake_modules/BuildUtils.cmake
index 38c35d7e7..b88768790 100644
--- a/cpp/cmake_modules/BuildUtils.cmake
+++ b/cpp/cmake_modules/BuildUtils.cmake
@@ -240,7 +240,9 @@ function(ADD_ARROW_LIB LIB_NAME)
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
+ OUTPUT_PATH
+ SHARED_INSTALL_EXTRA_TARGETS
+ STATIC_INSTALL_EXTRA_TARGETS)
cmake_parse_arguments(ARG
"${options}"
"${one_value_args}"
@@ -396,7 +398,7 @@ function(ADD_ARROW_LIB LIB_NAME)
"${_lib_install_name}")
endif()
- install(TARGETS ${LIB_NAME}_shared ${INSTALL_IS_OPTIONAL}
+ install(TARGETS ${LIB_NAME}_shared ${ARG_SHARED_INSTALL_EXTRA_TARGETS} ${INSTALL_IS_OPTIONAL}
EXPORT ${LIB_NAME}_targets
RUNTIME DESTINATION ${RUNTIME_INSTALL_DIR}
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
@@ -451,7 +453,7 @@ function(ADD_ARROW_LIB LIB_NAME)
"$<BUILD_INTERFACE:${ARG_STATIC_LINK_LIBS}>")
endif()
- install(TARGETS ${LIB_NAME}_static ${INSTALL_IS_OPTIONAL}
+ install(TARGETS ${LIB_NAME}_static ${ARG_STATIC_INSTALL_EXTRA_TARGETS} ${INSTALL_IS_OPTIONAL}
EXPORT ${LIB_NAME}_targets
RUNTIME DESTINATION ${RUNTIME_INSTALL_DIR}
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
@@ -464,7 +466,7 @@ function(ADD_ARROW_LIB LIB_NAME)
arrow_install_cmake_find_module("${ARG_CMAKE_PACKAGE_NAME}")
set(TARGETS_CMAKE "${ARG_CMAKE_PACKAGE_NAME}Targets.cmake")
- install(EXPORT ${LIB_NAME}_targets
+ install(EXPORT ${LIB_NAME}_targets ${ARG_CMAKE_
FILE "${TARGETS_CMAKE}"
DESTINATION "${ARROW_CMAKE_INSTALL_DIR}")
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 5736c557b..07520d919 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -557,7 +557,9 @@ add_arrow_lib(arrow
SHARED_INSTALL_INTERFACE_LIBS
${ARROW_SHARED_INSTALL_INTERFACE_LIBS}
STATIC_INSTALL_INTERFACE_LIBS
- ${ARROW_STATIC_INSTALL_INTERFACE_LIBS})
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS}
+ STATIC_EXTRA_TARGETS
+ arrow_bundled_dependencies)
add_dependencies(arrow ${ARROW_LIBRARIES})
```
Or we can add `install(TARGETS arrow_bundled_dependencies EXPORT arrow_targets ...)` separately.
Do you want me to take this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r765244471
##########
File path: cpp/src/arrow/ArrowConfig.cmake.in
##########
@@ -87,6 +87,10 @@ if(NOT (TARGET arrow_shared OR TARGET arrow_static))
set_target_properties(
arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
"${arrow_static_interface_link_libraries};arrow_bundled_dependencies")
+ # Propagate dependencies like OpenSSL
+ set_target_properties(
+ arrow_bundled_dependencies PROPERTIES INTERFACE_LINK_LIBRARIES
+ "${arrow_static_interface_link_libraries}")
Review comment:
Ah, the problem here is the order of libraries to the linker. As described above, currently, the order is OpenSSL, then libarrow_bundled_dependencies, so linking will fail because libarrow_bundled_dependencies itself also depends on OpenSSL. Adding this gets CMake to repeat OpenSSL after libarrow_bundled_dependencies and then the linker will find the necessary symbols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok edited a comment on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok edited a comment on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019998064
I checked the failing builds that did not fail in the nightly:
Seems unrelated:
* test-conda-python-3.9-spark-master
* test-ubuntu-20.04-cpp-thread-sanitizer
* ubuntu-hirsute-amd64
Seems flaky:
* debian-bookworm-arm64 - GitHub 502 on `archery crossbow`
* homebrew-r-autobrew - Minio issue with R
* python-sdist - GDB issue
* test-build-cpp-fuzz - GitHub permissions issue
* test-fedora-33-python-3 - dependency download issue
* test-r-rstudio-r-base-4.1-opensuse15 - dependency download issue
* wheel-manylinux2014-cp39-arm64 - dependency download issue
* wheel-manylinux2014-cp39-amd64 - vcpkg download issue
* wheel-manylinux2014-cp310-arm64 - vcpkg download issue
* wheel-manylinux2014-cp38-arm64 - vcpkg download issue
ZSTD (undefined reference to `ZSTD_<Something>}’ …):
* example-cpp-minimal-build-static
* example-cpp-minimal-build-static-system-dependency
Unclear:
* ubuntu-bionic-arm64 - errored and did not run
I'll check if ZSTD issue is related to the change and report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1023820143
Revision: 7f7ef5eb2e63f36633eec2157a4c917c353a0f2f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1511](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1511)
|Task|Status|
|----|------|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820819264
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,9 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL}
+ arrow_static)
Review comment:
Indeed. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056184495
Revision: 5995096dd05b7625515f48c7ae5f29807bf2b347
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1709](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1709)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1709-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1709-github-example-cpp-minimal-build-static-system-dependency)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1058387605
On mac:
```
Undefined symbols for architecture arm64:
"_CFRelease", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
"_CFStringGetCString", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
"_CFStringGetLength", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
"_CFStringGetMaximumSizeForEncoding", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
"_CFTimeZoneCopyDefault", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
"_CFTimeZoneGetName", referenced from:
absl::lts_20210324::time_internal::cctz::local_time_zone() in libabsl_time_zone.a(time_zone_lookup.cc.o)
```
Which looks like [this cctz issue](https://github.com/abseil/abseil-cpp/issues/283).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057425522
Aren't a lot of these issues the same ones we had initially? Especially the missing OpenSSL and the wrong order of the link parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1059149820
@lidavidm Ah sorry, I was building the repro with `-DARROW_BUILD_EXAMPLES=ON` and wasn't getting issues. Building with:
```
cmake . -DCMAKE_MODULE_PATH=/home/rok/Documents/repos/arrow/cpp/cmake_modules/ -DCMAKE_PREFIX_PATH=/home/rok/miniconda3/envs/pyarrow-dev/lib/
```
Surfaces the symbol issues again. I'll fix it and get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1059145046
I wonder if it's because one of us is enabling C++17? Apparently that changes the available symbols: https://github.com/conda-forge/abseil-cpp-feedstock/pull/25#issuecomment-1058682145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1059907579
@lidavidm this now builds the repro on my laptop with a small adjustment to CMakeLists.txt. Namely last line should be:
`target_link_libraries(arrow_example PRIVATE arrow_flight_static arrow_static arrow_bundled_dependencies ssl crypto rt Threads::Threads)`.
Could you please check again on your end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r790349215
##########
File path: cpp/cmake_modules/gRPCVariables.cmake
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019602000
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057435550
> Ah, ok, understood. Hmm, we should probably see about setting this case up in Crossbow once we get it fixed.
That would be a good idea. We should make sure we check the mac issues once we're done here, but I would prefer that in a separate scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1056233341
Oh sorry, I didn't see those. I thought it was a CI issue. Let me take a look and get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-1057421869
aaaaand when I try to fix it: https://github.com/google/shaderc/issues/473#issuecomment-409754031
…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821034235
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3403,15 +3403,32 @@ macro(build_absl_once)
set_property(TARGET absl::throw_delegate
PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::time
- PROPERTY INTERFACE_LINK_LIBRARIES
- absl::base
- absl::civil_time
- absl::core_headers
- absl::int128
- absl::raw_logging_internal
- absl::strings
- absl::time_zone)
+ if(APPLE)
+ # This is due to upstream absl::cctz issue
+ # https://github.com/abseil/abseil-cpp/issues/283
+ find_library(CoreFoundation CoreFoundation)
+ set_property(TARGET absl::time
Review comment:
Switched to append.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r821047530
##########
File path: cpp/examples/arrow/CMakeLists.txt
##########
@@ -42,8 +42,12 @@ if(ARROW_FLIGHT)
message(FATAL_ERROR "Statically built gRPC requires ARROW_BUILD_STATIC=ON")
else()
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_static)
- set(GRPC_REFLECTION_LINK_LIBS -Wl,--whole-archive gRPC::grpc++_reflection
- -Wl,--no-whole-archive)
+ if(APPLE)
+ set(GRPC_REFLECTION_LINK_LIBS -Wl,-force_load gRPC::grpc++_reflection -Wl)
Review comment:
So `all_load`/`noall_load` currently won't work due to symbol duplication so `force-load` is the only option and there appears to be no `noforce-load` option.
More [here](https://github.com/premake/premake-core/issues/1170).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
kou closed pull request #11889:
URL: https://github.com/apache/arrow/pull/11889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-988311703
Thanks @lidavidm I was gonna ask for ideas about the flight linking errors! I'll include your diffs and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-989024721
@kou Sorry to trouble you, but would you be able to look over the CMake changes here? I'm not sure if the changes to ArrowConfig.cmake.in are strictly correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#issuecomment-989954674
Thanks for the feedback @kou and @lidavidm! I've moved things around as suggested. My cmake skills are lacking.
I've also added a [shell script to extract the `gRPCVariables`](https://github.com/apache/arrow/blob/7d55e3cd32f83588ac12041b61105dc37861f4a3/cpp/build-support/list-absl-libraries.sh). It extracts Abseil and gRPC dependencies at the moment, but I am not sure about it's correctness. Could one of you please take a look and suggest improvements if needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org