You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "IOhacker (via GitHub)" <gi...@apache.org> on 2025/03/03 03:32:59 UTC

Re: [PR] Refactor ResultsetColumnHeaderData to Use Lombok Annotations for Boilerplate Reduction [fineract]

IOhacker commented on code in PR #4307:
URL: https://github.com/apache/fineract/pull/4307#discussion_r1976831474


##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -39,240 +51,85 @@ public final class ResultsetColumnHeaderData implements Serializable {
     private final boolean isColumnPrimaryKey;
     private final boolean isColumnUnique;
     private final boolean isColumnIndexed;
-
     private final List<ResultsetColumnValueData> columnValues;
     private final String columnCode;
 
     public static ResultsetColumnHeaderData basic(final String columnName, final String columnType, DatabaseType dialect) {
-        final Long columnLength = null;
-        final boolean columnNullable = false;
-        final boolean columnIsPrimaryKey = false;
-        final List<ResultsetColumnValueData> columnValues = new ArrayList<>();
-        final String columnCode = null;
-        final boolean columnIsUnique = false;
-        final boolean columnIsIndexed = false;
-        return new ResultsetColumnHeaderData(columnName, columnType, columnLength, columnNullable, columnIsPrimaryKey, columnValues,
-                columnCode, columnIsUnique, columnIsIndexed, dialect);
+        return ResultsetColumnHeaderData.builder()
+                .columnName(columnName)
+                .columnType(JdbcJavaType.getByTypeName(dialect, adjustColumnType(columnType), true))
+                .columnLength(null)
+                .isColumnNullable(false)
+                .isColumnPrimaryKey(false)
+                .isColumnUnique(false)
+                .isColumnIndexed(false)
+                .columnValues(new ArrayList<>())
+                .columnCode(null)
+                .columnDisplayType(calcDisplayType(null, JdbcJavaType.getByTypeName(dialect, adjustColumnType(columnType), true)))
+                .build();
     }
 
     public static ResultsetColumnHeaderData detailed(final String columnName, final String columnType, final Long columnLength,
-            final boolean columnNullable, final boolean columnIsPrimaryKey, final List<ResultsetColumnValueData> columnValues,
-            final String columnCode, final boolean columnIsUnique, final boolean columnIsIndexed, DatabaseType dialect) {
-        return new ResultsetColumnHeaderData(columnName, columnType, columnLength, columnNullable, columnIsPrimaryKey, columnValues,
-                columnCode, columnIsUnique, columnIsIndexed, dialect);
-    }
-
-    private ResultsetColumnHeaderData(final String columnName, String columnType, final Long columnLength, final boolean columnNullable,
-            final boolean columnIsPrimaryKey, final List<ResultsetColumnValueData> columnValues, final String columnCode,
-            final boolean columnIsUnique, final boolean columnIsIndexed, DatabaseType dialect) {
-        this.columnName = columnName;
-        this.columnLength = columnLength;
-        this.isColumnNullable = columnNullable;
-        this.isColumnPrimaryKey = columnIsPrimaryKey;
-        this.columnValues = columnValues;
-        this.columnCode = columnCode;
-        this.isColumnUnique = columnIsUnique;
-        this.isColumnIndexed = columnIsIndexed;
-
-        // Refer org.drizzle.jdbc.internal.mysql.MySQLType.java
-        this.columnType = JdbcJavaType.getByTypeName(dialect, adjustColumnType(columnType), true);
-
-        this.columnDisplayType = calcDisplayType();
-    }
-
-    public String getColumnName() {
-        return this.columnName;
-    }
-
-    public boolean isNamed(final String columnName) {

Review Comment:
   @a7med3del1973 could you please review the comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org