You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Vitaly Tsaplin (JIRA)" <ji...@apache.org> on 2010/11/22 19:06:14 UTC
[jira] Created: (WICKET-3184) Make method getContentId of
ModalWindow static
Make method getContentId of ModalWindow static
----------------------------------------------
Key: WICKET-3184
URL: https://issues.apache.org/jira/browse/WICKET-3184
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Reporter: Vitaly Tsaplin
My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3184) Make method getContentId of
ModalWindow static
Posted by "Vitaly Tsaplin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934749#action_12934749 ]
Vitaly Tsaplin commented on WICKET-3184:
----------------------------------------
It may be implemented even easier and in less intrusive way. You could just introduce a public constant CONTENT_ID and getContentId would just access this constant.
> Make method getContentId of ModalWindow static
> ----------------------------------------------
>
> Key: WICKET-3184
> URL: https://issues.apache.org/jira/browse/WICKET-3184
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Vitaly Tsaplin
> Priority: Minor
>
> My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3184) Make method getContentId of
ModalWindow static
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964533#action_12964533 ]
Hudson commented on WICKET-3184:
--------------------------------
Integrated in Apache Wicket 1.4.x #297 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/297/])
WICKET-3184 Make method getContentId of ModalWindow static
Introduce ModalWindow#CONTENT_ID public constant which is used as default id for the content component
> Make method getContentId of ModalWindow static
> ----------------------------------------------
>
> Key: WICKET-3184
> URL: https://issues.apache.org/jira/browse/WICKET-3184
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Vitaly Tsaplin
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.15, 1.5-M4
>
>
> My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3184) Make method getContentId of
ModalWindow static
Posted by "Vitaly Tsaplin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vitaly Tsaplin updated WICKET-3184:
-----------------------------------
Priority: Minor (was: Major)
> Make method getContentId of ModalWindow static
> ----------------------------------------------
>
> Key: WICKET-3184
> URL: https://issues.apache.org/jira/browse/WICKET-3184
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Vitaly Tsaplin
> Priority: Minor
>
> My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3184) Make method getContentId of
ModalWindow static
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3184.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.15
Assignee: Martin Grigorov
The static constant ModalWindow#CONTENT_ID is introduced with r1039867 in trunk and r1039866 in 1.4.x
> Make method getContentId of ModalWindow static
> ----------------------------------------------
>
> Key: WICKET-3184
> URL: https://issues.apache.org/jira/browse/WICKET-3184
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Vitaly Tsaplin
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.15, 1.5-M4
>
>
> My proposal is to make the method getContentId of the class ModalWindow STATIC to simplify a creation of the panel class that would serve as a base class for content components. It's always necessary to specify a content ID when we create a component which can be added as a window component. This content ID can be obtained only from an instance of the modal window which often is not convenient neither neccesary since it's just a constant kept in sync with the id in the window markup. Also there is no obvious reason to override this method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.