[XS] Change in asterixdb[lumina]: [NO ISSUE] Surface ASX1113 for invalid regex patterns - user model ch...

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Rithwik Koul <ri...@couchbase.com>:

Rithwik Koul has uploaded a new patch set (#2). ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21227?usp=email )


Change subject: [NO ISSUE] Surface ASX1113 for invalid regex patterns - user model changes: no - storage format changes: no - interface changes: no
......................................................................

[NO ISSUE] Surface ASX1113 for invalid regex patterns
- user model changes: no
- storage format changes: no
- interface changes: no

Details : Wrap Pattern.compile in RegExpMatcher.build with try/catch for
PatternSyntaxException; rethrow as RuntimeDataException with the existing
INVALID_REGEX_PATTERN(1113) error code. Previously, invalid regex patterns
in regex_matches / regex_replace / regex_split / regex_position /
regex_contains / regex_like (and their flag/offset variants) plus the
SQL LIKE operator surfaced as generic "Internal error" (code 25000) with
a leaked Java stack trace. The error code already existed in
ErrorCode.INVALID_REGEX_PATTERN and was used in ExternalDataUtils.java
for the same purpose; this patch wires up the runtime evaluator path to
the same convention.

Ext-ref: NO TICKET
Change-Id: I09b5a2c5fd6fc2e845e88a702f0a4cca00d427da
---
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/utils/RegExpMatcher.java
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/27/21227/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21227?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I09b5a2c5fd6fc2e845e88a702f0a4cca00d427da
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 2
Gerrit-Owner: Rithwik Koul <ri...@couchbase.com>