You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org> on 2006/08/11 20:27:13 UTC
[jira] Created: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
------------------------------------------------------------------------------------------------
Key: DERBY-1675
URL: http://issues.apache.org/jira/browse/DERBY-1675
Project: Derby
Issue Type: Improvement
Components: Network Server
Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.0.0
Reporter: Sunitha Kambhampati
Priority: Minor
As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-1675) Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
Posted by Francois Orsini <fr...@gmail.com>.
Am going to post the few comments I have this afternoon.
On 9/8/06, Mike Matrigali (JIRA) <de...@db.apache.org> wrote:
>
> [ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
>
> Mike Matrigali updated DERBY-1675:
> ----------------------------------
>
>
> francois do you have any initial comments on the change? tests passed for
> me and they look reasonable but would prefer to get review of someone
> experienced in this code. I can work on committing this today or tommorow,
> but after that I will be away for a week. This seems like something that
> would be nice to get into 10.2.
>
> > Network Server should not send to client that it supports EUSRIDPWD when
> running against Sun JVM
> >
> ------------------------------------------------------------------------------------------------
> >
> > Key: DERBY-1675
> > URL: http://issues.apache.org/jira/browse/DERBY-1675
> > Project: Derby
> > Issue Type: Improvement
> > Components: Network Server
> > Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1,
> 10.0.2.0, 10.2.1.0
> > Reporter: Sunitha Kambhampati
> > Assigned To: Sunitha Kambhampati
> > Priority: Minor
> > Attachments: derby1675.diff.txt, derby1675.stat.txt
> >
> >
> > As part of ACCSECRD, if the server does not accept the security
> mechanism sent by the client, the server will send a list of security
> mechanism that it supports. Currently even when the server is running with
> sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which
> is incorrect. The server should test if it can support EUSRIDPWD
> dynamically and if it does, only then send EURRIDPWD as an option that it
> supports.
> > see DRDAConnThread.writeACCSECRD(int)
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Mike Matrigali updated DERBY-1675:
----------------------------------
Fix Version/s: 10.3.0.0
I committed the submitted patch (derby1675.diff.txt) to the trunk as requested by Sunitha and given the minor
nature of the reviewers comments -thanks Francois for the quick review.
Go ahead and post
the follow up comment change patch to this issue. This 2 step process actually works better for
me as I can easily scan the second patch and if it is only comments won't need to run any other tests to
feel ok to commit.
m1_142:6>svn commit
Sending java\drda\org\apache\derby\impl\drda\DRDAConnThread.java
Sending java\drda\org\apache\derby\impl\drda\NetworkServerControlImpl.java
Sending java\drda\org\apache\derby\impl\drda\TestProto.java
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk14\ver2.8\testSecMec.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\testSecMec.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\ver2.6\testSecMec.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\ver2.8\testSecMec.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk14\testSecMec.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\testSecMec.out
Adding java\testing\org\apache\derbyTesting\functionTests\master\ibm14
Adding java\testing\org\apache\derbyTesting\functionTests\master\ibm14\testProtocol.out
Sending java\testing\org\apache\derbyTesting\functionTests\master\testProtocol.out
Sending java\testing\org\apache\derbyTesting\functionTests\tests\derbynet\protocol.tests
Sending java\testing\org\apache\derbyTesting\functionTests\tests\derbynet\testSecMec.java
Transmitting file data .............
Committed revision 441722.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati updated DERBY-1675:
---------------------------------------
Attachment: derby1675.stat.txt
derby1675.diff.txt
EUSRIDPWD support depends on the JCE available in the classpath of the server
This patch(derby1675.diff.txt) does the following
1. Add code to check if server jvm can support EUSRIDPWD.
2. Throw an error if the derby.drda.securityMechanism is set to ENCRYPTED_USER_AND_PASSWORD_SECURITY
and if the server jvm cannot support EUSRIDPWD.
3. Server sends the client the list of supported security mechanisms as part of ACCSECRD. Now, the server will correctly only send EUSRIDPWD as an option if the running server can support this security mechanism.
Test related changes:
Changes were made to testProtocol.java and a new method readSecMecAndSECCHKCD is added to TestProto to read the SECMEC and SECCHKCD values. Note, that with ibm142 and ibm15 jvms that support eusridpwd, the SECMEC value 9 (eusridpwd) will be sent as part of the ACCSECRD response. But for the jvms that dont support the eusridpwd, the SECMEC value of 9 wont be sent. The new method readSecMecAndSECCHKCD takes
care of printing out the SECMEC values that are sent by the server - this results in the need for a new master file for the jvm that support eusridpwd and the jvm that cannot support it. A new master file has been added for ibm14.
Tests for codepath that covers #2 is already present in testSecMec.java. This results in themaster updates for the jvms that do not support eusridpwd for the case where server is started with
derby..drda.securityMechanism=ENCRYPTED_USER_AND_PASSWORD_SECURITY.
derbyall ran ok on ibm142/linux with two known intermittent failures(NSInSameJVM and DerbyNetAutoStart)
I ran testSecMec on win2k/t40laptop/ on ibm jvm 131,142,15 as well as sun jvm 131,142,15. Also have updated masters for jcc versions 2.4,2.6,2.8.
Can someone please review this change.
Thanks.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Francois Orsini (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433535 ]
Francois Orsini commented on DERBY-1675:
----------------------------------------
Here are my comments.
Very good changes indeed Sunitha. My comments are ONLY minor ones. Mostly recommendations with some of the comments, etc.
1) java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java
A) Static block:
+ // Sun JCE does not have support for EUSRIDPWD, whereas
+ // most versions of IBM JCE have support for this. Hence
+ // find out if the server can support EUSRIDPWD.
Minor nit but EUSRIDPWD is not part of the JVM - It is just that some JCE provider(s) may not have DH support with a Prime of 32-bytes. I
would have phrased this differently, such as:
// DRDA Specification for the EUSRIDPWD security mechanism
// requires DH algorithm support with a 32-byte prime to be
// used. Not all JCE implementations have support for this.
// Hence here we need to find out if EUSRIDPWD can be used
// with the current JVM.
Again, this is just my recommendation to phrase this differently - Take it or leave it :)
+ /**
+ * EUSRIDPWD support depends on the availability of the
+ * algorithm in the JCE implementation in the classpath
+ * of the server. At runtime, information about this
+ * capability is figured out.
+ * @return whether EUSRIDPWD is supported or not
+ */
B) supportsEUSRIDPWD():
Here I would have just put the following comments:
/**
* This method returns whether EUSRIDPWD security mechanism
* is supported or not. See class static block for more
* info.
* @return true if EUSRIDPWD is supported, falso otherwise
*/
I think you need 1 more CR (line space before the next getIntPropVal())
2) +++ java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/protocol.tests
-readScalar2Bytes SECMEC 3// SECMEC
-readScalar2Bytes SECMEC 9// SECMEC
-readScalar2Bytes SECMEC 4// SECMEC
-readScalar2Bytes SECMEC 8// SECMEC
-readScalar1Byte SECCHKCD 1// SECMEC
+readSecMecAndSECCHKCD // read secmec values and secchkcd
We're loosing the returned list to check here but I guess it is not obvious to have this protocol test driver behave conditionally based on the JVM being run, etc...since there is no canon's for this test if am not mistaken...Anyway, too much of a big deal I'd say.
I have also tested the patch with Solaris / jdk 1.5 ...
Cheers.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Mike Matrigali updated DERBY-1675:
----------------------------------
francois do you have any initial comments on the change? tests passed for me and they look reasonable but would prefer to get review of someone experienced in this code. I can work on committing this today or tommorow, but after that I will be away for a week. This seems like something that would be nice to get into 10.2.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati updated DERBY-1675:
---------------------------------------
Attachment: derby1675.comments.diff.txt
Thanks Mike for the commit for derby1675.diff.txt.
I am attaching a followup patch derby1675.comments.diff.txt .
This patch only has change in comments.
svn stat
M java\drda\org\apache\derby\impl\drda\NetworkServerControlImpl.java
Can someone please commit this patch. Thanks.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12434214 ]
Sunitha Kambhampati commented on DERBY-1675:
--------------------------------------------
Thanks Knut for the commit. I am leaving this issue open till this fix goes into 10.2.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati reassigned DERBY-1675:
------------------------------------------
Assignee: Sunitha Kambhampati
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433595 ]
Knut Anders Hatlen commented on DERBY-1675:
-------------------------------------------
Committed derby1675.comments.diff.txt into trunk with revision 441779.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati updated DERBY-1675:
---------------------------------------
Fix Version/s: 10.2.1.0
(was: 10.2.2.0)
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0, 10.2.1.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati closed DERBY-1675.
--------------------------------------
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.3.0.0, 10.2.1.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433537 ]
Sunitha Kambhampati commented on DERBY-1675:
--------------------------------------------
Thanks Francois for your comments.
> "We're loosing the returned list to check here"
Wrt to #2, We are not losing the returned list to check since the readSecMecAndSECCHKCD method prints the secmec that it receives. Actually that was the reason, I had to print the values in readSecMecAndSECCHKCD.
Thus we have two different cannons, which is why the testProtocol.out was added for ibm14.
So if you look at the diff for testProtocol.out , for e.g., you will see this.
......
Test trying security mechanism we don't support
+SECMEC=3 SECMEC=4 SECMEC=8 SECCHKCD=1
In case for ibm142 (new masterfile that got added), you would see
+Test trying security mechanism we don't support
+SECMEC=3 SECMEC=9 SECMEC=4 SECMEC=8 SECCHKCD=1
Do you agree ? or am I missing something in your comment.
I like your suggestion for the comments in the code. I'll make that change.
Thanks.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1675) Network Server should not send
to client that it supports EUSRIDPWD when running against Sun JVM
Posted by Sunitha Kambhampati <ks...@gmail.com>.
I'd like to post the minor comments suggestion as a followup patch. That
way derby-1675.diff.txt can be committed as is. And the next followup
patch will only be a comment change patch.
Does that sound reasonable ?
Thanks,
Sunitha.
Francois Orsini (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433539 ]
>
>Francois Orsini commented on DERBY-1675:
>----------------------------------------
>
>Oops - Yes this is right - I actually checked the canon's - nevermind Sunitha :)
>
>Thanks.
>
>
>
>>Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
>>------------------------------------------------------------------------------------------------
>>
>> Key: DERBY-1675
>> URL: http://issues.apache.org/jira/browse/DERBY-1675
>> Project: Derby
>> Issue Type: Improvement
>> Components: Network Server
>> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
>> Reporter: Sunitha Kambhampati
>> Assigned To: Sunitha Kambhampati
>> Priority: Minor
>> Attachments: derby1675.diff.txt, derby1675.stat.txt
>>
>>
>>As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
>>see DRDAConnThread.writeACCSECRD(int)
>>
>>
>
>
>
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Francois Orsini (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433539 ]
Francois Orsini commented on DERBY-1675:
----------------------------------------
Oops - Yes this is right - I actually checked the canon's - nevermind Sunitha :)
Thanks.
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Mike Matrigali updated DERBY-1675:
----------------------------------
I ran full set of tests against this patch on XP, sun jdk 1.42 and passed except for 2 known intermittent errors in
testProperties and DerbyNetNewServer
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1675) Network Server should not send
to client that it supports EUSRIDPWD when running against Sun JVM
Posted by Sunitha Kambhampati <ks...@gmail.com>.
Francois Orsini (JIRA) wrote:
>Am reviewing the changes - I have changes in similar code areas (DERBY-1517)
>
>
Thanks Francois for reviewing these changes and also working on the
important derby-1517.
In case the 1675 changes interfere with changes for derby-1517 please
let me know and we can probably work out how best to get them in.
Thanks,
Sunitha.
[jira] Commented: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Francois Orsini (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=comments#action_12433180 ]
Francois Orsini commented on DERBY-1675:
----------------------------------------
Am reviewing the changes - I have changes in similar code areas (DERBY-1517)
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.0, 10.1.2.1, 10.1.3.0, 10.1.3.1
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati updated DERBY-1675:
---------------------------------------
Derby Info: [Patch Available]
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1675) Network Server should not send to
client that it supports EUSRIDPWD when running against Sun JVM
Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1675?page=all ]
Sunitha Kambhampati resolved DERBY-1675.
----------------------------------------
Fix Version/s: 10.2.2.0
Resolution: Fixed
Derby Info: (was: [Patch Available])
This fix is backported to 10.2 as part of the mega merge effort. Thanks Rick.
http://svn.apache.org/viewvc?view=rev&rev=446679
> Network Server should not send to client that it supports EUSRIDPWD when running against Sun JVM
> ------------------------------------------------------------------------------------------------
>
> Key: DERBY-1675
> URL: http://issues.apache.org/jira/browse/DERBY-1675
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.1.3.1, 10.1.3.0, 10.1.2.1, 10.1.1.0, 10.0.2.1, 10.0.2.0, 10.2.1.0
> Reporter: Sunitha Kambhampati
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Fix For: 10.2.2.0, 10.3.0.0
>
> Attachments: derby1675.comments.diff.txt, derby1675.diff.txt, derby1675.stat.txt
>
>
> As part of ACCSECRD, if the server does not accept the security mechanism sent by the client, the server will send a list of security mechanism that it supports. Currently even when the server is running with sun jvm, it will still send EUSRIDPWD as a sec mec that it supports, which is incorrect. The server should test if it can support EUSRIDPWD dynamically and if it does, only then send EURRIDPWD as an option that it supports.
> see DRDAConnThread.writeACCSECRD(int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira