You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/14 20:35:53 UTC
[GitHub] [superset] codecov-io commented on pull request #12526: fix: ignore system files on import
codecov-io commented on pull request #12526:
URL: https://github.com/apache/superset/pull/12526#issuecomment-760460689
# [Codecov](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=h1) Report
> Merging [#12526](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=desc) (756a660) into [master](https://codecov.io/gh/apache/superset/commit/78baf46eb2359c9dfbf1f09ce3e8dc9f346d7e77?el=desc) (78baf46) will **decrease** coverage by `3.54%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12526 +/- ##
==========================================
- Coverage 66.71% 63.17% -3.55%
==========================================
Files 1014 485 -529
Lines 49576 29934 -19642
Branches 4960 0 -4960
==========================================
- Hits 33076 18910 -14166
+ Misses 16377 11024 -5353
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.17% <100.00%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.51% <100.00%> (ø)` | |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.95% <100.00%> (+0.91%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.63% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.33% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.49% <100.00%> (-1.83%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/12526/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=footer). Last update [78baf46...756a660](https://codecov.io/gh/apache/superset/pull/12526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org