[GitHub] [superset] rusackas commented on pull request #18813: fix(altered-modal): displayed the metric value in altered modal correctly

[GitBox <gi...@apache.org>]

rusackas commented on pull request #18813:
URL: https://github.com/apache/superset/pull/18813#issuecomment-1044877862


   > Hello @prosdev0107 thanks for the PR. There are some linting issues to fix. Also, I don't think you need to tick the "Changes UI" checkbox in the PR description as that is intended for changes that affect the UI, in this case, this is just a fix of standard behavior.
   
   Agreed on the checkbox, though I appreciate _over-checking_ rather than _under-checking_ :)
   
   To run the linter locally, just run `npm run lint-fix` from within the `superset-frontend` folder you can also install the pre-commit hooks if you'd like (I would need to dig up the command if so, since I don't remember it offhand)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org