[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1089:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r643290829



##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -127,8 +129,8 @@ core::Property ConsumeWindowsEventLog::EventHeaderDelimiter(
 core::Property ConsumeWindowsEventLog::EventHeader(
   core::PropertyBuilder::createProperty("Event Header")->
   isRequired(false)->
-  withDefaultValue("LOG_NAME=Log Name, SOURCE = Source, TIME_CREATED = Date,EVENT_RECORDID=Record ID,EVENTID = Event ID,TASK_CATEGORY = Task Category,LEVEL = Level,KEYWORDS = Keywords,USER = User,COMPUTER = Computer, EVENT_TYPE = EventType")->
-  withDescription("Comma seperated list of key/value pairs with the following keys LOG_NAME, SOURCE, TIME_CREATED,EVENT_RECORDID,EVENTID,TASK_CATEGORY,LEVEL,KEYWORDS,USER,COMPUTER, and EVENT_TYPE. Eliminating fields will remove them from the header.")->
+  withDefaultValue("LOG_NAME=Log Name, SOURCE = Source, TIME_CREATED = Date,EVENT_RECORDID=Record ID,EVENTID = Event ID,TASK_CATEGORY = Task Category,LEVEL = Level,KEYWORDS = Keywords,USER = User,COMPUTER = Computer, EVENT_TYPE = EventType")->  // NOLINT linelength
+  withDescription("Comma seperated list of key/value pairs with the following keys LOG_NAME, SOURCE, TIME_CREATED,EVENT_RECORDID,EVENTID,TASK_CATEGORY,LEVEL,KEYWORDS,USER,COMPUTER, and EVENT_TYPE. Eliminating fields will remove them from the header.")-> // NOLINT linelength

Review comment:
       The reason I suggested the split is that we already don't follow the google guideline in this regard, as the current maximum line length is set to 200 characters which is quite permissive. Also we already have split the long descriptions in other processors as well. But as it is an exception to the rule I'm not against the idea of keeping it in a single line, it also has the advantage of being able to search for the same description in both the codebase and the *.md files.
   
   I also support moving the `->` operators to the beginning of the lies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org