You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2017/03/01 00:19:26 UTC
[GitHub] twill pull request #34: Feature/twill 186
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/34
Feature/twill 186
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/twill-186
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit b64c90b618f065ca01a8c5d36df2535b1344564e
Author: Terence Yim <ch...@apache.org>
Date: 2017-02-28T05:22:32Z
(TWILL-186) Code cleanup for ApplicationMasterService and related classes
- Get rid of the inner loop in the doRun method
- The inner loop can block the heartbeat thread for too long if there are a lot of runnable instances to stop
- Remove unnecessary throwables.propagate
- Remove unnecessary intermediate method
- Better logging
- Request multiple instances in the same request
- Refactory/simiply placement policy related code
- Expose container instanceId instead of parsing it from runId
commit fcfa5becd61ddc2513f29a2be700b3be166d4b0b
Author: Terence Yim <ch...@apache.org>
Date: 2017-02-28T22:43:37Z
(TWILL-186) Guard against YARN returning mismatch container size case.
- Also make sure we don't remove container request without adding it
first
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #34: (TWILL-186) Fix NPE and container size mismatch
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
Seems like the github sync is lagging. I merged this change about 6 hours ago
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/34#discussion_r103596214
--- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java ---
@@ -50,12 +51,11 @@
private static final Logger LOG = LoggerFactory.getLogger(AbstractYarnAMClient.class);
// Map from a unique ID to inflight requests
- private final Multimap<String, T> containerRequests;
-
- // List of requests pending to send through allocate call
- private final List<T> requests;
+ private final Multimap<String, T> inflightRequests;
+ // Map from a unique ID to pending requests. It is for recording
--- End diff --
Oh. It is for recording the container requests that has yet to be sent to RM. Will update the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #34: (TWILL-186) Fix NPE and container size mismatch
Posted by anwar6953 <gi...@git.apache.org>.
Github user anwar6953 commented on the issue:
https://github.com/apache/twill/pull/34
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #34: (TWILL-186) Fix NPE and container size mismatch
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
I squashed them after getting LGTM to prepare for the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Posted by anwar6953 <gi...@git.apache.org>.
Github user anwar6953 commented on a diff in the pull request:
https://github.com/apache/twill/pull/34#discussion_r103595352
--- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java ---
@@ -50,12 +51,11 @@
private static final Logger LOG = LoggerFactory.getLogger(AbstractYarnAMClient.class);
// Map from a unique ID to inflight requests
- private final Multimap<String, T> containerRequests;
-
- // List of requests pending to send through allocate call
- private final List<T> requests;
+ private final Multimap<String, T> inflightRequests;
+ // Map from a unique ID to pending requests. It is for recording
--- End diff --
It is for recording what?
(incomplete sentence?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #34: (TWILL-186) Fix NPE and container size mismatch
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/34
Hi @chtyim looks like there is only 1 commit for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/twill/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #34: (TWILL-186) Fix NPE and container size mismatch
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/34
Ah ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---