[GitHub] dgrove-oss commented on a change in pull request #107: Daemon set merge

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #107: Daemon set merge
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/107#discussion_r155058690
 
 

 ##########
 File path: kubernetes/invoker/invoker.yml
 ##########
 @@ -1,20 +1,29 @@
 ---
-apiVersion: apps/v1beta1
-kind: StatefulSet
+apiVersion: extensions/v1beta1
+kind: DaemonSet
 
 Review comment:
   I'll open up an issue to discuss further.  As the upstream system is now, using autoscaling isn't a great idea because we are missing the lifecycle methods on the invoker to allow an orderly draining and suspension of the invoker-N topic before the invoker-N pod is removed during scale down.  So scaling down could lose user function invocations.  
   
   The choice of Daemonset vs. deployment is probably also related to which ContainerFactoryProvider implementation is being used and whether OpenWhisk is being deployed to a kube cluster dedicated to running OpenWhisk or if the cluster is also running additional services.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services