[GitHub] [flink] twalthr commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

[GitBox <gi...@apache.org>]

twalthr commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…
URL: https://github.com/apache/flink/pull/8844#issuecomment-510089380
 
 
   @KurtYoung I completely share Fabian's opinion here. The PR is marked as `[table-planner]` but this contribution changes different modules and should have been marked `[table]`. The API breaking changes should be added to a separate commit and more people should have been pinged about this change.
   
   Regarding the change of `sql()`, returning null is always bad API design and leads to potential `NullPointerException`s. I would like to reintroduce the old interfaces. Both can share the same code but validate if the last statement (in a multiline query) is a `SELECT` query or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services