[wicket] branch wicket-8.x updated: WICKET-6869 StalePageException does not refresh page

[mg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mgrigorov pushed a commit to branch wicket-8.x
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/wicket-8.x by this push:
     new 97fcc5b  WICKET-6869 StalePageException does not refresh page
97fcc5b is described below

commit 97fcc5b4e2b72e5c0c8507e12841061fdfdf9771
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
AuthorDate: Fri Mar 19 14:43:33 2021 +0200

    WICKET-6869 StalePageException does not refresh page
    
    Do not lod Wicket internal exceptions in the detach phase.
    Internal exceptions are handled in a special way during the request processing phase. In the detach phase nothing could be done.
    In this particular case StalePageException is being thrown in the RequestLogger.
---
 .../main/java/org/apache/wicket/request/cycle/RequestCycle.java   | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java b/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
index 19a8112..6e75573 100644
--- a/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
+++ b/wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java
@@ -19,6 +19,7 @@ package org.apache.wicket.request.cycle;
 import java.util.Optional;
 
 import org.apache.wicket.Application;
+import org.apache.wicket.IWicketInternalException;
 import org.apache.wicket.MetaDataEntry;
 import org.apache.wicket.MetaDataKey;
 import org.apache.wicket.Page;
@@ -681,7 +682,10 @@ public class RequestCycle implements IRequestCycle, IEventSink
 	 */
 	private void handleDetachException(RuntimeException exception) 
 	{
-		log.error("Error detaching RequestCycle", exception);
+		if (!(exception instanceof IWicketInternalException))
+		{
+			log.error("Error detaching RequestCycle", exception);
+		}
 	}
 
 	/**
@@ -916,4 +920,4 @@ public class RequestCycle implements IRequestCycle, IEventSink
 
 	}
 
-}
\ No newline at end of file
+}