You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/28 08:43:47 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
HyukjinKwon opened a new pull request #30945:
URL: https://github.com/apache/spark/pull/30945
### What changes were proposed in this pull request?
This is kind of a followup of https://github.com/apache/spark/pull/24033.
The first and last usage of that argument `SecurityManager` was removed in https://github.com/apache/spark/pull/24033.
After that, we don't need to pass `SecurityManager` anymore in `Utils.fetchFile` and related code paths.
This PR proposes to remove it out.
### Why are the changes needed?
For better readability of codes.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually complied. GitHub Actions and Jenkins build should test it out as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751661008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38032/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751634700
cc @vanzin, @gaborgsomogyi, @skonto FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751639631
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38027/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751657908
**[Test build #133443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133443/testReport)** for PR 30945 at commit [`6153ec1`](https://github.com/apache/spark/commit/6153ec1f4bfd1a894e27546a20d97702a0522587).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751704986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751641410
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133436/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751639051
**[Test build #133436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133436/testReport)** for PR 30945 at commit [`56e7707`](https://github.com/apache/spark/commit/56e7707c24f77ee534fdcd61b8df3e89627f0877).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751661008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38032/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751910767
Thank you guys!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751704466
**[Test build #133443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133443/testReport)** for PR 30945 at commit [`6153ec1`](https://github.com/apache/spark/commit/6153ec1f4bfd1a894e27546a20d97702a0522587).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751657908
**[Test build #133443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133443/testReport)** for PR 30945 at commit [`6153ec1`](https://github.com/apache/spark/commit/6153ec1f4bfd1a894e27546a20d97702a0522587).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30945:
URL: https://github.com/apache/spark/pull/30945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-752255785
Just gone through and late LGTM. Thanks for notifying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751639051
**[Test build #133436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133436/testReport)** for PR 30945 at commit [`56e7707`](https://github.com/apache/spark/commit/56e7707c24f77ee534fdcd61b8df3e89627f0877).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751641396
**[Test build #133436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133436/testReport)** for PR 30945 at commit [`56e7707`](https://github.com/apache/spark/commit/56e7707c24f77ee534fdcd61b8df3e89627f0877).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751639631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30945: [SPARK-33925][CORE] Remove unused SecurityManager in Utils.fetchFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30945:
URL: https://github.com/apache/spark/pull/30945#issuecomment-751704986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133443/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org