[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #36265:
URL: https://github.com/apache/spark/pull/36265#discussion_r866842272


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala:
##########
@@ -1176,4 +1176,13 @@ class AnalysisSuite extends AnalysisTest with Matchers {
         false)
     }
   }
+
+  test("SPARK-38951: Aggregate aliases override field names in ResolveAggregateFunctions") {
+    assertAnalysisSuccess(parsePlan(
+      s"""
+         |select sum(id) as id
+         |from range(10)
+         |group by id
+         |order by sum(id)""".stripMargin))

Review Comment:
   does this query work on other databases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org