You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/24 16:57:23 UTC

[GitHub] [airflow] mik-laj commented on pull request #13860: Added missing extra field in REST API Connection Endpoint

mik-laj commented on pull request #13860:
URL: https://github.com/apache/airflow/pull/13860#issuecomment-766393850


   @VBhojawala I looked at the ticket you referred to and I understood better the problem we have.
   `/connections/` **should not** return extra field
   `/connections/{conn_id}` **should** return this field
   
   To change that, you have to make changes this line.
   https://github.com/VBhojawala/airflow/blob/b8264e11f926897e34077373888d53909ce18317/airflow/api_connexion/endpoints/connection_endpoint.py#L61
   ```diff
   -    return connection_collection_item_schema.dump(connection)
   +    return connection_schema.dump(connection)
   ```
   I have already mentioned this solution in the ticket before
   https://github.com/apache/airflow/issues/13744#issuecomment-762789676
   https://github.com/apache/airflow/pull/13684#issuecomment-760550566


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org