You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/20 06:35:32 UTC

[GitHub] [iceberg] zhangjun0x01 commented on pull request #1624: extract some common functions to iceberg-core

zhangjun0x01 commented on pull request #1624:
URL: https://github.com/apache/iceberg/pull/1624#issuecomment-712627740


   > I think this makes sense to me, one question though is do we leave "Actions" in the Spark Module? I wouldn't want to break the api there if possible.
   
   The Actions  class involve some non-common functions, so I did not extract Actions. For example, spark Actions need SparkSession, and flink Actions need ExecutionEnvironment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org