You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2013/12/29 05:22:47 UTC
Review Request 16502: Use paths consisently - 3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16502/
-----------------------------------------------------------
Review request for hive, Xuefu Zhang and Xuefu Zhang.
Bugs: HIVE-6116
https://issues.apache.org/jira/browse/HIVE-6116
Repository: hive
Description
-------
Refactor patch.
Diffs
-----
trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1553986
trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java 1553986
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/LineageState.java 1553986
Diff: https://reviews.apache.org/r/16502/diff/
Testing
-------
No new tests. Refactor only patch. Regression suite suffices.
Thanks,
Ashutosh Chauhan
Re: Review Request 16502: Use paths consisently - 3
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16502/#review30993
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Dec. 30, 2013, 6:29 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16502/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2013, 6:29 p.m.)
>
>
> Review request for hive, Xuefu Zhang and Xuefu Zhang.
>
>
> Bugs: HIVE-6116
> https://issues.apache.org/jira/browse/HIVE-6116
>
>
> Repository: hive
>
>
> Description
> -------
>
> Refactor patch.
>
>
> Diffs
> -----
>
> trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554291
> trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java 1554291
> trunk/ql/src/java/org/apache/hadoop/hive/ql/session/LineageState.java 1554291
>
> Diff: https://reviews.apache.org/r/16502/diff/
>
>
> Testing
> -------
>
> No new tests. Refactor only patch. Regression suite suffices.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 16502: Use paths consisently - 3
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16502/
-----------------------------------------------------------
(Updated Dec. 30, 2013, 6:29 p.m.)
Review request for hive, Xuefu Zhang and Xuefu Zhang.
Changes
-------
Same patch as last with tab/spacing corrected. Only whitespace changes.
Bugs: HIVE-6116
https://issues.apache.org/jira/browse/HIVE-6116
Repository: hive
Description
-------
Refactor patch.
Diffs (updated)
-----
trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554291
trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java 1554291
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/LineageState.java 1554291
Diff: https://reviews.apache.org/r/16502/diff/
Testing
-------
No new tests. Refactor only patch. Regression suite suffices.
Thanks,
Ashutosh Chauhan
Re: Review Request 16502: Use paths consisently - 3
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16502/#review30965
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16502/#comment59216>
It would be nice if this can be reformatted: tab/space.
- Xuefu Zhang
On Dec. 29, 2013, 4:22 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16502/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2013, 4:22 a.m.)
>
>
> Review request for hive, Xuefu Zhang and Xuefu Zhang.
>
>
> Bugs: HIVE-6116
> https://issues.apache.org/jira/browse/HIVE-6116
>
>
> Repository: hive
>
>
> Description
> -------
>
> Refactor patch.
>
>
> Diffs
> -----
>
> trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1553986
> trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java 1553986
> trunk/ql/src/java/org/apache/hadoop/hive/ql/session/LineageState.java 1553986
>
> Diff: https://reviews.apache.org/r/16502/diff/
>
>
> Testing
> -------
>
> No new tests. Refactor only patch. Regression suite suffices.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>