You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by RyanFrantz <gi...@git.apache.org> on 2014/08/22 23:47:44 UTC
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
GitHub user RyanFrantz opened a pull request:
https://github.com/apache/trafficserver/pull/104
TS-3036: Added the 'chm' logging field
The 'chm' logging field notes, in the case of a cache hit, if the medium the hit was served from was RAM.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RyanFrantz/trafficserver TS-3036
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit 8f93ddac51cf80ce256612a12325011e90184a10
Author: Ryan Frantz <rf...@etsy.com>
Date: 2014-08-21T01:19:02Z
Adding support for logging which medium was used to serve a cache HIT.
commit b646908884cfcea49ff8c476c0052a5785c066d1
Author: Ryan Frantz <rf...@etsy.com>
Date: 2014-08-21T01:24:37Z
Updated docs for the new 'chm' field.
- 'chm' is the cache hit medium field.
commit 72f302cdf273682874d67b8521bac8ec5d8a6d75
Author: Ryan Frantz <rf...@etsy.com>
Date: 2014-08-22T15:50:12Z
Making further corrections to add support for logging ram cache HITs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-55179361
@zwoop, can you take a look at this and merge if you think it is OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-77974860
Is it possible to log the volume that served the cache response? Right now it seems that you log "-" when it hits disk, but it would be nice if we could know which disk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-55179626
Yeah, I did. My gut reaction is that we ought to have amc chime in on this, to make sure this aligns with future directions re: cache hierarchies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-77976157
That would make sense too, I'm just going off the docs:
```
with a ``chm`` value of
+ ``-`` the medium was disk cache.
```
Seems odd for it to say "ram" and "-"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by RyanFrantz <gi...@git.apache.org>.
Github user RyanFrantz commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-53124539
Per https://issues.apache.org/jira/browse/TS-3036
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-77975742
Hmmm that feels like it'd be a different log tag, no? The intent with this field is to show which cache level we are serving out of, e.g RAM vs rotational disk vs SSD vs cache cluster etc
Not sure why it's logging - when you get a disk hit, that sounds like a big. It should log HIT_DISK. Please reopen the bug if this is not working.
-- Leif
> On Mar 9, 2015, at 5:40 PM, Thomas Jackson <no...@github.com> wrote:
>
> Is it possible to log the volume that served the cache response? Right now it seems that you log "-" when it hits disk, but it would be nice if we could know which disk.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-82027946
@zwoop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3036: Added the 'chm' logging field
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/104#issuecomment-55179815
Ok, I was confused by the parallel discussion in the Jira ticket. What sayeth thou @SolidWallOfCode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---