[jira] [Commented] (HADOOP-12746) ReconfigurableBase should update the cached configuration

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135377#comment-15135377 ] 

ASF GitHub Bot commented on HADOOP-12746:
-----------------------------------------

GitHub user arp7 opened a pull request:

    https://github.com/apache/hadoop/pull/73

    HADOOP-12746. ReconfigurableBase should update the cached configuration

    Initial patch to have ReconfigurableBase#ReconfigurationThread update parent's cached configuration.
    
    The effective value may be different from the passed in newVal so this patch also updates ReconfigurableBase#reconfigurePropertyImpl to return the effective config value. This idea was suggested by [~eddyxu] on https://issues.apache.org/jira/secure/EditComment!default.jspa?id=12740232&commentId=15118434
    
    Will likely add more unit tests for this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arp7/hadoop HADOOP-12476

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 942b4eecbb344549f5ad3d16e97e83a381ef960c
Author: Arpit Agarwal <ar...@apache.org>
Date:   2016-02-06T00:54:02Z

    HADOOP-12746. ReconfigurableBase should update the cached configuration

----


> ReconfigurableBase should update the cached configuration
> ---------------------------------------------------------
>
>                 Key: HADOOP-12746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12746
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>
> {{ReconfigurableBase}} does not always update the cached configuration after a property is reconfigured.
> The older {{#reconfigureProperty}} does so however {{ReconfigurationThread}} does not.
> See discussion on HDFS-7035 for more background.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)