[GitHub] [solr] dsmiley commented on a diff in pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1155160754


##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -370,6 +380,12 @@ public TopDocs searchNearestVectors(
     return null;
   }
 
+  @Override
+  public TopDocs searchNearestVectors(
+      String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) throws IOException {
+    return null;

Review Comment:
   returning null is a lie; shouldn't we throw UnsupportedOperationException?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org