You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rp...@apache.org on 2016/11/20 13:11:39 UTC
logging-log4j2 git commit: removed old design review comments from
Message javadoc
Repository: logging-log4j2
Updated Branches:
refs/heads/master 666795d0e -> 25f06d9e2
removed old design review comments from Message javadoc
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/25f06d9e
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/25f06d9e
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/25f06d9e
Branch: refs/heads/master
Commit: 25f06d9e2d4be85934e695a8b6a67183cbac2d80
Parents: 666795d
Author: rpopma <rp...@apache.org>
Authored: Sun Nov 20 22:11:30 2016 +0900
Committer: rpopma <rp...@apache.org>
Committed: Sun Nov 20 22:11:30 2016 +0900
----------------------------------------------------------------------
.../main/java/org/apache/logging/log4j/message/Message.java | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/25f06d9e/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
index 30d7aca..9c9aca9 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
@@ -30,17 +30,13 @@ import org.apache.logging.log4j.util.StringBuilderFormattable;
* {@link StringBuilderFormattable#formatTo(StringBuilder) formatTo(StringBuilder)} instead of
* {@link Message#getFormattedMessage()} if the Message implements StringBuilderFormattable.
* </p>
- *<p>
+ * <p>
* Note: Message objects should not be considered to be thread safe nor should they be assumed to be
* safely reusable even on the same thread. The logging system may provide information to the Message
* objects and the Messages might be queued for asynchronous delivery. Thus, any modifications to a
* Message object by an application should by avoided after the Message has been passed as a parameter on
* a Logger method.
* </p>
- * TODO Interfaces should rarely extend Serializable according to Effective Java 2nd Ed pg 291.
- * (RG) That section also says "If a class or interface exists primarily to participate in a framework that
- * requires all participants to implement Serializable, then it makes perfect sense for the class or
- * interface to implement or extend Serializable". Such is the case here as the LogEvent must be Serializable.
*
* @see StringBuilderFormattable
*/