You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/02/16 23:08:41 UTC

Review Request 31098: RU: Review +clean messages for manual steps to be more specific

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31098/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Bugs: AMBARI-9668
    https://issues.apache.org/jira/browse/AMBARI-9668


Repository: ambari


Description
-------

* Changed text in upgrade-2.2.xml.  The text is not actually mine, it was crafted by PM (don't shoot the messenger)
* Fixed case where service display name was not shown correctly for service check tasks.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java a9732d2 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 5305b1f 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java a708dac 

Diff: https://reviews.apache.org/r/31098/diff/


Testing
-------

Pending


Thanks,

Nate Cole


Re: Review Request 31098: RU: Review +clean messages for manual steps to be more specific

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31098/#review72662
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Feb. 16, 2015, 11:06 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31098/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 11:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9668
>     https://issues.apache.org/jira/browse/AMBARI-9668
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changed text in upgrade-2.2.xml.  The text is not actually mine, it was crafted by PM (don't shoot the messenger)
> * Fixed case where service display name was not shown correctly for service check tasks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java a9732d2 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 5305b1f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java a708dac 
> 
> Diff: https://reviews.apache.org/r/31098/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2692, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:36.130s
> [INFO] Finished at: Mon Feb 16 17:24:44 EST 2015
> [INFO] Final Memory: 39M/867M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31098: RU: Review +clean messages for manual steps to be more specific

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31098/#review72668
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Feb. 16, 2015, 6:06 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31098/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 6:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9668
>     https://issues.apache.org/jira/browse/AMBARI-9668
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Changed text in upgrade-2.2.xml.  The text is not actually mine, it was crafted by PM (don't shoot the messenger)
> * Fixed case where service display name was not shown correctly for service check tasks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java a9732d2 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 5305b1f 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java a708dac 
> 
> Diff: https://reviews.apache.org/r/31098/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 2692, Failures: 0, Errors: 0, Skipped: 15
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:36.130s
> [INFO] Finished at: Mon Feb 16 17:24:44 EST 2015
> [INFO] Final Memory: 39M/867M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31098: RU: Review +clean messages for manual steps to be more specific

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31098/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 6:06 p.m.)


Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Changes
-------

Updated test results


Bugs: AMBARI-9668
    https://issues.apache.org/jira/browse/AMBARI-9668


Repository: ambari


Description
-------

* Changed text in upgrade-2.2.xml.  The text is not actually mine, it was crafted by PM (don't shoot the messenger)
* Fixed case where service display name was not shown correctly for service check tasks.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java a9732d2 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 5305b1f 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java a708dac 

Diff: https://reviews.apache.org/r/31098/diff/


Testing (updated)
-------

Tests run: 2692, Failures: 0, Errors: 0, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:36.130s
[INFO] Finished at: Mon Feb 16 17:24:44 EST 2015
[INFO] Final Memory: 39M/867M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole