You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2016/05/23 16:29:13 UTC
[jira] [Commented] (SLING-5743) Move Standard Injectors and
Injector-Specific Annotations to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296599#comment-15296599 ]
Justin Edelson commented on SLING-5743:
---------------------------------------
It turns out this is harder than I thought because the class `org.apache.sling.models.annotations.injectorspecific.InjectoryStrategy` is really part of the SPI, but is in the wrong package. Short of split packages, I don't see a way around this.
> Move Standard Injectors and Injector-Specific Annotations to separate bundle
> ----------------------------------------------------------------------------
>
> Key: SLING-5743
> URL: https://issues.apache.org/jira/browse/SLING-5743
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Reporter: Justin Edelson
> Assignee: Justin Edelson
>
> It has become clear (at least to me) that putting the standard injectors in the org.apache.sling.models.impl bundle was an error and that error was compounded by adding the injector-specific annotations into the API bundle. These really belong in a separate bundle which can be versioned and released independently of the core bundles. As this change is kind of a pain to do as a patch submission, I'm just going to summarize the changes here:
> 1. Create new bundle: org.apache.sling.models.stdlib
> 2. Move package org.apache.sling.models.impl.injectors to this bundle (from org.apache.sling.models.impl). Also move corresponding unit tests which purely test the injectors (and not the framework).
> 3. Move package org.apache.sling.models.annotations.injectorspecific to this bundle (from org.apache.sling.models.api). Exported version of org.apache.sling.models.annotations.injectorspecific will remain the same.
> 4. org.apache.sling.models.impl project will depend upon stdlib project in test scope for the purpose of existing unit tests.
> 5. Minimize dependencies of impl package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)