DummyFormUtils extendability

[Emond Papegaaij <e....@emaxx.nl>]

Hello,

During the development of a framework based on Struts and JSF (using the 
struts-faces integration library) I came accross a problem with 
DummyFormUtils. The current way DymmyFormUtils is handled does not allow the 
developer to extend the behaviour in any way. For the struts-faces library a 
token field needs to be added to the form. This token always needs to be 
submitted, regardless of the form used (input or dummy). Currently the only 
way of adding such a field seems to be changing the source of DummyFormUtils; 
not a very flexible and reusable solution.

The main cause of this is the use of a static method for writing the dummy 
form and the lack of a factory for creating an instance of the 
DummyFormUtils. I propose DummyFormUtils is transformed into a singleton with 
a configurable implementation (probably through an interface). Futhermore the 
writeDummyForm should have a way of extending the default behaviour, probably 
with a protected method responsible for writing the internals of the form.

As I'm still fairly new to the MyFaces, I could be missing something. Please 
correct me if I'm mistaken. If there is indeed no way of extending 
DummyFormUtils, I can start working on a patch. Do I have to open a bug 
report for this? Should I wait until after the SVN reorganisation?

Best regards,
Emond Papegaaij

Re: DummyFormUtils extendability

[Manfred Geiler <ma...@gmail.com>]

yes, please open a jira issue on this.
(just paste in your email)

thanks,
Manfred

2005/6/28, Emond Papegaaij <e....@emaxx.nl>:
> Hello,
> 
> During the development of a framework based on Struts and JSF (using the
> struts-faces integration library) I came accross a problem with
> DummyFormUtils. The current way DymmyFormUtils is handled does not allow the
> developer to extend the behaviour in any way. For the struts-faces library a
> token field needs to be added to the form. This token always needs to be
> submitted, regardless of the form used (input or dummy). Currently the only
> way of adding such a field seems to be changing the source of DummyFormUtils;
> not a very flexible and reusable solution.
> 
> The main cause of this is the use of a static method for writing the dummy
> form and the lack of a factory for creating an instance of the
> DummyFormUtils. I propose DummyFormUtils is transformed into a singleton with
> a configurable implementation (probably through an interface). Futhermore the
> writeDummyForm should have a way of extending the default behaviour, probably
> with a protected method responsible for writing the internals of the form.
> 
> As I'm still fairly new to the MyFaces, I could be missing something. Please
> correct me if I'm mistaken. If there is indeed no way of extending
> DummyFormUtils, I can start working on a patch. Do I have to open a bug
> report for this? Should I wait until after the SVN reorganisation?
> 
> Best regards,
> Emond Papegaaij
>