You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ripple.apache.org by br...@apache.org on 2013/07/08 23:00:08 UTC

[01/28] git commit: Fixed touchend touches and targetTouches

Updated Branches:
  refs/heads/master ffef19905 -> 007fbd578


Fixed touchend touches and targetTouches

updated returned values for touches and targetTouches to return
empty arrays as per spec.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/dfdf1f74
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/dfdf1f74
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/dfdf1f74

Branch: refs/heads/master
Commit: dfdf1f74ea1d02ce5ba128561ba970efa8e0d7cf
Parents: ffef199
Author: Dan Silivestru <da...@gmail.com>
Authored: Thu May 30 12:04:53 2013 -0400
Committer: Dan Silivestru <da...@gmail.com>
Committed: Thu May 30 12:04:53 2013 -0400

----------------------------------------------------------------------
 lib/client/touchEventEmulator.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/dfdf1f74/lib/client/touchEventEmulator.js
----------------------------------------------------------------------
diff --git a/lib/client/touchEventEmulator.js b/lib/client/touchEventEmulator.js
index 18ac922..8020243 100644
--- a/lib/client/touchEventEmulator.js
+++ b/lib/client/touchEventEmulator.js
@@ -57,8 +57,8 @@ function _simulateTouchEvent(type, mouseevent) {
         shiftKey: mouseevent.shiftKey,
         metaKey: mouseevent.metaKey,
         changedTouches: [touchObj],
-        targetTouches: [touchObj],
-        touches: [touchObj]
+        targetTouches: type === "touchend" ? [] : [touchObj],
+        touches: type === "touchend" ? [] : [touchObj]
     };
 
     utils.mixin(touchObj, eventData);


[03/28] git commit: Remove unused variable

Posted by br...@apache.org.
Remove unused variable


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/24007e4b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/24007e4b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/24007e4b

Branch: refs/heads/master
Commit: 24007e4bd6f9eb6b8b01326d3df5f143a5ec0d6b
Parents: 21843f2
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:38:05 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:28 2013 -0400

----------------------------------------------------------------------
 targets/rim.chrome.extension/controllers/Background.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/24007e4b/targets/rim.chrome.extension/controllers/Background.js
----------------------------------------------------------------------
diff --git a/targets/rim.chrome.extension/controllers/Background.js b/targets/rim.chrome.extension/controllers/Background.js
index 5ec56be..537f34b 100644
--- a/targets/rim.chrome.extension/controllers/Background.js
+++ b/targets/rim.chrome.extension/controllers/Background.js
@@ -61,7 +61,7 @@ tinyHippos.Background = (function () {
         xhr.send();
 
         chrome.extension.onRequest.addListener(function (request, sender, sendResponse) {
-            var xhr, postData, data, plugini, eula;
+            var xhr, postData, data, eula;
             switch (request.action) {
             case "isEnabled":
                 console.log("isEnabled? ==> " + request.tabURL);


[22/28] git commit: `ripple emulate` should allow static server to 404 if html is not found.

Posted by br...@apache.org.
`ripple emulate` should allow static server to 404 if html is not found.

Fixes: https://issues.apache.org/jira/browse/RIPPLE-10


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/eb098f2a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/eb098f2a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/eb098f2a

Branch: refs/heads/master
Commit: eb098f2aa27486a1bf6c13d0e457060981f13c10
Parents: 9195afc
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Jun 25 12:39:54 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 17:22:57 2013 -0400

----------------------------------------------------------------------
 lib/server/emulate/hosted.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/eb098f2a/lib/server/emulate/hosted.js
----------------------------------------------------------------------
diff --git a/lib/server/emulate/hosted.js b/lib/server/emulate/hosted.js
index 63e4527..ab8d6f0 100644
--- a/lib/server/emulate/hosted.js
+++ b/lib/server/emulate/hosted.js
@@ -149,7 +149,11 @@ function localInjection(opts) {
                 return fs.existsSync(file) ? file : match;
             }, null);
 
-            inject(fullPath, req, res);
+            if (fullPath) {
+                inject(fullPath, req, res);
+            } else {
+                next();
+            }
         } else {
             next();
         }


[15/28] git commit: Spelling: hamster

Posted by br...@apache.org.
Spelling: hamster


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/90b94b55
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/90b94b55
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/90b94b55

Branch: refs/heads/master
Commit: 90b94b55440df4bd6b0c367eeb95ccdbc92bc408
Parents: a3ed264
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:07:50 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:35 2013 -0400

----------------------------------------------------------------------
 test/unit/client/platform.builder.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/90b94b55/test/unit/client/platform.builder.js
----------------------------------------------------------------------
diff --git a/test/unit/client/platform.builder.js b/test/unit/client/platform.builder.js
index a084e0a..95acdab 100644
--- a/test/unit/client/platform.builder.js
+++ b/test/unit/client/platform.builder.js
@@ -165,7 +165,7 @@ describeBrowser("platform builder", function () {
 
         spyOn(app, "getInfo").andReturn({
             features: {
-                hampsters: {}
+                hamsters: {}
             }
         });
 
@@ -174,7 +174,7 @@ describeBrowser("platform builder", function () {
                 feature: "chickens",
                 children: {
                     bar: {
-                        feature: "hampsters"
+                        feature: "hamsters"
                     }
                 }
             }
@@ -197,7 +197,7 @@ describeBrowser("platform builder", function () {
                 feature: "chickens",
                 children: {
                     Smith: {
-                        feature: "hampsters"
+                        feature: "hamsters"
                     }
                 }
             }


[20/28] git commit: This ASF license declaration should not be cropped.

Posted by br...@apache.org.
This ASF license declaration should not be cropped.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/ad17f979
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/ad17f979
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/ad17f979

Branch: refs/heads/master
Commit: ad17f979860798ed8c9375e01fd70933da111025
Parents: 896f2cc
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Jun 25 16:06:24 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Tue Jun 25 16:06:24 2013 -0400

----------------------------------------------------------------------
 build/whitespace.js | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/ad17f979/build/whitespace.js
----------------------------------------------------------------------
diff --git a/build/whitespace.js b/build/whitespace.js
index 9c5816d..653f0f5 100644
--- a/build/whitespace.js
+++ b/build/whitespace.js
@@ -1,19 +1,19 @@
 /*
- * Licensed to the Apache Software Foundation (ASF
- * or more contributor license agreements.  See th
- * distributed with this work for additional infor
- * regarding copyright ownership.  The ASF license
- * to you under the Apache License, Version 2.0 (t
- * "License"); you may not use this file except in
- * with the License.  You may obtain a copy of the
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
  *
  *   http://www.apache.org/licenses/LICENSE-2.0
  *
- * Unless required by applicable law or agreed to
- * software distributed under the License is distr
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
- * KIND, either express or implied.  See the Licen
- * specific language governing permissions and lim
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
  * under the License.
  *
  * courtesy of incubator-cordova-js


[10/28] git commit: Spelling: dialog

Posted by br...@apache.org.
Spelling: dialog


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/5e15b634
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/5e15b634
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/5e15b634

Branch: refs/heads/master
Commit: 5e15b634a6158fcdf9f8cee6f0100773bdacf308
Parents: 7241dc4
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:46:21 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:32 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/5e15b634/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index cd265bd..862db7e 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -175,7 +175,7 @@ pull request can be found here: https://github.com/blackberry/Ripple-UI/pull/563
 
 * Added whitelisting support for blackberry.event event registration
 * Added support for window.orientation for WebWorks
-* Updated blackberry.ui.dialoge to async
+* Updated blackberry.ui.dialog to async
 * Added support for network connection type for WebWorks BB10
 * Added support for connectionchange event for WebWorks BB10
 * Added support for blackberry.device.version for WebWorks BB10


[17/28] git commit: Spelling: with

Posted by br...@apache.org.
Spelling: with


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/39f44b69
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/39f44b69
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/39f44b69

Branch: refs/heads/master
Commit: 39f44b69a31ced48c1bf61994199c8e14bdbc6ba
Parents: 9cf11e5
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:47:08 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:36 2013 -0400

----------------------------------------------------------------------
 test/unit/client/cordova/notification.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/39f44b69/test/unit/client/cordova/notification.js
----------------------------------------------------------------------
diff --git a/test/unit/client/cordova/notification.js b/test/unit/client/cordova/notification.js
index 54418a8..2aaf226 100644
--- a/test/unit/client/cordova/notification.js
+++ b/test/unit/client/cordova/notification.js
@@ -38,7 +38,7 @@ describe("Cordova 2.0.0 Notification Bridge", function () {
             expect(notification.alert).toThrow();
         });
 
-        it("can be called wihtout specifying an error callback", function () {
+        it("can be called without specifying an error callback", function () {
             notification.alert(s, null, ["Test notification"]);
             expect(notifications.openNotification).toHaveBeenCalled();
             expect(notifications.openNotification.mostRecentCall.args[1]).toEqual("Test notification");


[09/28] git commit: Spelling: async

Posted by br...@apache.org.
Spelling: async


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/d35c543d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/d35c543d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/d35c543d

Branch: refs/heads/master
Commit: d35c543da654515aea7baa018cd92a071b79db79
Parents: 4483a23
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:34:20 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:31 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/d35c543d/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index 5315092..b2e51d6 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -175,7 +175,7 @@ pull request can be found here: https://github.com/blackberry/Ripple-UI/pull/563
 
 * Added whitelisting support for blackberry.event event registration
 * Added support for window.orientation for WebWorks
-* Updated blackberry.ui.dialoge to asynch
+* Updated blackberry.ui.dialoge to async
 * Added support for network connection type for WebWorks BB10
 * Added support for connectionchange event for WebWorks BB10
 * Added support for blackberry.device.version for WebWorks BB10


[24/28] git commit: The PATCH HTTP method is not supported by the XHR proxy.

Posted by br...@apache.org.
The PATCH HTTP method is not supported by the XHR proxy.

Fixes: https://issues.apache.org/jira/browse/RIPPLE-27


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/eac1bc6e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/eac1bc6e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/eac1bc6e

Branch: refs/heads/master
Commit: eac1bc6ea9daeef90eb27395a1225ed70fcc58ea
Parents: dc12603
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Jun 25 16:54:47 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 17:28:29 2013 -0400

----------------------------------------------------------------------
 lib/server/proxy.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/eac1bc6e/lib/server/proxy.js
----------------------------------------------------------------------
diff --git a/lib/server/proxy.js b/lib/server/proxy.js
index 2419920..70ce9d8 100644
--- a/lib/server/proxy.js
+++ b/lib/server/proxy.js
@@ -142,7 +142,7 @@ function jsonpXHRProxyHandler(req, res/*, next*/) {
 function start(options, app) {
     var corsOptions = {
         origins: ["*"],
-        methods: ['HEAD', 'GET', 'POST', 'PUT', 'DELETE', 'OPTIONS', 'TRACE', 'CONNECT'],
+        methods: ['HEAD', 'GET', 'POST', 'PUT', 'DELETE', 'OPTIONS', 'TRACE', 'CONNECT', 'PATCH'],
         credentials: true,
         headers: []
     };


[21/28] git commit: RIPPLE-26 Fixing Contacts API for correct functioning with cordova versions later than 2.2.0

Posted by br...@apache.org.
RIPPLE-26 Fixing Contacts API for correct functioning with cordova versions later than 2.2.0


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/9195afc7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/9195afc7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/9195afc7

Branch: refs/heads/master
Commit: 9195afc73535d2fbb348ef0bce1c88cfac7694c6
Parents: ad17f97
Author: Ilya Buziuk <ib...@exadel.com>
Authored: Tue Jun 18 14:17:04 2013 +0300
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 14:51:02 2013 -0400

----------------------------------------------------------------------
 lib/client/platform/cordova/2.0.0/bridge/contacts.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/9195afc7/lib/client/platform/cordova/2.0.0/bridge/contacts.js
----------------------------------------------------------------------
diff --git a/lib/client/platform/cordova/2.0.0/bridge/contacts.js b/lib/client/platform/cordova/2.0.0/bridge/contacts.js
index 16fd76b..6424f0c 100644
--- a/lib/client/platform/cordova/2.0.0/bridge/contacts.js
+++ b/lib/client/platform/cordova/2.0.0/bridge/contacts.js
@@ -20,6 +20,7 @@
  */
 var db = ripple('db'),
     utils = ripple('utils'),
+    emulatorBridge = ripple('emulatorBridge'),
     _self;
 
 function _default() {
@@ -45,13 +46,13 @@ function _default() {
         "emails": [{type: "work", value: "mark@tinyhippos.com", pref: false}]
     }].map(function (obj) {
         obj.id = Math.uuid(undefined, 16);
-        return navigator.contacts.create(obj);
+        return emulatorBridge.window().navigator.contacts.create(obj);
     });
 }
 
 function _get() {
     var contacts = db.retrieveObject("cordova-contacts");
-    if (!contacts) {
+    if (!contacts) {
         contacts = _default();
         _save(contacts);
     }
@@ -85,7 +86,7 @@ _self = {
         var fields = args[0],
             options = args[1],
             foundContacts = [],
-            tempContact = navigator.contacts.create(),
+            tempContact = emulatorBridge.window().navigator.contacts.create(),
             contacts = _get();
 
         options = options || {};
@@ -99,7 +100,7 @@ _self = {
 
         if (fields.length > 0) {
             contacts.forEach(function (contact) {
-                var newContact = navigator.contacts.create(contact);
+                var newContact = emulatorBridge.window().navigator.contacts.create(contact);
 
                 if (options && (!_filtered(contact, options))) {
                     return;


[04/28] git commit: Spelling: [Code Fix] status

Posted by br...@apache.org.
Spelling: [Code Fix] status


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/21843f22
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/21843f22
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/21843f22

Branch: refs/heads/master
Commit: 21843f2270a5fbc19125db0a0765c4c79422306e
Parents: 6b92b52
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:43:42 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:28 2013 -0400

----------------------------------------------------------------------
 lib/server/proxy.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/21843f22/lib/server/proxy.js
----------------------------------------------------------------------
diff --git a/lib/server/proxy.js b/lib/server/proxy.js
index d2ee2f8..2419920 100644
--- a/lib/server/proxy.js
+++ b/lib/server/proxy.js
@@ -124,7 +124,7 @@ function jsonpXHRProxyHandler(req, res/*, next*/) {
     proxy(req, res, function callback(response, body) {
         var reqData = {
             headers: response.headers,
-            status: response.satusCode,
+            status: response.statusCode,
             response: body
         };
 


[11/28] git commit: Spelling: divided

Posted by br...@apache.org.
Spelling: divided


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/7241dc45
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/7241dc45
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/7241dc45

Branch: refs/heads/master
Commit: 7241dc4511f41fa2182034470d75838ea016d358
Parents: df74d5e
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:45:29 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:32 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/7241dc45/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index 1c12d37..cd265bd 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -10,7 +10,7 @@
 * Added support for serve app from multiple folders
 * Fixed browser tests to run again
 * added device selection to enableRipple qs param
-* Skinned devices now have ther size devided by the css pixel ratio
+* Skinned devices now have ther size divided by the css pixel ratio
 
 ## v0.9.15 - March 08, 2013
 


[05/28] git commit: Brand: Care Bear

Posted by br...@apache.org.
Brand: Care Bear


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/0c233ba5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/0c233ba5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/0c233ba5

Branch: refs/heads/master
Commit: 0c233ba5f72c3031e677f50ca2efd3a1004ea1d2
Parents: 24007e4
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:39:41 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:29 2013 -0400

----------------------------------------------------------------------
 test/unit/client/console.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/0c233ba5/test/unit/client/console.js
----------------------------------------------------------------------
diff --git a/test/unit/client/console.js b/test/unit/client/console.js
index 438d2e7..b281539 100644
--- a/test/unit/client/console.js
+++ b/test/unit/client/console.js
@@ -62,8 +62,8 @@ describe("console", function () {
 
         it("uses the prefix when erroring", function () {
             spyOn(console, "error");
-            _console.error("Carebears Stare");
-            expect(console.error).toHaveBeenCalledWith("PLATFORM :: Carebears Stare");
+            _console.error("Care Bear Stare");
+            expect(console.error).toHaveBeenCalledWith("PLATFORM :: Care Bear Stare");
         });
 
         it("uses the prefix when warning", function () {


[26/28] git commit: Small code cleanup (tabbing alignment, odd chars at end of lines).

Posted by br...@apache.org.
Small code cleanup (tabbing alignment, odd chars at end of lines).


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/8f64f68f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/8f64f68f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/8f64f68f

Branch: refs/heads/master
Commit: 8f64f68fd30f844ee9f5f0f9e0f09301ca3c3b98
Parents: 6452ff0
Author: Brent Lintner <br...@gmail.com>
Authored: Fri Jul 5 18:23:39 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 18:23:39 2013 -0400

----------------------------------------------------------------------
 test/unit/client/cordova/contacts.js | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/8f64f68f/test/unit/client/cordova/contacts.js
----------------------------------------------------------------------
diff --git a/test/unit/client/cordova/contacts.js b/test/unit/client/cordova/contacts.js
index 5a02464..f5e4823 100644
--- a/test/unit/client/cordova/contacts.js
+++ b/test/unit/client/cordova/contacts.js
@@ -21,31 +21,31 @@
 describe("Cordova Contacts Bridge", function () {
     var contacts = ripple('platform/cordova/2.0.0/bridge/contacts'),
         emulatorBridge = ripple('emulatorBridge'),
-    db = ripple('db'),
-    contact = {
-        "name": { formatted: "Mark Dineen" },
-        "id": Math.uuid(undefined, 16),
-        "displayName": "Mark Dineen",
-        "emails": [{ type: "work", value: "mddineen@gmail.com", pref: false }]
-    },
-    s,
-    e,
-    _default = [{
+        db = ripple('db'),
+        contact = {
+            "name": { formatted: "Mark Dineen" },
+            "id": Math.uuid(undefined, 16),
+            "displayName": "Mark Dineen",
+            "emails": [{ type: "work", value: "mddineen@gmail.com", pref: false }]
+        },
+        s,
+        e,
+        _default = [{
             "name": { formatted: "Brent Lintner" },
             "displayName": "Brent Lintner",
-            "emails": [{ type: "work", value: "brent@tinyhippos.com", pref: false }]
+            "emails": [{ type: "work", value: "brent@tinyhippos.com", pref: false }]
         }, {
             "name": { formatted: "PJ Lowe" },
             "displayName": "PJ Lowe",
-            "emails": [{ type: "work", value: "pj@tinyhippos.com", pref: false }]
+            "emails": [{ type: "work", value: "pj@tinyhippos.com", pref: false }]
         }, {
             "name": { formatted: "Dan Silivestru" },
             "displayName": "Dan Silivestru",
-            "emails": [{ type: "work", value: "dan@tinyhippos.com", pref: false }]
+            "emails": [{ type: "work", value: "dan@tinyhippos.com", pref: false }]
         }, {
             "name": { formatted: "Gord Tanner" },
             "displayName": "Gord Tanner",
-            "emails": [{ type: "work", value: "gord@tinyhippos.com", pref: true }]
+            "emails": [{ type: "work", value: "gord@tinyhippos.com", pref: true }]
         }, {
             "name": { formatted: "Mark McArdle" },
             "displayName": "Mark McArdle",


[12/28] git commit: Spelling: distribution

Posted by br...@apache.org.
Spelling: distribution


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/59ed2dbc
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/59ed2dbc
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/59ed2dbc

Branch: refs/heads/master
Commit: 59ed2dbc45466a8e8da7b07b212034937515c239
Parents: 5e15b63
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:46:56 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:33 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/59ed2dbc/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index 862db7e..a64caf4 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -64,7 +64,7 @@ Pull Request (for release commits): https://github.com/blackberry/Ripple-UI/pull
 * Fixed Ripple sending bad Accept (or other) headers to servers (in BlackBerry distribution of Ripple)
 * Fixed the Accelerometer UI when it would stop modifying Alpha values after resetting all values (by double clicking on the UI)
 * Fixed the sizing of the image (overlay) that shows up after selecting image (for an emulated Camera capture call) to fit inside the overlay window
-* Fixed the platform selection page that shows up at first run displaying over top of the EULA (in the BlackBerry distrobution)
+* Fixed the platform selection page that shows up at first run displaying over top of the EULA (in the BlackBerry distribution)
 * Updated the "Stay On This Page" dialog to only show up when page enters reload loop (vs every refresh)
 
 * WebWorks BB10


[08/28] git commit: Spelling: deprecated

Posted by br...@apache.org.
Spelling: deprecated


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/df74d5ec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/df74d5ec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/df74d5ec

Branch: refs/heads/master
Commit: df74d5ec6a626e85bd1312e6fd5017845e0e0c98
Parents: d35c543
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:43:15 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:31 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/df74d5ec/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index b2e51d6..1c12d37 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -34,7 +34,7 @@ Pull Request (for release commits): https://github.com/blackberry/Ripple-UI/pull
 * Added support for Blackberry Q10 device
 * Added support for OPTIONS verb for Cross Origin Proxy
 * Added JavaScript console clearing prior to bootup (Chrome v23+ only)
-* Fixed blobBuilder being depricated (community contribution by @maxme)
+* Fixed blobBuilder being deprecated (community contribution by @maxme)
 
 ## v0.9.12 - January 14, 2013
 


[28/28] git commit: Bump version/changelog to 0.9.18 (tagging master).

Posted by br...@apache.org.
Bump version/changelog to 0.9.18 (tagging master).


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/007fbd57
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/007fbd57
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/007fbd57

Branch: refs/heads/master
Commit: 007fbd5780143f40e1cb7262d78dd37f5e9af935
Parents: 1ebd828
Author: Brent Lintner <br...@gmail.com>
Authored: Mon Jul 8 16:30:01 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Mon Jul 8 16:51:23 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 11 +++++++++++
 package.json     |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/007fbd57/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index a64caf4..b159c71 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -1,3 +1,14 @@
+## v0.9.18 - July 8, 2013
+
+Pre-install script (on Windows) causes failure to install via npm
+The PATCH HTTP method is not supported by the XHR proxy
+`ripple emulate` should allow static server to 404 if html is not found
+Fixing Contacts API for correct functioning with cordova versions later than 2.2.0
+Implemented confirm function in notification js for Cordova
+Fixed touchend touches and targetTouches
+Fixed `response` spelling in JSONP XHR proxy
+General spelling fixes
+
 ## v0.9.17 - May 30, 2013
 
 * Fixed Ripple load bug for default load param in CLI

http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/007fbd57/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index c9d9e06..b6acd87 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ripple-emulator",
-  "version": "0.9.17",
+  "version": "0.9.18",
   "description": "A browser based html5 mobile application development and testing tool",
   "homepage": "http://ripple.incubator.apache.org/",
   "author": {


[18/28] git commit: Spelling: response

Posted by br...@apache.org.
Spelling: response


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/9cf11e51
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/9cf11e51
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/9cf11e51

Branch: refs/heads/master
Commit: 9cf11e511528ab36e37f9a70b8bb36e6fb0e7d5f
Parents: 9127f3b
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:42:28 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:36 2013 -0400

----------------------------------------------------------------------
 lib/client/xhr/base.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/9cf11e51/lib/client/xhr/base.js
----------------------------------------------------------------------
diff --git a/lib/client/xhr/base.js b/lib/client/xhr/base.js
index f478b89..1674a96 100644
--- a/lib/client/xhr/base.js
+++ b/lib/client/xhr/base.js
@@ -44,7 +44,7 @@ function _writeable(obj) {
 
     // need prototypes
     for (key in obj) {
-        //HACK: don't even know what to say bout this, resonseBlob can go fly a kite: related to this issue:
+        //HACK: don't even know what to say bout this, responseBlob can go fly a kite: related to this issue:
         //https://github.com/blackberry/Ripple-UI/issues/394
         if (key !== "responseBlob" && typeof obj[key] === "function") {
             newObj[key] = _handle(obj, key);


[13/28] git commit: Spelling: failed

Posted by br...@apache.org.
Spelling: failed


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/a3ed2640
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/a3ed2640
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/a3ed2640

Branch: refs/heads/master
Commit: a3ed2640cff8741784e3ab2add9298011c6fdb2d
Parents: 0334ac1
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:51:29 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:34 2013 -0400

----------------------------------------------------------------------
 lib/client/ui/plugins/settings-dialog.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/a3ed2640/lib/client/ui/plugins/settings-dialog.js
----------------------------------------------------------------------
diff --git a/lib/client/ui/plugins/settings-dialog.js b/lib/client/ui/plugins/settings-dialog.js
index 58bff89..21a5330 100644
--- a/lib/client/ui/plugins/settings-dialog.js
+++ b/lib/client/ui/plugins/settings-dialog.js
@@ -506,7 +506,7 @@ _self = {
                 poll(resp);
             },
             function (error) {
-                var message = "Build request failded with message: " + error.data;
+                var message = "Build request failed with message: " + error.data;
 
                 if (error.code === 0 || error.code === 404) {
                     message += "<br>This could be due to the Build and Deploy services not running or not being installed";


[25/28] git commit: There were some failing tests.

Posted by br...@apache.org.
There were some failing tests.

This was missed in a recent bug fix commit.
Not a red flag. Just needs a mock/spy change.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/6452ff04
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/6452ff04
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/6452ff04

Branch: refs/heads/master
Commit: 6452ff040d2025032db0ac5832aaa868e99d1764
Parents: eac1bc6
Author: Brent Lintner <br...@gmail.com>
Authored: Fri Jul 5 18:21:33 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 18:21:33 2013 -0400

----------------------------------------------------------------------
 test/unit/client/cordova/contacts.js | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/6452ff04/test/unit/client/cordova/contacts.js
----------------------------------------------------------------------
diff --git a/test/unit/client/cordova/contacts.js b/test/unit/client/cordova/contacts.js
index 58ed818..5a02464 100644
--- a/test/unit/client/cordova/contacts.js
+++ b/test/unit/client/cordova/contacts.js
@@ -20,6 +20,7 @@
  */
 describe("Cordova Contacts Bridge", function () {
     var contacts = ripple('platform/cordova/2.0.0/bridge/contacts'),
+        emulatorBridge = ripple('emulatorBridge'),
     db = ripple('db'),
     contact = {
         "name": { formatted: "Mark Dineen" },
@@ -48,25 +49,22 @@ describe("Cordova Contacts Bridge", function () {
         }, {
             "name": { formatted: "Mark McArdle" },
             "displayName": "Mark McArdle",
-            "emails": [{ type: "work", value: "mark@tinyhippos.com", pref: false }]
-        }],
-    navi;
+            "emails": [{ type: "work", value: "mark@tinyhippos.com", pref: false }]
+        }];
 
     beforeEach(function () {
-        navi = global.navigator;
         s = jasmine.createSpy("success");
         e = jasmine.createSpy("error");
-        global.navigator = {
-            contacts: {
-                create: jasmine.createSpy("navigator.contacts.create").andCallFake(function (obj) {
-                    return obj;
-                })
-            }
-        };
-    });
 
-    afterEach(function () {
-        global.navigator = navi;
+        spyOn(emulatorBridge, 'window').andReturn({
+            navigator: {
+                contacts: {
+                    create: jasmine.createSpy("navigator.contacts.create").andCallFake(function (obj) {
+                        return obj;
+                    })
+                }
+            }
+        });
     });
 
     describe("on search", function () {


[16/28] git commit: Spelling: project

Posted by br...@apache.org.
Spelling: project


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/9127f3b2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/9127f3b2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/9127f3b2

Branch: refs/heads/master
Commit: 9127f3b267e97d3276a5e3ee5c0d5e5690c3ba3a
Parents: 90b94b5
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:41:01 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:35 2013 -0400

----------------------------------------------------------------------
 lib/client/platform/cordova/2.0.0/spec/events.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/9127f3b2/lib/client/platform/cordova/2.0.0/spec/events.js
----------------------------------------------------------------------
diff --git a/lib/client/platform/cordova/2.0.0/spec/events.js b/lib/client/platform/cordova/2.0.0/spec/events.js
index d134d3f..5cf3159 100644
--- a/lib/client/platform/cordova/2.0.0/spec/events.js
+++ b/lib/client/platform/cordova/2.0.0/spec/events.js
@@ -23,7 +23,7 @@ function _fires(name, data) {
         var win = ripple('emulatorBridge').window();
 
         if (!win.cordova) {
-            throw "You must have cordova.js included in your prjects, to be able to trigger events";
+            throw "You must have cordova.js included in your projects, to be able to trigger events";
         }
 
         win.cordova.fireDocumentEvent(name, data);


[02/28] git commit: implemented confirm function in notification js this should fix jira issue #RIPPLE-22

Posted by br...@apache.org.
implemented confirm function in notification js
this should fix jira issue #RIPPLE-22


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/6b92b52b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/6b92b52b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/6b92b52b

Branch: refs/heads/master
Commit: 6b92b52bb772bc8338cd74aa45dbad6863fe937e
Parents: dfdf1f7
Author: Mike Ebinum <me...@gmail.com>
Authored: Thu May 30 18:55:15 2013 +1000
Committer: Brent Lintner <br...@gmail.com>
Committed: Thu Jun 13 12:05:34 2013 -0400

----------------------------------------------------------------------
 lib/client/notifications.js                     | 36 ++++++++++++++++++++
 .../cordova/2.0.0/bridge/notification.js        | 11 ++++--
 .../ui/plugins/confirm-dialog/dialog.html       |  7 ++++
 lib/client/ui/plugins/notifications.js          |  6 ++++
 4 files changed, 58 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/6b92b52b/lib/client/notifications.js
----------------------------------------------------------------------
diff --git a/lib/client/notifications.js b/lib/client/notifications.js
index 45ebe79..17eefe1 100644
--- a/lib/client/notifications.js
+++ b/lib/client/notifications.js
@@ -75,6 +75,38 @@ function _processNotification(nType, stateType, message) {
 
 }
 
+function _processConfirm (message,resultCallback,title,buttonLabels) {
+    buttonLabels = buttonLabels || "";
+    message = message || "";
+    title = title || "Confirm";
+    var btnArray = (!buttonLabels || 0 === buttonLabels.length) ? [] : buttonLabels.split(',');
+    var buttons = [];
+
+    btnArray.forEach(function(btnLabel,index) {
+        var button = {};
+        button["text"] = btnLabel;
+        button["click"] = function () {
+            if(resultCallback !== typeof "undefined")
+                resultCallback(index);
+            jQuery( this ).dialog( "close" );
+        };
+        buttons.push(button);
+    });
+    var dialogBox = jQuery("#confirm-dialog");
+    dialogBox.dialog("option","title", title);
+    jQuery("#confirm-message").text(message);
+    dialogBox.dialog("open");
+    if(btnArray.length > 0){
+        dialogBox.dialog( "option", "buttons", buttons);
+        return;
+    }
+    var closeBox = function() {
+        dialogBox.dialog("close");
+    };
+    jQuery("#confirm-cancel").button().unbind().bind('click', closeBox).show();
+    jQuery("#confirm-ok").button().unbind().bind('click', closeBox).show();
+}
+
 module.exports = {
     openNotification: function (nType, msg) {
         _processNotification(nType, constants.NOTIFICATIONS.STATE_TYPES.OPEN, msg);
@@ -82,5 +114,9 @@ module.exports = {
 
     closeNotification: function (nType) {
         _processNotification(nType, constants.NOTIFICATIONS.STATE_TYPES.CLOSE);
+    },
+
+    confirmNotification: function (message, resultCallback, title, buttonLabels) {
+        _processConfirm(message,resultCallback,title,buttonLabels);
     }
 };

http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/6b92b52b/lib/client/platform/cordova/2.0.0/bridge/notification.js
----------------------------------------------------------------------
diff --git a/lib/client/platform/cordova/2.0.0/bridge/notification.js b/lib/client/platform/cordova/2.0.0/bridge/notification.js
index aa7be30..c278c6e 100644
--- a/lib/client/platform/cordova/2.0.0/bridge/notification.js
+++ b/lib/client/platform/cordova/2.0.0/bridge/notification.js
@@ -28,8 +28,15 @@ module.exports = {
         return success && success();
     },
 
-    confirm: function () {
-        throw "Not Implemented";
+    confirm: function (resultCallback, someObject, confirmStrings) {
+        // For some reason only 3 parameters are passed i
+        //with all the options as the last parameter
+        //this is a HACK to get it to work
+        var options = confirmStrings;
+        var message = options[0] || "";
+        var title = options[1] || "";
+        var buttonLabels = options[2];
+        notifications.confirmNotification(message, resultCallback, title, buttonLabels);
     },
 
     activityStart: function () {

http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/6b92b52b/lib/client/ui/plugins/confirm-dialog/dialog.html
----------------------------------------------------------------------
diff --git a/lib/client/ui/plugins/confirm-dialog/dialog.html b/lib/client/ui/plugins/confirm-dialog/dialog.html
new file mode 100644
index 0000000..c8cca77
--- /dev/null
+++ b/lib/client/ui/plugins/confirm-dialog/dialog.html
@@ -0,0 +1,7 @@
+<div id="confirm-dialog">
+    <p id="confirm-message">
+    </p>
+    <br/>
+    <button id="confirm-cancel" style="display:none">Cancel</button>
+    <button id="confirm-ok" style="display:none">Ok</button>
+</div>
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/6b92b52b/lib/client/ui/plugins/notifications.js
----------------------------------------------------------------------
diff --git a/lib/client/ui/plugins/notifications.js b/lib/client/ui/plugins/notifications.js
index 3bab7b9..0a3768d 100644
--- a/lib/client/ui/plugins/notifications.js
+++ b/lib/client/ui/plugins/notifications.js
@@ -26,5 +26,11 @@ module.exports = {
         jQuery("." + constants.NOTIFICATIONS.CLOSE_BUTTON_CLASS).bind("click", function () {
             notifications.closeNotification();
         });
+        jQuery("#confirm-dialog").dialog({
+            autoOpen: false,
+            modal: true,
+            width: 200,
+            position: 'center',
+        });
     }
 };


[27/28] git commit: Pre-install script (on Windows) causes failure to install via npm.

Posted by br...@apache.org.
Pre-install script (on Windows) causes failure to install via npm.

Since this is a major bug, let's just remove it so it can be fixed
ASAP, especially since its only use is for fun.

Fixes: https://issues.apache.org/jira/browse/RIPPLE-32


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/1ebd828b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/1ebd828b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/1ebd828b

Branch: refs/heads/master
Commit: 1ebd828b38ee0d7fa8333fa956b8fe32132dd9be
Parents: 8f64f68
Author: Brent Lintner <br...@gmail.com>
Authored: Mon Jul 8 09:21:16 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Mon Jul 8 09:31:38 2013 -0400

----------------------------------------------------------------------
 package.json            | 2 --
 thirdparty/ludicrous.js | 4 ----
 2 files changed, 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/1ebd828b/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index e89cb6d..c9d9e06 100644
--- a/package.json
+++ b/package.json
@@ -25,7 +25,6 @@
     "emulator"
   ],
   "bin": { "ripple": "./bin/ripple" },
-  "scripts": {"preinstall": "node thirdparty/ludicrous.js"},
   "main": "./lib/index",
   "dependencies": {
     "express": "3.1.0",
@@ -53,7 +52,6 @@
     "lib/cli",
     "assets/server",
     "pkg/hosted",
-    "thirdparty/ludicrous.js",
     "doc",
     "bin"
   ],

http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/1ebd828b/thirdparty/ludicrous.js
----------------------------------------------------------------------
diff --git a/thirdparty/ludicrous.js b/thirdparty/ludicrous.js
deleted file mode 100644
index 4843980..0000000
--- a/thirdparty/ludicrous.js
+++ /dev/null
@@ -1,4 +0,0 @@
-console.log("Prepare ship for ludicrous speed!");
-console.log();
-console.log("Fasten all seatbelts, seal all entrances and exits, close all shops in the mall, cancel the three ring circus, secure all animals in the zoo!");
-console.log();


[19/28] git commit: Spelling: [Code Fix] [OpenLayers] attribute

Posted by br...@apache.org.
Spelling: [Code Fix] [OpenLayers] attribute


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/896f2cc4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/896f2cc4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/896f2cc4

Branch: refs/heads/master
Commit: 896f2cc4a8322e2a7a9d385015cb0064403eba77
Parents: 39f44b6
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:32:47 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:37 2013 -0400

----------------------------------------------------------------------
 thirdparty/OpenLayers.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/896f2cc4/thirdparty/OpenLayers.js
----------------------------------------------------------------------
diff --git a/thirdparty/OpenLayers.js b/thirdparty/OpenLayers.js
index d94ff5b..a8f9c01 100644
--- a/thirdparty/OpenLayers.js
+++ b/thirdparty/OpenLayers.js
@@ -479,7 +479,7 @@ a.featureCoordSys),this.addCoordSys(b.filtercoordsys,a.filterCoordSys)):this.req
 null!==b.proj&&(a.id=b.proj.srsProjNumber,a.string=b.proj.srsCode)},iserror:function(a){var b=null;a?(a=OpenLayers.Format.XML.prototype.read.apply(this,[a]),a=a.documentElement.getElementsByTagName("ERROR"),b=null!==a&&0<a.length):b=""!==this.response.error;return b},read:function(a){"string"==typeof a&&(a=OpenLayers.Format.XML.prototype.read.apply(this,[a]));var b=null;a&&a.documentElement&&(b="ARCXML"==a.documentElement.nodeName?a.documentElement:a.documentElement.getElementsByTagName("ARCXML")[0]);
 if(!b||"parsererror"===b.firstChild.nodeName){var c,d;try{c=a.firstChild.nodeValue,d=a.firstChild.childNodes[1].firstChild.nodeValue}catch(e){}throw{message:"Error parsing the ArcXML request",error:c,source:d};}return this.parseResponse(b)},write:function(a){a||(a=this.request);var b=this.createElementNS("","ARCXML");b.setAttribute("version","1.1");var c=this.createElementNS("","REQUEST");if(null!=a.get_image){var d=this.createElementNS("","GET_IMAGE");c.appendChild(d);var e=this.createElementNS("",
 "PROPERTIES");d.appendChild(e);a=a.get_image.properties;null!=a.featurecoordsys&&(d=this.createElementNS("","FEATURECOORDSYS"),e.appendChild(d),0===a.featurecoordsys.id?d.setAttribute("string",a.featurecoordsys.string):d.setAttribute("id",a.featurecoordsys.id));null!=a.filtercoordsys&&(d=this.createElementNS("","FILTERCOORDSYS"),e.appendChild(d),0===a.filtercoordsys.id?d.setAttribute("string",a.filtercoordsys.string):d.setAttribute("id",a.filtercoordsys.id));null!=a.envelope&&(d=this.createElementNS("",
-"ENVELOPE"),e.appendChild(d),d.setAttribute("minx",a.envelope.minx),d.setAttribute("miny",a.envelope.miny),d.setAttribute("maxx",a.envelope.maxx),d.setAttribute("maxy",a.envelope.maxy));d=this.createElementNS("","IMAGESIZE");e.appendChild(d);d.setAttribute("height",a.imagesize.height);d.setAttribute("width",a.imagesize.width);if(a.imagesize.height!=a.imagesize.printheight||a.imagesize.width!=a.imagesize.printwidth)d.setAttribute("printheight",a.imagesize.printheight),d.setArrtibute("printwidth",a.imagesize.printwidth);
+"ENVELOPE"),e.appendChild(d),d.setAttribute("minx",a.envelope.minx),d.setAttribute("miny",a.envelope.miny),d.setAttribute("maxx",a.envelope.maxx),d.setAttribute("maxy",a.envelope.maxy));d=this.createElementNS("","IMAGESIZE");e.appendChild(d);d.setAttribute("height",a.imagesize.height);d.setAttribute("width",a.imagesize.width);if(a.imagesize.height!=a.imagesize.printheight||a.imagesize.width!=a.imagesize.printwidth)d.setAttribute("printheight",a.imagesize.printheight),d.setAttribute("printwidth",a.imagesize.printwidth);
 null!=a.background&&(d=this.createElementNS("","BACKGROUND"),e.appendChild(d),d.setAttribute("color",a.background.color.r+","+a.background.color.g+","+a.background.color.b),null!==a.background.transcolor&&d.setAttribute("transcolor",a.background.transcolor.r+","+a.background.transcolor.g+","+a.background.transcolor.b));if(null!=a.layerlist&&0<a.layerlist.length){d=this.createElementNS("","LAYERLIST");e.appendChild(d);for(e=0;e<a.layerlist.length;e++){var f=this.createElementNS("","LAYERDEF");d.appendChild(f);
 f.setAttribute("id",a.layerlist[e].id);f.setAttribute("visible",a.layerlist[e].visible);if("object"==typeof a.layerlist[e].query){var g=a.layerlist[e].query;if(0>g.where.length)continue;var h=null,h="boolean"==typeof g.spatialfilter&&g.spatialfilter?this.createElementNS("","SPATIALQUERY"):this.createElementNS("","QUERY");h.setAttribute("where",g.where);"number"==typeof g.accuracy&&0<g.accuracy&&h.setAttribute("accuracy",g.accuracy);"number"==typeof g.featurelimit&&2E3>g.featurelimit&&h.setAttribute("featurelimit",
 g.featurelimit);"string"==typeof g.subfields&&"#ALL#"!=g.subfields&&h.setAttribute("subfields",g.subfields);"string"==typeof g.joinexpression&&0<g.joinexpression.length&&h.setAttribute("joinexpression",g.joinexpression);"string"==typeof g.jointables&&0<g.jointables.length&&h.setAttribute("jointables",g.jointables);f.appendChild(h)}"object"==typeof a.layerlist[e].renderer&&this.addRenderer(f,a.layerlist[e].renderer)}}}else if(null!=a.get_feature&&(d=this.createElementNS("","GET_FEATURES"),d.setAttribute("outputmode",


[14/28] git commit: Spelling: dynamically

Posted by br...@apache.org.
Spelling: dynamically


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/0334ac18
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/0334ac18
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/0334ac18

Branch: refs/heads/master
Commit: 0334ac18ace12db6f5c03f578cedb88fdf88e2c8
Parents: 59ed2db
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 15:48:29 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:34 2013 -0400

----------------------------------------------------------------------
 lib/server/emulate.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/0334ac18/lib/server/emulate.js
----------------------------------------------------------------------
diff --git a/lib/server/emulate.js b/lib/server/emulate.js
index b6df0a0..d59a7fa 100644
--- a/lib/server/emulate.js
+++ b/lib/server/emulate.js
@@ -40,7 +40,7 @@ module.exports = {
 
         app = proxy.start({route: options.route}, app);
 
-        // TODO does not work with custom route (since ripple does not dynamicaly know custom ones, yet, if set)
+        // TODO does not work with custom route (since ripple does not dynamically know custom ones, yet, if set)
         app.post("/ripple/user-agent", function (req, res/*, next*/) {
             res.send(200);
 


[06/28] git commit: Spelling: [URL] incubator

Posted by br...@apache.org.
Spelling: [URL] incubator


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/4483a238
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/4483a238
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/4483a238

Branch: refs/heads/master
Commit: 4483a238ae9ec5eb40a5bc75893ff65bcccb277f
Parents: 4621106
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:09:27 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:30 2013 -0400

----------------------------------------------------------------------
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/4483a238/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index ee7e58e..e89cb6d 100644
--- a/package.json
+++ b/package.json
@@ -13,7 +13,7 @@
   }],
   "repository": {
     "type": "git",
-    "url": "https://git-wip-us.apache.org/repos/asf/icubator-ripple.git"
+    "url": "https://git-wip-us.apache.org/repos/asf/incubator-ripple.git"
   },
   "keywords": [
     "cordova",


[23/28] git commit: This file path should be joined properly, in consideration of Windows.

Posted by br...@apache.org.
This file path should be joined properly, in consideration of Windows.

I also added a path.resolve call to return a consistent, absolute
file path (for form).


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/dc126033
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/dc126033
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/dc126033

Branch: refs/heads/master
Commit: dc1260333e34504d8630488d5230bb7129524290
Parents: eb098f2
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Jun 25 12:47:52 2013 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Fri Jul 5 17:22:57 2013 -0400

----------------------------------------------------------------------
 lib/server/emulate/hosted.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/dc126033/lib/server/emulate/hosted.js
----------------------------------------------------------------------
diff --git a/lib/server/emulate/hosted.js b/lib/server/emulate/hosted.js
index ab8d6f0..11631e8 100644
--- a/lib/server/emulate/hosted.js
+++ b/lib/server/emulate/hosted.js
@@ -145,7 +145,7 @@ function localInjection(opts) {
             //first matching file
             var fullPath = opts.path.reduce(function (match, curr) {
                 if (match) return match;
-                var file = curr + (req.path.match(/\/$/) ? req.path + "/index.html" : req.path);
+                var file = path.resolve(curr + (req.path.match(/\/$/) ? path.join(req.path, "index.html") : req.path));
                 return fs.existsSync(file) ? file : match;
             }, null);
 


[07/28] git commit: Brand: WebWorks

Posted by br...@apache.org.
Brand: WebWorks


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/46211069
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/46211069
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/46211069

Branch: refs/heads/master
Commit: 46211069ebba166136586ba0e4cafc11ea0d4da1
Parents: 0c233ba
Author: Josh Soref <js...@rim.com>
Authored: Tue Jun 18 16:47:46 2013 -0400
Committer: Josh Soref <js...@rim.com>
Committed: Tue Jun 18 19:03:30 2013 -0400

----------------------------------------------------------------------
 doc/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/46211069/doc/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
index 0c73272..5315092 100644
--- a/doc/CHANGELOG.md
+++ b/doc/CHANGELOG.md
@@ -248,7 +248,7 @@ pull request can be found here: https://github.com/blackberry/Ripple-UI/pull/563
 * (Fix) [WebWorks] bb.invoke.invoke launches undefined application for CameraArguments
 * (Fix) [WebWorks] sms.isListeningForMessage should be settable
 * (Fix) [WebWorks] bb.app issues
-* (Fix) [WebWokrs] bb.ui.menu issues
+* (Fix) [WebWorks] bb.ui.menu issues
 * (Fix) [PhoneGap] When successfully removing a contact, a list of contacts is incorrectly returned
 * (Fix) [PhoneGap] When saving a contact, the returned list is incorrect
 * (Fix) [WebWorks-TabletOS] bb.invoke Browser: URLs do not support certain protocols